Name computation: skip step 1 when descending #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Jym77
added a commit
that referenced
this pull request
Jun 14, 2021
* SIA R3: add test (#792) * SIA R4: test added (#793) * SIA R5: add test (#794) * R6 test added (#795) * SIA-R8: Added tests (#806) * Add basic tests for R11 (#770) * SIA R12: Add Test (#800) * SIA R17: add test (#791) * R18 add test (#803) * SIA-R19: Add test (#807) * Test for SIA-R20 added * Add tests for R42 * Remove second expectation from R62 (#772) * SIA R62: accept different font weight (#779) * Implement pseudo classes equality (#773) * Add equals() and toString() to functional pseudo-classes and elements * Name computation: skip step 1 when descending (#778) * Accessible name: reject whitespace descendants (#831) * Extended diagnostic for R14 (#786) * R16 extended diagnostic (#804) * R62 extended diagnostic (#801) * Fix background-size (#788) * Support text-decoration-thickness (#817) * Support `font-variant` CSS property (#821) * Assume no background on size (#789) * Fix hasRole to pick the role from the accessible node (#805) * Increase Nodejs heap size (#818) * SIA R65: accept different border as focus indicator (#819) * Implement SIA R56 (#829) Co-authored-by: elenamongelli <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kasper Isager <[email protected]>
elenamongelli
added a commit
that referenced
this pull request
Jul 7, 2021
* Add basic tests for R11 (#770) * Remove second expectation from R62 (#772) * Implement pseudo classes equality (#773) * Add toString() to Nth * Add equals() and toString() to functional pseudo-classes and elements * Name computation: skip step 1 when descending (#778) * Add failing example * Skip step 1 when descending * SIA R62: accept different font weight (#779) * Add failing example * Accept font weight difference with container as good for SIA-R62 * Extended diagnostic for R14 (#786) * Add label and name in Diagnostic for R14 * Add tests for R42 * Fix background size (#788) * Add test cases for `background-size` * Accept percentages and two values for background-size * Use Tuple to store dimensions in background-size * Assume no background on size (#789) * Bail out of background colour computation when encountering a background-size * SIA R17: add test (#791) * Create rule.spec.tsx * sia-r17 added test * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * SIA R4: test added (#793) * SIA R3: add test (#792) * Sia r3 testing added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * R6 test added (#795) * Run prettier * Add --immutable flag to install instruction, add intructions for running tests * Simplify double negative * SIA R5: add test (#794) * Test r5 added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * variable const target changed to html Co-authored-by: Jean-Yves Moyen <[email protected]> * SIA R12: Add Test (#800) * Pass tests for R12 implemented, starting with failed * Update rule.spec.tsx * Test rule 12 finished * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Text sintax improved Co-authored-by: Jean-Yves Moyen <[email protected]> * Fix hasRole to pick the role from the accessible node (#805) * Clean up * R18 add test (#803) * Bump actions/create-release from 1 to 1.1.4 (#802) Bumps [actions/create-release](https://github.com/actions/create-release) from 1 to 1.1.4. - [Release notes](https://github.com/actions/create-release/releases) - [Commits](actions/create-release@v1...v1.1.4) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * SIA R18: Added test Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jean-Yves Moyen <[email protected]> * SIA-R19: Add test (#807) * Test for R19 Added * Added test for rule 19 * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * SIA-R8: Added tests (#806) * Added test to Rule 8 * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Jean-Yves Moyen <[email protected]> * R16 extended diagnostic (#804) * Set role name in extended diagnostic * Required attributes added in rule and test * Extended diagnostic added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Correctly send required attributes to diagnostic * Structure diagnostic JSON a bit Co-authored-by: Jean-Yves Moyen <[email protected]> * Clean up test descriptions a bit * Use n-ary and to streamline code * R62 extended diagnostic (#801) * Expanded Diagnostic added for R62, test updated as well * Reduce computation in expected values * Clean up and streamline * Send shorthands for border * Avoid sending styles that are equals to initial * Avoid sending styles that are equals to initial * Send shorthands for outline * Send shorthand for text-decoration * Support text-decoration-thickness (#817) * Support text-decoration-thickness * Send text-decoration-thickness in extended diagnostic of R62 * Remove unused imports * Increase Nodejs heap size (#818) * SIA R65: accept different border as focus indicator (#819) * Remove duplicate test on border-style * Accept difference in border-* as focus indicator * Add some tests * Remove 'found' which is not used by frontend * Fix serialisation of outline * Heap size problem and investigation. (#822) * Double heap size * Support `font-variant` CSS property (#821) * Support font-variant-ligatures * Support font-variant-position * Support font-variant-caps * Support font-variant-numeric * Support font-variant-east-asian * Support font-variant * Support font-variant longhands in font shorthand * Add some test for font-variant * Test for SIA-R20 added * Rule 54 is added, tests need to be completed * Update rule.ts * Update rule.spec.tsx * Clean up * Tests improved and finalized * Update tsconfig.json * Add --immutable flag to install instruction, add intructions for running tests * R16 extended diagnostic (#804) * Set role name in extended diagnostic * Required attributes added in rule and test * Extended diagnostic added * Apply suggestions from code review Co-authored-by: Jean-Yves Moyen <[email protected]> * Correctly send required attributes to diagnostic * Structure diagnostic JSON a bit Co-authored-by: Jean-Yves Moyen <[email protected]> * Avoid sending styles that are equals to initial * Send shorthand for text-decoration * Support text-decoration-thickness (#817) * Support text-decoration-thickness * Send text-decoration-thickness in extended diagnostic of R62 * Rule 54 is added, tests need to be completed * Update rule.ts * Update rule.spec.tsx * Tests improved and finalized * Clean up * Clean up * Clean up * Remove unused imports * Update packages/alfa-rules/src/sia-r54/rule.ts Co-authored-by: Jean-Yves Moyen <[email protected]> * Update packages/alfa-rules/src/sia-r54/rule.ts Co-authored-by: Jean-Yves Moyen <[email protected]> * Update packages/alfa-rules/test/sia-r54/rule.spec.tsx Co-authored-by: Jean-Yves Moyen <[email protected]> * Update packages/alfa-rules/test/sia-r54/rule.spec.tsx Co-authored-by: Jean-Yves Moyen <[email protected]> * Update packages/alfa-rules/test/sia-r54/rule.spec.tsx Co-authored-by: Jean-Yves Moyen <[email protected]> * Update packages/alfa-rules/test/sia-r54/rule.spec.tsx Co-authored-by: Jean-Yves Moyen <[email protected]> * Update packages/alfa-rules/test/sia-r54/rule.spec.tsx Co-authored-by: Jean-Yves Moyen <[email protected]> * Update packages/alfa-rules/test/sia-r54/rule.spec.tsx Co-authored-by: Jean-Yves Moyen <[email protected]> * Update rule.ts * Comments have been implemented Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #776
Resolves #769