Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SIA-R54 #834

Merged
merged 77 commits into from
Jul 7, 2021
Merged

Implement SIA-R54 #834

merged 77 commits into from
Jul 7, 2021

Conversation

elenamongelli
Copy link
Contributor

@elenamongelli elenamongelli commented Jun 14, 2021 •
edited
Loading

Closes #825

Jym77 and others added 30 commits April 20, 2021 16:36
@Jym77
Add basic tests for R11 (#770)
a2c09e0
@Jym77
Remove second expectation from R62 (#772)
b3b3d06
@Jym77
Implement pseudo classes equality (#773)
53089a6 
* Add toString() to Nth
* Add equals() and toString() to functional pseudo-classes and elements
@Jym77
Name computation: skip step 1 when descending (#778)
6aac6f4 
* Add failing example
* Skip step 1 when descending
@Jym77
SIA R62: accept different font weight (#779)
e6fb3bb 
* Add failing example
* Accept font weight difference with container as good for SIA-R62
@Jym77
Extended diagnostic for R14 (#786)
39be660 
* Add label and name in Diagnostic for R14
* Add tests for R42
@Jym77
Fix background size (#788)
597c2a1 
* Add test cases for `background-size`
* Accept percentages and two values for background-size
* Use Tuple to store dimensions in background-size
@Jym77
Assume no background on size (#789)
8b586a4 
* Bail out of background colour computation when encountering a background-size
@elenamongelli @Jym77
SIA R17: add test (#791)
62d1132 
* Create rule.spec.tsx

* sia-r17 added test

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <[email protected]>

Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli
SIA R4: test added (#793)
a78c527
@elenamongelli @Jym77
SIA R3: add test (#792)
69ea3cd 
* Sia r3 testing added

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <[email protected]>

Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli
R6 test added (#795)
4f5fddd
@Jym77
Run prettier
b5f2dd6
@Jym77
Add --immutable flag to install instruction, add intructions for runn…
0c2977c 
…ing tests
@Jym77
Simplify double negative
f66b35e
@elenamongelli @Jym77
SIA R5: add test (#794)
6bc0448 
* Test r5 added

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <[email protected]>

* variable const target changed to html

Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
SIA R12: Add Test (#800)
96f6a4c 
* Pass tests for R12 implemented, starting with failed

* Update rule.spec.tsx

* Test rule 12 finished

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <[email protected]>

* Text sintax improved

Co-authored-by: Jean-Yves Moyen <[email protected]>
@Jym77
Fix hasRole to pick the role from the accessible node (#805)
46eed6f
@Jym77
Merge branch 'main' into develop
39fbaad
@Jym77
Clean up
71d5482
@elenamongelli @dependabot @Jym77
R18 add test (#803)
3129b13 
* Bump actions/create-release from 1 to 1.1.4 (#802)

Bumps [actions/create-release](https://github.com/actions/create-release) from 1 to 1.1.4.
- [Release notes](https://github.com/actions/create-release/releases)
- [Commits](actions/create-release@v1...v1.1.4)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* SIA R18: Added test

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
SIA-R19: Add test (#807)
1a8b05b 
* Test for R19 Added

* Added test for rule 19

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <[email protected]>

Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
SIA-R8: Added tests (#806)
0378d6f 
* Added test to Rule 8

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <[email protected]>

Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
R16 extended diagnostic (#804)
98237ce 
* Set role name in extended diagnostic

* Required attributes added in rule and test

* Extended diagnostic added

* Apply suggestions from code review

Co-authored-by: Jean-Yves Moyen <[email protected]>

* Correctly send required attributes to diagnostic

* Structure diagnostic JSON a bit

Co-authored-by: Jean-Yves Moyen <[email protected]>
@Jym77
Clean up test descriptions a bit
6ec7b83
@Jym77
Use n-ary and to streamline code
e5950db
@elenamongelli
R62 extended diagnostic (#801)
0b0d863 
* Expanded Diagnostic added for R62, test updated as well
* Reduce computation in expected values
* Clean up and streamline
@Jym77
Send shorthands for border
c2333b8
@Jym77
Avoid sending styles that are equals to initial
1d39a93
@Jym77
Avoid sending styles that are equals to initial
456d060
Jym77
Jym77 requested changes Jun 18, 2021
View reviewed changes
packages/alfa-rules/src/sia-r54/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r54/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r54/rule.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r54/rule.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r54/rule.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r54/rule.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r54/rule.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r54/rule.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r54/rule.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r54/rule.spec.tsx Outdated Show resolved Hide resolved
@kasperisager kasperisager changed the title Implement sia r54 Implement SIA-R54 Jun 22, 2021
elenamongelli and others added 9 commits June 23, 2021 12:27
@elenamongelli @Jym77
Update packages/alfa-rules/src/sia-r54/rule.ts
086b37d 
Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
Update packages/alfa-rules/src/sia-r54/rule.ts
8abc44b 
Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
8571f1c 
Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
4b836f5 
Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
76c92fd 
Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
19302a2 
Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
6a0ba0d 
Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli @Jym77
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
b7a11df 
Co-authored-by: Jean-Yves Moyen <[email protected]>
@elenamongelli
Merge branch 'Implement_SIA_R54' of https://github.com/Siteimprove/alfa…
71d553e 
… into Implement_SIA_R54
@Jym77 Jym77 self-requested a review June 24, 2021 14:38
Jym77
Jym77 requested changes Jun 25, 2021
View reviewed changes
packages/alfa-rules/src/sia-r54/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r54/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r54/rule.ts Show resolved Hide resolved
@elenamongelli elenamongelli requested a review from Jym77 June 25, 2021 12:08
Jym77
Jym77 previously requested changes Jun 29, 2021
View reviewed changes
packages/alfa-rules/src/sia-r54/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r54/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r54/rule.ts Outdated Show resolved Hide resolved
@Jym77
Copy link
Contributor

Jym77 commented Jul 2, 2021

Also, the rule needs to be activated in packages/alfa-rules/src/rules.ts. See #850

@elenamongelli elenamongelli dismissed Jym77’s stale review July 5, 2021 12:37

Changes implemented

@elenamongelli elenamongelli requested a review from Jym77 July 5, 2021 12:37
@elenamongelli elenamongelli enabled auto-merge (squash) July 7, 2021 08:12
@elenamongelli elenamongelli merged commit 01db7c6 into main Jul 7, 2021
@elenamongelli elenamongelli deleted the Implement_SIA_R54 branch July 7, 2021 08:26
kasperisager added a commit that referenced this pull request Jul 7, 2021
@kasperisager
Merge branch 'main' into api-extractor
e626ffb 
* main:
  Add commentary and tests to `@siteimprove/alfa-equatable`
  Add `scratches` directory for experimenting (#855)
  Refactor `Hash` and add additional methods (#853)
  Implement SIA-R54 (#834)
  Bump compile target to ES2020
  Remove unused imports
  Activate R55 and R56 (#850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jym77 Jym77 Jym77 approved these changes

@kasperisager kasperisager kasperisager approved these changes

Assignees

@elenamongelli elenamongelli

Labels
minor Backwards-compatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement SIA-R54
3 participants
@elenamongelli @Jym77 @kasperisager