Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SIA-R54 #834

Merged
merged 77 commits into from
Jul 7, 2021
Merged
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
a2c09e0
Add basic tests for R11 (#770)
Jym77 Apr 20, 2021
b3b3d06
Remove second expectation from R62 (#772)
Jym77 Apr 21, 2021
53089a6
Implement pseudo classes equality (#773)
Jym77 Apr 21, 2021
6aac6f4
Name computation: skip step 1 when descending (#778)
Jym77 Apr 27, 2021
e6fb3bb
SIA R62: accept different font weight (#779)
Jym77 Apr 29, 2021
39be660
Extended diagnostic for R14 (#786)
Jym77 May 4, 2021
597c2a1
Fix background size (#788)
Jym77 May 4, 2021
8b586a4
Assume no background on size (#789)
Jym77 May 4, 2021
62d1132
SIA R17: add test (#791)
elenamongelli May 7, 2021
a78c527
SIA R4: test added (#793)
elenamongelli May 7, 2021
69ea3cd
SIA R3: add test (#792)
elenamongelli May 7, 2021
4f5fddd
R6 test added (#795)
elenamongelli May 7, 2021
b5f2dd6
Run prettier
Jym77 May 7, 2021
0c2977c
Add --immutable flag to install instruction, add intructions for runn…
Jym77 May 7, 2021
f66b35e
Simplify double negative
Jym77 May 11, 2021
6bc0448
SIA R5: add test (#794)
elenamongelli May 11, 2021
96f6a4c
SIA R12: Add Test (#800)
elenamongelli May 17, 2021
46eed6f
Fix hasRole to pick the role from the accessible node (#805)
Jym77 May 17, 2021
39fbaad
Merge branch 'main' into develop
Jym77 May 17, 2021
71d5482
Clean up
Jym77 May 17, 2021
3129b13
R18 add test (#803)
elenamongelli May 17, 2021
1a8b05b
SIA-R19: Add test (#807)
elenamongelli May 18, 2021
0378d6f
SIA-R8: Added tests (#806)
elenamongelli May 18, 2021
98237ce
R16 extended diagnostic (#804)
elenamongelli May 19, 2021
6ec7b83
Clean up test descriptions a bit
Jym77 May 19, 2021
e5950db
Use n-ary and to streamline code
Jym77 May 21, 2021
0b0d863
R62 extended diagnostic (#801)
elenamongelli May 26, 2021
c2333b8
Send shorthands for border
Jym77 May 26, 2021
1d39a93
Avoid sending styles that are equals to initial
Jym77 May 26, 2021
456d060
Avoid sending styles that are equals to initial
Jym77 May 26, 2021
e1b4cf0
Send shorthands for outline
Jym77 May 28, 2021
314a272
Send shorthand for text-decoration
Jym77 May 28, 2021
4a8bc76
Support text-decoration-thickness (#817)
Jym77 May 28, 2021
24fa3fb
Merge branch 'main' into develop
Jym77 May 28, 2021
afd1c50
Remove unused imports
Jym77 May 28, 2021
8f0338d
Increase Nodejs heap size (#818)
Jym77 May 28, 2021
3b282b6
SIA R65: accept different border as focus indicator (#819)
Jym77 Jun 1, 2021
dcecc1f
Remove 'found' which is not used by frontend
Jym77 Jun 1, 2021
a087aa5
Fix serialisation of outline
Jym77 Jun 2, 2021
da6a10f
Heap size problem and investigation. (#822)
Jym77 Jun 2, 2021
da99401
Support `font-variant` CSS property (#821)
Jym77 Jun 2, 2021
452bc78
Test for SIA-R20 added
elenamongelli Jun 8, 2021
c8ed930
Rule 54 is added, tests need to be completed
elenamongelli Jun 14, 2021
14ab72d
Update rule.ts
elenamongelli Jun 14, 2021
ce1cb3b
Update rule.spec.tsx
elenamongelli Jun 14, 2021
2881fb2
Merge branch 'main' into Implement_SIA_R54
Jym77 Jun 14, 2021
f40fe0b
Clean up
Jym77 Jun 14, 2021
96f0612
Tests improved and finalized
elenamongelli Jun 14, 2021
6a53810
Merge branch 'Implement_SIA_R54' of https://github.com/Siteimprove/al…
elenamongelli Jun 14, 2021
2728e60
Update tsconfig.json
elenamongelli Jun 17, 2021
e1efa35
Add --immutable flag to install instruction, add intructions for runn…
Jym77 May 7, 2021
46c53c8
R16 extended diagnostic (#804)
elenamongelli May 19, 2021
ab1f90a
Avoid sending styles that are equals to initial
Jym77 May 26, 2021
f584ab4
Send shorthand for text-decoration
Jym77 May 28, 2021
cc44817
Support text-decoration-thickness (#817)
Jym77 May 28, 2021
feb303d
Rule 54 is added, tests need to be completed
elenamongelli Jun 14, 2021
33dd006
Update rule.ts
elenamongelli Jun 14, 2021
806e8f4
Update rule.spec.tsx
elenamongelli Jun 14, 2021
9999e18
Tests improved and finalized
elenamongelli Jun 14, 2021
643da85
Clean up
Jym77 Jun 14, 2021
58ab6cd
Clean up
Jym77 Jun 17, 2021
104d421
Clean up
Jym77 Jun 17, 2021
5221321
Remove unused imports
Jym77 Jun 18, 2021
086b37d
Update packages/alfa-rules/src/sia-r54/rule.ts
elenamongelli Jun 23, 2021
8abc44b
Update packages/alfa-rules/src/sia-r54/rule.ts
elenamongelli Jun 23, 2021
8571f1c
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
elenamongelli Jun 23, 2021
4b836f5
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
elenamongelli Jun 23, 2021
76c92fd
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
elenamongelli Jun 23, 2021
19302a2
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
elenamongelli Jun 23, 2021
6a0ba0d
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
elenamongelli Jun 23, 2021
b7a11df
Update packages/alfa-rules/test/sia-r54/rule.spec.tsx
elenamongelli Jun 23, 2021
71d553e
Merge branch 'Implement_SIA_R54' of https://github.com/Siteimprove/al…
elenamongelli Jun 23, 2021
f3c4d22
Update rule.ts
elenamongelli Jun 25, 2021
6770ee2
Merge branch 'main' into Implement_SIA_R54
elenamongelli Jun 25, 2021
c043042
Comments have been implemented
elenamongelli Jul 5, 2021
f9351d4
Merge branch 'main' into Implement_SIA_R54
Jym77 Jul 5, 2021
d3278c7
Merge branch 'main' into Implement_SIA_R54
elenamongelli Jul 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/alfa-rules/src/sia-r54/rule.ts
Co-authored-by: Jean-Yves Moyen <jym@siteimprove.com>
  • Loading branch information
elenamongelli and Jym77 authored Jun 23, 2021
commit 8abc44bc8580a1b65c0e968e313df7b4ca6b7bc8
2 changes: 1 addition & 1 deletion packages/alfa-rules/src/sia-r54/rule.ts
Original file line number Diff line number Diff line change
@@ -46,5 +46,5 @@ export default Rule.Atomic.of<Page, Element>({
export namespace Outcomes {
export const IsAssertive = Ok.of(Diagnostic.of("The assertive region is atomic"));

export const IsNotAssertive = Err.of(Diagnostic.of("Is not assertive"));
export const IsNotAssertive = Err.of(Diagnostic.of("The assertive region is not atomic"));
}