Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SIA-R55 #835

Merged
merged 9 commits into from
Jun 16, 2021
Merged

Implement SIA-R55 #835

merged 9 commits into from
Jun 16, 2021

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jun 15, 2021

No description provided.

@Jym77 Jym77 added the minor Backwards-compatible change that touches public API label Jun 15, 2021
@Jym77 Jym77 self-assigned this Jun 15, 2021
kasperisager
kasperisager previously requested changes Jun 16, 2021
View reviewed changes
packages/alfa-rules/src/sia-r55/rule.ts Outdated Show resolved Hide resolved
@Jym77 Jym77 dismissed kasperisager’s stale review June 16, 2021 11:12

Changed question URI

@Jym77 Jym77 requested a review from kasperisager June 16, 2021 11:13
kasperisager
kasperisager approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@kasperisager kasperisager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jym77 Jym77 merged commit ba6b3a9 into main Jun 16, 2021
@Jym77 Jym77 deleted the sia-r55 branch June 16, 2021 13:15
@kasperisager
Copy link
Contributor

Oh, there are actually some unused imports in the rule: https://github.com/Siteimprove/alfa/security/code-scanning

@Jym77 Jym77 restored the sia-r55 branch June 16, 2021 14:25
kasperisager added a commit that referenced this pull request Jun 30, 2021
@kasperisager
Merge branch 'main' into api-extractor
c6f87a7 
* main: (43 commits)
  Update lockfile
  Update `normalize-url`
  Update README.md
  Add `archive` option in `Scraper#scrape()` (#840)
  Pass roles as part of diagnostics in SIA-R55 and SIA-R56 (#838)
  Update Node.js versions for workflows
  Fix listing of contrast ratios
  SIA R55: clean up unused imports (#836)
  Implement SIA-R55 (#835)
  Consider element with `height` or `width` of 0 as invisible unless the text overflows (#827)
  Formatting
  v0.19.0
  Update changelog
  Develop branch (#771)
  v0.18.0
  Update changelog
  Add missing annotations
  Deduplicate dependencies
  Update dependencies
  Bump browserslist from 4.16.3 to 4.16.6 (#814)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperisager kasperisager kasperisager approved these changes

@elenamongelli elenamongelli Awaiting requested review from elenamongelli

Assignees

@Jym77 Jym77

Labels
minor Backwards-compatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jym77 @kasperisager