Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balancer Composable stable pool strategy #1839

Closed
wants to merge 161 commits into from
Closed

Balancer Composable stable pool strategy #1839

wants to merge 161 commits into from

Commits on Jun 14, 2023

  1. initail commit

    @sparrowDom
    sparrowDom committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    21d28ff View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @sparrowDom
    sparrowDom committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    ca4b9c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. intermediary commit

    @sparrowDom
    sparrowDom committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    bd17a59 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. commit research files

    @sparrowDom
    sparrowDom committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    e218397 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. balancer booster abi

    @sparrowDom
    sparrowDom committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    e40539a View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. intermittent commit

    @sparrowDom
    sparrowDom committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    fddfc96 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. add base balancer contract that implements checkBalance functionality

    @sparrowDom
    sparrowDom committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    4d61080 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. add some additional initial integration

    @sparrowDom
    sparrowDom committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c941766 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @sparrowDom
    sparrowDom committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4e2a0ac View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. intermittent commit

    @sparrowDom
    sparrowDom committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    a163e8f View commit details
    Browse the repository at this point in the history

  2. add deployment file

    @sparrowDom
    sparrowDom committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    6322507 View commit details
    Browse the repository at this point in the history

  3. add fork test fixture

    @sparrowDom
    sparrowDom committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    5150986 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. intermittent commit

    @sparrowDom
    sparrowDom committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    fa5838b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. prettier

    @sparrowDom
    sparrowDom committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    74f1403 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. add basic withdrawal / deposit functionality

    @sparrowDom
    sparrowDom committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    10b6fdc View commit details
    Browse the repository at this point in the history

  2. correct the BPT calculation

    @sparrowDom
    sparrowDom committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    807e8c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. prettier + lint

    @sparrowDom
    sparrowDom committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    8f16b4e View commit details
    Browse the repository at this point in the history

  2. simplify the BPT price calculation

    @sparrowDom
    sparrowDom committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    1c782a5 View commit details
    Browse the repository at this point in the history

  3. add read-only re-entrancy protection

    @sparrowDom
    sparrowDom committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    faa7eb5 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. add some missing tests and adjust existing. Deparate deposit and with… 

    …drawal slippage
    @sparrowDom
    sparrowDom committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c6b45c3 View commit details
    Browse the repository at this point in the history

  2. fix check balance implementation

    @sparrowDom
    sparrowDom committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c77a296 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Balancer review changes (#1726) 

    * Generated contract docs

* Refactor Balancer storage variables

* Small Balancer changes

* Natspec updates
Added missing licensing
getPoolAssets gas optimized

* Updated generated Balancer strategy contract diagrams

* fix contract linter

* Removed restrictions on tests

* Small gas improvements
Fixed Slither

* Change BalancerError version

* Updated constant names
Addresses to use checksum format

* JS lint tasks

* Updated Balancer and Aura pool id constants

* Removed getRateProviderRate as it wasn't being used
Refactored to remove poolAssetsMapped storage variable

* Updated OETH Contracts diagrams
Generated new Balancer contract diagrams

* Fix failing test

* Fix merge conflict

* Restored getRateProviderRate

* Natspec updates
Added toPoolAsset override

* Removed unused getRateProviderRate

* Natspec updates
Gas optimization of InitializableAbstractStrategy

* Abstract strategy gas improvements (#1719)

* Refactor base strategy to use immutables

* Fixed strategy deployments in 001_core and fixtures

* Generated new strategy diagrams

* Deploy rETH instead of the stETH Balancer MetaStable Pool

* removed unused Aura config

* Balancer fork tests

* Added check that BPT amount equals Aura LP amount
Added rETH conversion to ETH value

* Updated balancer strat fork tests

* Updated Balancer fork tests

* Added optional deposit with multiple assets to the strategy

* Single asset deposit to use multi asset deposit

* Added optional checkBalance to Balancer strategy

* Added checkBalance() to BaseBalancerStrategy

* Fix slither
Fix curve HH task

* Added multi-asset withdraw to balancer strategy

* Fix multi-asset withdraw

* Updated Balancer and Vault diagrams

* Fix js linter

* Fixed checkBalance of rETH asset in Balancer strategy

* Only wrap assets if amount > 0
Added depositAll fork test for Balancer strat

* Removed Vault changes for multi-asset strategy support

* Updated generated docs

* Add tests for wstETH/WETH Balancer pool (#1725)

* Split deployment and fix fixtures

* Deposit tests for wstETH/WETH pool

* Add withdraw test

* prettier

* remove .only in fork tests

---------

Co-authored-by: Shahul Hameed <[email protected]>
    @naddison36 @shahthepro
    naddison36 and shahthepro authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    75329db View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @naddison36
    naddison36 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ea68019 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @naddison36
    naddison36 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5607b5d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. [ DFD-1 ] Balancer's checkBalance (#1730) 

    * add alternative implementation of Balancer's checkBalance

* correct the checkBalance implementation
    @sparrowDom
    sparrowDom authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    012a83d View commit details
    Browse the repository at this point in the history

  2. Balancer fork tests (#1727) 

    * Added large withdraw tests for Balancer strategy

* fix test log

* Balancer withdraw to handle close to BPT limit

* Small change to Balancer withdraw fork test

* add some comments

* change implementation

---------

Co-authored-by: Domen Grabec <[email protected]>
    @naddison36 @sparrowDom
    naddison36 and sparrowDom authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b120330 View commit details
    Browse the repository at this point in the history

  3. Add read-only reentrancy test (#1731) 

    * Added large withdraw tests for Balancer strategy

* fix test log

* Balancer withdraw to handle close to BPT limit

* Small change to Balancer withdraw fork test

* add some comments

* Add test for read-only reentrancy

* add reentrancy protection to checkBalance functions

* add documentation

* remove the only

---------

Co-authored-by: Nicholas Addison <[email protected]>
Co-authored-by: Domen Grabec <[email protected]>
    @shahthepro @naddison36 @sparrowDom
    3 people authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    39a7b3f View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Balancer fixes (#1734) 

    * prettier

* adjust how checkBalance is calculated
    @sparrowDom
    sparrowDom authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    346d949 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. Balancer withdrawal fix (#1739) 

    * fix balancer withdrawals

* lint

* prettier
    @sparrowDom
    sparrowDom authored Aug 5, 2023
    Configuration menu
    Copy the full SHA
    fbafb80 View commit details
    Browse the repository at this point in the history

  2. use only 1 safeApprove when applicable

    @sparrowDom
    sparrowDom committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    430fbad View commit details
    Browse the repository at this point in the history

  3. some renames and more correct application of approves

    @sparrowDom
    sparrowDom committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    3ec984c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. renames, additional requires, move initializer to a better location, … 

    …slither
    @sparrowDom
    sparrowDom committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    ecceeb1 View commit details
    Browse the repository at this point in the history

  2. bug fix

    @sparrowDom
    sparrowDom committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    eb11498 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Generated latest Balancer strategy diagrams

    @naddison36
    naddison36 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    a25a661 View commit details
    Browse the repository at this point in the history

  2. re-deploy BPT tokens sitting in the strategy

    @sparrowDom
    sparrowDom committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b9dd480 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Merge branch 'master' into sparrowDom/balancer-sfrxETH-stETH-rETH

    @sparrowDom
    sparrowDom committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    3af8527 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. fix re-entrancy test

    @sparrowDom
    sparrowDom committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3767bb2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @sparrowDom
    sparrowDom committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3cdbdba View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. fixture fix

    @sparrowDom
    sparrowDom committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c69369e View commit details
    Browse the repository at this point in the history

  2. bug fix

    @sparrowDom
    sparrowDom committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8a26a4e View commit details
    Browse the repository at this point in the history

  3. prettier

    @sparrowDom
    sparrowDom committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    afb2d67 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @sparrowDom
    sparrowDom committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    3ae0892 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @sparrowDom
    sparrowDom committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b321712 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. L02 improve naming (#1783) 

    * improve naming

* one more rename

* buf fix
    @sparrowDom
    sparrowDom authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    34608a7 View commit details
    Browse the repository at this point in the history

  2. do a check that supported assets are being withdrawn (#1784)

    @sparrowDom
    sparrowDom authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a323447 View commit details
    Browse the repository at this point in the history

  3. set uint256 max instead of magic number (#1782)

    @sparrowDom
    sparrowDom authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7d8c3fa View commit details
    Browse the repository at this point in the history

  4. remove unused files (#1785)

    @sparrowDom
    sparrowDom authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d4eef49 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. fix renaming bug

    @sparrowDom
    sparrowDom committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4d36852 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. correct safe approve all tokens and adjust the documentation (#1776)

    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d206ce4 View commit details
    Browse the repository at this point in the history

  2. prettier

    @sparrowDom
    sparrowDom committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b127355 View commit details
    Browse the repository at this point in the history

  3. M04 - minBptFunction robustness (#1795) 

    * change bptExpected to ignore Oracle prices and assume assets are always pegged. (Vault value checker shall be used to mitigate issues with said assumption)

* fix all the tests

* add test for pool manipulation

* prettier & lint

* minor change

* add withdrawal test

* update documentation

* pick string error length that is smaller than 32 characters

* prettier

* correct comment

* better comments

* prettier
    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    6ad405c View commit details
    Browse the repository at this point in the history

  4. M02 withdrawal fuzzing tests (#1801) 

    * add more withdrawal tests

* add more withdrawal cases
    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    04b3010 View commit details
    Browse the repository at this point in the history

  5. N02 gas inefficiencies (#1786) 

    * gas optimisation

* fix bad merge and prettier
    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    852afa4 View commit details
    Browse the repository at this point in the history

  6. remove todo comments (#1796)

    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    abf482f View commit details
    Browse the repository at this point in the history

  7. use a more appropriate array initialisation length (#1800)

    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d159fbe View commit details
    Browse the repository at this point in the history

  8. more consistant function naming (#1797)

    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    e09a9b9 View commit details
    Browse the repository at this point in the history

  9. fix typo (#1798)

    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    daeab91 View commit details
    Browse the repository at this point in the history

  10. simplify the way we withdrawAll. no need to pass along min amonts (#1777 

    )
    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a2f8fcd View commit details
    Browse the repository at this point in the history

  11. M03 - missing or misleading documentation (#1781) 

    * improve documentation

* add comma
    @sparrowDom
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    cf4122a View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. M01 More comprehensive test suite (#1780) 

    * add tests for approving tokens and harvesting rewards

* prettier and lint
    @sparrowDom
    sparrowDom authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    fcc08f7 View commit details
    Browse the repository at this point in the history

  2. fix bad merge + prettier & lint

    @sparrowDom
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    5a338d6 View commit details
    Browse the repository at this point in the history

  3. fix fork tests remove .only

    @sparrowDom
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    d2c0039 View commit details
    Browse the repository at this point in the history

  4. remove only

    @sparrowDom
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    70b4481 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @sparrowDom
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    71332e5 View commit details
    Browse the repository at this point in the history

  6. lint

    @sparrowDom
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    900e6d0 View commit details
    Browse the repository at this point in the history

  7. fix unit tests

    @sparrowDom
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    38a7e86 View commit details
    Browse the repository at this point in the history

  8. add more tests to see how checkBalance behaves

    @sparrowDom
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    3fd8f23 View commit details
    Browse the repository at this point in the history

  9. remove console log

    @sparrowDom
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    88bfd30 View commit details
    Browse the repository at this point in the history

  10. improve checkBalance test by testing that checkBalance amount doesn't… 

    … decrease after the attack comaring to the middle of the attack.
    @sparrowDom
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    b7e0dc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. confirm that yield gained by 3rd party tilting the pool can be extrac… 

    …ted by withdrawing the funds
    @sparrowDom
    sparrowDom committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a0cb919 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. rename internal functions by prepending them with underscore

    @sparrowDom
    sparrowDom committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    0f02fad View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @sparrowDom
    sparrowDom committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    e95315a View commit details
    Browse the repository at this point in the history

  3. Generated latest Balancer strategy diagrams (#1805)

    @naddison36
    naddison36 authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    3019b49 View commit details
    Browse the repository at this point in the history

  4. bug fix

    @sparrowDom
    sparrowDom committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6b5a2b4 View commit details
    Browse the repository at this point in the history

  5. bug fix

    @sparrowDom
    sparrowDom committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    09684fd View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Minor Balancer changes from final review (#1819) 

    * Removed unused imports

* Generated updated contract diagram
    @naddison36
    naddison36 authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    d8d6aa5 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-sfrxETH-stETH-rETH
    @sparrowDom
    sparrowDom committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    1ad9e71 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. add proof of concept in brownie how to join/exit composable stable pools

    @sparrowDom
    sparrowDom committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    64a1ada View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. make deposits function

    @sparrowDom
    sparrowDom committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    535534d View commit details
    Browse the repository at this point in the history

  2. commit intermediate work

    @sparrowDom
    sparrowDom committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    932a198 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. intermediary work comitted

    @sparrowDom
    sparrowDom committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    730e7e7 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. make withdrawals work

    @sparrowDom
    sparrowDom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    de35628 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    8bfb9b9 View commit details
    Browse the repository at this point in the history

  3. fix withdrawal tests

    @sparrowDom
    sparrowDom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    95b1520 View commit details
    Browse the repository at this point in the history

  4. minor change

    @sparrowDom
    sparrowDom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    9bcac23 View commit details
    Browse the repository at this point in the history

  5. remove unneeded files

    @sparrowDom
    sparrowDom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    3db3802 View commit details
    Browse the repository at this point in the history

  6. remove unused lines

    @sparrowDom
    sparrowDom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    e188604 View commit details
    Browse the repository at this point in the history

  7. cleanup

    @sparrowDom
    sparrowDom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    4aaa34b View commit details
    Browse the repository at this point in the history

  8. minor change

    @sparrowDom
    sparrowDom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    16c38bf View commit details
    Browse the repository at this point in the history

  9. wording

    @sparrowDom
    sparrowDom committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c26743d View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a1afaf3 View commit details
    Browse the repository at this point in the history

  2. cache the rateProviders request

    @sparrowDom
    sparrowDom committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8c87320 View commit details
    Browse the repository at this point in the history

  3. move some variable initialization to constructor

    @sparrowDom
    sparrowDom committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c21d6f4 View commit details
    Browse the repository at this point in the history

  4. reduce code by 1 line

    @sparrowDom
    sparrowDom committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c87d2d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. make frxETH funding more resiliant

    @sparrowDom
    sparrowDom committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9504702 View commit details
    Browse the repository at this point in the history

  2. add the correct proposal id for 77 deploy

    @sparrowDom
    sparrowDom committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    852f362 View commit details
    Browse the repository at this point in the history

  3. slither

    @sparrowDom
    sparrowDom committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    352a315 View commit details
    Browse the repository at this point in the history

  4. prettier

    @sparrowDom
    sparrowDom committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    175dc26 View commit details
    Browse the repository at this point in the history

  5. remove unneded line

    @sparrowDom
    sparrowDom committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    1f58b97 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    ebbf77c View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Balancer Strategy Code Simplification (#1851) 

    * Code simplification

* Fix storage slot

* Prettify

* Fix test name

* Fix _getRateProviderRate function

* Add comment

* Simplify further
    @shahthepro
    shahthepro authored Oct 4, 2023
    Configuration menu
    Copy the full SHA
    be15ba6 View commit details
    Browse the repository at this point in the history

  2. add some documentation

    @sparrowDom
    sparrowDom committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    d925894 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    d5f7e7e View commit details
    Browse the repository at this point in the history

  2. fix non working trace

    @sparrowDom
    sparrowDom committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    fc2976d View commit details
    Browse the repository at this point in the history

  3. remove unneeded changes

    @sparrowDom
    sparrowDom committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    50aa75f View commit details
    Browse the repository at this point in the history

  4. add tests for depositing withdrawing with the wrong asset

    @sparrowDom
    sparrowDom committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4f10493 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b5502a0 View commit details
    Browse the repository at this point in the history

  2. prettier

    @sparrowDom
    sparrowDom committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c64a329 View commit details
    Browse the repository at this point in the history

  3. prettier & lint

    @sparrowDom
    sparrowDom committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f4ecf97 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Balancer Composable Pool contract diagrams (#1874) 

    * Generated Balancer contract diagrams

* Added BalancerComposablePoolStrategy to OETH contracts diagram
    @naddison36
    naddison36 authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    b93e1be View commit details
    Browse the repository at this point in the history

  2. Add generalised pool tilt functionality (#1849) 

    * refactor file locations and add general tilt functionality

* make tilt/untilt work with composable stable pool

* lint

* remove unused params

* no global variables

* fix

* better error message

* bug fix

* prettier

* linter

* fix

* prettier

* Add reallocation runlog (#1871)

* make code more efficient and fix no signer returned bug

---------

Co-authored-by: Shahul Hameed <[email protected]>
    @sparrowDom @shahthepro
    sparrowDom and shahthepro authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    fd5c36b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    1eeb8a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. make immutables public for easier inspection

    @sparrowDom
    sparrowDom committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    4075c4a View commit details
    Browse the repository at this point in the history

  2. Hot deploy & Balancer rate provider fix (#1877) 

    * more efficient rate provider cache and hot deploy a contract

* expose rate providers for composable pool as well

* prettier

* fix issues with fixture caching

* fix different types of senders

* prettier
    @sparrowDom
    sparrowDom authored Oct 22, 2023
    Configuration menu
    Copy the full SHA
    f0cb237 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. fix the fork test

    @sparrowDom
    sparrowDom committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    d99a8ea View commit details
    Browse the repository at this point in the history

  2. fix fork test

    @sparrowDom
    sparrowDom committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    5f09a8d View commit details
    Browse the repository at this point in the history

  3. add comment

    @sparrowDom
    sparrowDom committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    933009b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. prettier

    @sparrowDom
    sparrowDom committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ab58728 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5e18318 View commit details
    Browse the repository at this point in the history

  3. minor fix

    @sparrowDom
    sparrowDom committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    7f05e62 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    bcb746c View commit details
    Browse the repository at this point in the history

  2. prettier

    @sparrowDom
    sparrowDom committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    423be2a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. remove console log

    @sparrowDom
    sparrowDom committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    292db7a View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. rename deploy script

    @sparrowDom
    sparrowDom committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    4ac3998 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. C-01 DoS Due to Unrestricted Growth of poolAssets Array (#1889) 

    * fix the critical bug of being able to cache pool assets twice

* auto re-enable test when new contract implementation is deployed
    @sparrowDom
    sparrowDom authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ea1c8ef View commit details
    Browse the repository at this point in the history

  2. fix an issue with calling withdrawAll (#1909)

    @sparrowDom
    sparrowDom authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b4afff5 View commit details
    Browse the repository at this point in the history

  3. M-02 Incorrect Assumption That Pool’s BPT Is the First Token in Balan… 

    …cer Pool (#1912)

* initial fix

* add checks when strategies are miss-configured

* cleanup

* test for the correct error message
    @sparrowDom
    sparrowDom authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5705849 View commit details
    Browse the repository at this point in the history

  4. L-01 Duplicate Strategy Assets Can Be Passed to _withdraw (#1913) 

    * add checks so deposits and withdrawals with duplicate assets are not possible

* add comment

* fix comment

* fix comment
    @sparrowDom
    sparrowDom authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e0005ec View commit details
    Browse the repository at this point in the history

  5. add support to withdraw the liquidity when balancer pool is in recove… 

    …ry mode (#1923)
    @sparrowDom
    sparrowDom authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b2313d5 View commit details
    Browse the repository at this point in the history

  6. N-01 Gas Inefficiencies (#1919) 

    * add gas optimizations

* do not shadow variables
    @sparrowDom
    sparrowDom authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5b6066c View commit details
    Browse the repository at this point in the history

  7. safely approve assets where required (#1920)

    @sparrowDom
    sparrowDom authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    0d45ea7 View commit details
    Browse the repository at this point in the history

  8. renames (#1921)

    @sparrowDom
    sparrowDom authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    bcaae0e View commit details
    Browse the repository at this point in the history

  9. N-04 Unused Code (#1922) 

    * renames

* remove unused code
    @sparrowDom
    sparrowDom authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4d8a33a View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. L-06 Test Coverage Gaps (#1918) 

    * add tests

* add more tests

* add more tests

* add another test

* prettier
    @sparrowDom
    sparrowDom authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a6d6e4f View commit details
    Browse the repository at this point in the history

  2. L-04 Inaccurate IBalancerVault Integration Enums (#1915) 

    * rename enum variables

* L-03 Abstraction of Pool Exit Kinds Is Error-Prone (#1916)

* turn config vars into functions

* clean up deployment files

* clean up comments

* prettier

* prettier
    @sparrowDom
    sparrowDom authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    b13454b View commit details
    Browse the repository at this point in the history

  3. make documentation natspec compliant (#1925)

    @sparrowDom
    sparrowDom authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e2934e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Merge branch 'master' into sparrowDom/balancer-composable-st-pool

    @sparrowDom
    sparrowDom committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    2777a80 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'master' into sparrowDom/balancer-composable-st-pool

    @sparrowDom
    sparrowDom committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    a251071 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    2074f55 View commit details
    Browse the repository at this point in the history

  3. Sparrow dom/balancer composable fixes (#1927) 

    * withdrawAll try-catch

* remove unneeded code
    @sparrowDom
    sparrowDom authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    1320ef5 View commit details
    Browse the repository at this point in the history

  4. remove .only

    @sparrowDom
    sparrowDom committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    815c310 View commit details
    Browse the repository at this point in the history

  5. Revert "remove .only" 

    This reverts commit 815c310.
    @sparrowDom
    sparrowDom committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    33a71ce View commit details
    Browse the repository at this point in the history

  6. remove .only

    @sparrowDom
    sparrowDom committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7729d17 View commit details
    Browse the repository at this point in the history

  7. L-01, L-02 & L-03 addendum (#1929) 

    * add comment and change enum types to uint8

* add better comment
    @sparrowDom
    sparrowDom authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    ddbfb4c View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Merge branch 'master' into sparrowDom/balancer-composable-st-pool

    @sparrowDom
    sparrowDom committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    fde6b01 View commit details
    Browse the repository at this point in the history

  2. resolve slither issuegit st

    @sparrowDom
    sparrowDom committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0ec02f1 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. M-01-late Balancer Review: more robust withdraw from strategies (#1928) 

    * make VaultAdmin not fail when withdrawing from all of the strategis  when withdrawAll from a strategy fails

* add a separate withdrawal function

* remove only

* fix fork tests
    @sparrowDom
    sparrowDom authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    8db6593 View commit details
    Browse the repository at this point in the history

  2. M-02 addendum (#1930) 

    * add tests for wstETH/WETH composable pool to confirm BPT position works as expected

* fix comment

* prettier

* prettier
    @sparrowDom
    sparrowDom authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    a6f3285 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    c25642a View commit details
    Browse the repository at this point in the history

  2. prettier

    @sparrowDom
    sparrowDom committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    dce9bbc View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Fix unit tests

    @shahthepro
    shahthepro committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    25df2e6 View commit details
    Browse the repository at this point in the history

  2. Fix unit test

    @shahthepro
    shahthepro committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    635f4a9 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Merge branch 'master' into sparrowDom/balancer-composable-st-pool

    @sparrowDom
    sparrowDom committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    2e00076 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into sparrowDom/balancer… 

    …-composable-st-pool
    @sparrowDom
    sparrowDom committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    bbc2160 View commit details
    Browse the repository at this point in the history

  3. add hot-deploy support for another contract

    @sparrowDom
    sparrowDom committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    47b9c0b View commit details
    Browse the repository at this point in the history

  4. gas optimisation

    @sparrowDom
    sparrowDom committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    8fb75ec View commit details
    Browse the repository at this point in the history

  5. rename variable, add test for double withdrawal. Gas optimisation whe… 

    …n withdrawingAll with no BPT
    @sparrowDom
    sparrowDom committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    6dbb9cd View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. fix the issue with hot deploying twice in the same fixture

    @sparrowDom
    sparrowDom committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    d388725 View commit details
    Browse the repository at this point in the history

  2. prettier

    @sparrowDom
    sparrowDom committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    63fb7fa View commit details
    Browse the repository at this point in the history

  3. fix fork test failing on CI by funding timelock

    @sparrowDom
    sparrowDom committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    a3b3197 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. safeApprove an asset so it won't revert in case of USDT (#1949)

    @sparrowDom
    sparrowDom authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8b94037 View commit details
    Browse the repository at this point in the history