M-02 addendum #1930
Merged
M-02 addendum #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrowDom
requested review from
DanielVF,
naddison36,
shahthepro,
smitch88 and
rafaelugolini
as code owners
sparrowDom
changed the base branch from
master
to
sparrowDom/balancer-composable-st-pool
rafaelugolini
temporarily deployed
to
preview-ousd-sparrowdom-fdvsxe
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sparrowDom/balancer-composable-st-pool #1930 +/- ##
=========================================================================
Coverage ? 68.71%
=========================================================================
Files ? 53
Lines ? 2771
Branches ? 717
=========================================================================
Hits ? 1904
Misses ? 864
Partials ? 3 ☔ View full report in Codecov by Sentry. |
|
Merging this in, since these are only test file changes. |
sparrowDom
merged commit a6f3285
into
sparrowDom/balancer-composable-st-pool
16 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for wstETH/WETH composable pool to confirm BPT position works as expected even when BPT token is in the non first position of the Balancer pool (returned by the
getPoolTokensfunction on the Balancer Vault)