N-01 Gas Inefficiencies #1919
Merged
N-01 Gas Inefficiencies #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrowDom
requested review from
DanielVF,
naddison36 and
shahthepro
as code owners
Codecov Report
@@ Coverage Diff @@
## sparrowDom/balancer-composable-st-pool #1919 +/- ##
=========================================================================
Coverage ? 57.35%
=========================================================================
Files ? 51
Lines ? 2727
Branches ? 703
=========================================================================
Hits ? 1564
Misses ? 1160
Partials ? 3 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
DanielVF
reviewed
Nov 8, 2023
contracts/contracts/strategies/balancer/BalancerMetaPoolStrategy.sol
Outdated
Show resolved
Hide resolved
sparrowDom
requested a deployment
to
preview-ousd-sparrowdom-spdm1b
…/N-01-gas-inefficiencies
sparrowDom
merged commit 5b6066c
into
sparrowDom/balancer-composable-st-pool
8 of 15 checks passed
DanielVF
reviewed
Nov 9, 2023
|
Yup I've merged it to submit it to OZ team. Though I probably wouldn't need to be trigger happy with merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audit notes:
withdrawAll, functions the storage arraypoolAssetsand its length are loaded from the storage multiple times in each function. Consider
loading it into a memory array and then reading from there.
occurrence to ++i as well in order to maintain consistency and save some gas.
When performing these changes, aim to reach an optimal tradeoff between gas optimization
and readability. Having a codebase that is easy to understand reduces the chance of errors in
the future and improves transparency for the community.