Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-01-late Balancer Review: more robust withdraw from strategies #1928

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Nov 13, 2023

  • add a faultTolerantWithdrawAllFromStrategies function to vaultAdmin
  • add test where vaultAdmin is force hot deployed to make sure the functionality works
  • the vaultAdmin deployment fixture fails when attempting to force deployed the VaultAdmin that has been already updated on the mainnet

Copy link

github-actions bot commented Nov 13, 2023

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against cef7b5b

@rafaelugolini rafaelugolini temporarily deployed to preview-ousd-sparrowdom-p3yg2u November 13, 2023 14:32 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-p3yg2u November 13, 2023 16:12 Inactive
Copy link
Collaborator

@DanielVF DanielVF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge, will fully verify when integrated. 👍

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0ec02f1) 68.04% compared to head (b154da5) 57.52%.

❗ Current head b154da5 differs from pull request most recent head cef7b5b. Consider uploading reports for the commit cef7b5b to get more accurate results

Files Patch % Lines
contracts/contracts/vault/VaultAdmin.sol 0.00% 6 Missing ⚠️
...s/strategies/balancer/BalancerMetaPoolStrategy.sol 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                             @@
##           sparrowDom/balancer-composable-st-pool    #1928       +/-   ##
===========================================================================
- Coverage                                   68.04%   57.52%   -10.52%     
===========================================================================
  Files                                          53       53               
  Lines                                        2763     2771        +8     
  Branches                                      715      717        +2     
===========================================================================
- Hits                                         1880     1594      -286     
- Misses                                        880     1174      +294     
  Partials                                        3        3               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-p3yg2u November 13, 2023 17:09 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-p3yg2u November 13, 2023 17:22 Inactive
@sparrowDom sparrowDom temporarily deployed to preview-ousd-sparrowdom-p3yg2u November 15, 2023 12:14 Inactive
@sparrowDom sparrowDom merged commit 8db6593 into sparrowDom/balancer-composable-st-pool Nov 15, 2023
9 of 14 checks passed
@sparrowDom sparrowDom deleted the sparrowDom/robust-withdraw-all branch November 15, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants