L-02 Balancer Pool Recovery Mode Is Not Supported #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrowDom
requested review from
DanielVF,
naddison36 and
shahthepro
as code owners
Codecov Report
@@ Coverage Diff @@
## sparrowDom/balancer-composable-st-pool #1923 +/- ##
=========================================================================
Coverage ? 57.24%
=========================================================================
Files ? 51
Lines ? 2732
Branches ? 707
=========================================================================
Hits ? 1564
Misses ? 1165
Partials ? 3 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
DanielVF
approved these changes
Nov 8, 2023
…/L-02-recovery-mode
sparrowDom
merged commit b2313d5
into
sparrowDom/balancer-composable-st-pool
8 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Balancer pools may enter a recovery mode, allowing for a simplified exit code path in case the
usual exit path malfunctions. In order to be able to exit when this mode is enabled, userData
must be specifically encoded to signal the exit path type.
According to the recent Balancer post-mortem, the recovery mode is an important feature that
has already been used several times:
It has saved us more than once, including during the present incident.Consider supporting this exit path via an additional withdrawal function.