[WIP] Fix compatibility with DSP 0.9 #506

PhantomGamers · 2022-01-20T18:37:11Z

We need to see what broke after the update. here is a quick list of things that come to my mind atm.

Belts are at least partially broken. picking up items manually does not pick them up for other players, outbound belts from advanced miners do not output stuff for others until they try to build the belts themself, ...
ILS code has been changed (maybe just a bit?), but its hard to update our transpiler to match the new code. Maybe its easier to rewrite it.
did not have a look yet at the logic but as the new item enhancement seems to give % chance boosts (afaik) maybe it could be challenging to sync that?
generally sync the new facilities
new mecha stuff

…ship rendering does work again.

…ew game update and to near host like ship rendering

- Make setting sliders only send packets when mouse button release - Make storage max sliders only apply when dragging stop

- Change to use original method, and on postfix update the changed itemCount. - Client will revert itemCount changes and wait for host approve. - Drone & Ship count update now try to set the total count of working + idle, if total count exceed limit or not enough idle ships, hot will correct the setting value. - AddOrRemoveItemFromStorage now include ``inc``

- Add plierCount, MaxMiningSpeed(Advance miner)

- Disable drone/ship/warper icon buttons when client sends out the request. - Let item count changes in storage reflect immediately because they don't need to be verified by host

- Try to adjust client's Ups in range of 30~120 to match with host when the option is enabled.

Add Sync Ups multiplayer option

…riving at a star (ILS only). Sync ILS/PLS output filter system based.

…tation)

- Let client request for remoteOrder update every 180 ticks.

Refactor StationUIManager (0.9.24)

…x-0.9

…ndering after ILS removal. not perfect but better.

…n multiple clients try to join at the same time.

Jaymus3 · 2022-02-08T04:36:20Z

Tested the mod with a couple of people. So far, everything seems to work properly in the starting system. Got this error when one player disconnected on the other client that was still connected. I've also attached the log from that client. (If this isn't where you'd like pre-release issues reported, feel free to point me to where you'd rather.)

LogOutput.log

sp00ktober · 2022-02-08T07:37:19Z

Totally fine to report here i guess.
There where some other people reporting this too, i wonder if we should handle undefined packets more gracefully

HoshixD · 2022-02-08T13:06:45Z

I did ~ 10h of testing with one of my friends.
So far the mod works like a charm. Some feedback:

We encountered the error of the post above several times (only host). Does not seem to break the game though.
We encountered 3 instances of the game crashing the Laptop of my friend. We can't say whether that is due to the DSP-update or some changes you guys implemented.
There are still some ship artifacts left in orbit (only client) if a player is in transition between systems and the ships use warp cells. Definitely got better though...
Duping seems to be fixed. We found no way to simulate the environment that would allow for the client to dupe items by manually placing them on a belt leading to a storage unit. This no longer works no matter the latency of the host/client.

Thanks for the amount of work and time you put into this. Attached is the log file of the host. I can provide the client file if needed.
LogOutput.log

This reverts commit 355bdbb.

This reverts commit abdabfd.

…ating in space

…x-0.9

…ticShipRenderer.Update().

- Editor now close when there is no existing dyson spheres - Now only unload dyson spheres when arriaving a new star system

- Add backward compatibility in Savemanager - Add sprayer and moniter connection syncing

…code

Bugfix and issue list for 0.8.0 pre-release

…x-0.9

…dateSyncedSandCount(). thanks starfish :)

…state.

PhantomGamers and others added 4 commits January 20, 2022 13:36

initial dsp 0.9 fixes

e178a55

let the project compile again

fc1ad4e

fix CargoTraffic.PickupBeltItems transpiler

ab01621

mod starts again, but ils transpiler is disabled for now

81d365a

sp00ktober mentioned this pull request Jan 24, 2022

Update ILS code for 0.9.x game version #510

Closed

10 tasks

sp00ktober linked an issue Jan 24, 2022 that may be closed by this pull request

Update ILS code for 0.9.x game version #510

Closed

10 tasks

sp00ktober and others added 24 commits January 24, 2022 16:49

updated reverse patch, needs adjustment once transpiler works again. …

5e3c2bd

…ship rendering does work again.

updated reverse patch and transpiler of InternalTickRemote to match n…

5a80e91

…ew game update and to near host like ship rendering

Refactor StationUIManager

e0287a1

Change sliders dragging behaviors

a326498

- Make setting sliders only send packets when mouse button release - Make storage max sliders only apply when dragging stop

Add new station setting in 0.9.24

95ff93a

- Add plierCount, MaxMiningSpeed(Advance miner)

Fix starId in StationUIProcessor

b1773bf

Disable buttons interaction until host response

1bdd56f

- Disable drone/ship/warper icon buttons when client sends out the request. - Let item count changes in storage reflect immediately because they don't need to be verified by host

Add Sync Ups multiplayer option

b999125

- Try to adjust client's Ups in range of 30~120 to match with host when the option is enabled.

Reset FixUPS when the user turns off the option

08c6ca1

Merge pull request #514 from starfi5h/pr-SyncUps

6a00d38

Add Sync Ups multiplayer option

sync AddItem() and TakeItem() calls in InternalTickRemote()

0e7ba4a

Add ItemInc in initial station sync packet

ba4b6fe

sync changes to StationStorage issued by InternalTickRemote

ece5b40

send StationStorage updates only to relevant stars, sync them when ar…

63d1ace

…riving at a star (ILS only). Sync ILS/PLS output filter system based.

fix error triggered by placing a belt with a filter (output belt of s…

ad964b2

…tation)

adjust offset to match original patch

cf9606d

Add remoteOrderUpdate

779e15f

- Let client request for remoteOrder update every 180 ticks.

Merge pull request #513 from starfi5h/pr-StationUI

7af8353

Refactor StationUIManager (0.9.24)

compute ILS energy consumption clientside (thanks starfish)

eef500c

Merge branch 'fix-0.9' of https://github.com/hubastard/nebula into fi…

4aa7b7c

…x-0.9

display joining player name in the popup

94de269

reworked RematchRemotePairs() and fixed some issues regarding ship re…

507493a

…ndering after ILS removal. not perfect but better.

fix issue where the host was locked by the joining player message whe…

8807f76

…n multiple clients try to join at the same time.

fix for wrong colors when players did not use mecha appearance yet.

40b2408

PhantomGamers and others added 23 commits February 8, 2022 11:58

Update websocket-sharp

355bdbb

Revert "Update websocket-sharp"

abdabfd

This reverts commit 355bdbb.

Revert "Revert "Update websocket-sharp""

ad4ec51

This reverts commit abdabfd.

fix compatibility with upstream websocket changes

468df39

fix clientside ILS ship rendering bug that would leave some ships flo…

8252298

…ating in space

Merge branch 'fix-0.9' of https://github.com/hubastard/nebula into fi…

36cc9c2

…x-0.9

separated starting and landing ils ships into their own packages

60626a8

suggest clients to reconnect if IndexOutOfBounds is detected in Logis…

aa39a79

…ticShipRenderer.Update().

Add copy&close error button

972555d

Add notification when dyson sphere is loading

d839dbf

- Editor now close when there is no existing dyson spheres - Now only unload dyson spheres when arriaving a new star system

Fix multiple issues

dec2eee

- Add backward compatibility in Savemanager - Add sprayer and moniter connection syncing

Add belt memo syncing

9c2c21f

fix LogisticShipRenderer transpiler to actually jump to our checking …

3865876

…code

Add prebuildId and entityId checking

dc7b782

Fix DroneCount and ShipCount checking

3dffc2b

Fix placing belts under inserters

227d049

Merge pull request #521 from starfi5h/bugfix-0.9

255ad34

Bugfix and issue list for 0.8.0 pre-release

add optional soil sync feature

653f4f5

Merge branch 'fix-0.9' of https://github.com/hubastard/nebula into fi…

a199b96

…x-0.9

fix soil sync: reform tool soil is synced too. host is included in Up…

e1569ad

…dateSyncedSandCount(). thanks starfish :)

fix double soil given when its synced

ea057f7

sync diy mecha appearance representing the mecha editor contents and …

35e17ba

…state.

bump version and update CHANGELOG

f799c57

sp00ktober marked this pull request as ready for review February 16, 2022 22:06

sp00ktober approved these changes Feb 16, 2022

View reviewed changes

sp00ktober merged commit 250968a into master Feb 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Fix compatibility with DSP 0.9 #506

[WIP] Fix compatibility with DSP 0.9 #506

PhantomGamers commented Jan 20, 2022 •

edited by sp00ktober

Loading

Jaymus3 commented Feb 8, 2022

sp00ktober commented Feb 8, 2022

HoshixD commented Feb 8, 2022

[WIP] Fix compatibility with DSP 0.9 #506

[WIP] Fix compatibility with DSP 0.9 #506

Conversation

PhantomGamers commented Jan 20, 2022 • edited by sp00ktober Loading

Jaymus3 commented Feb 8, 2022

sp00ktober commented Feb 8, 2022

HoshixD commented Feb 8, 2022

PhantomGamers commented Jan 20, 2022 •

edited by sp00ktober

Loading