Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILS storage clients could desync host #249

Closed
sp00ktober opened this issue Apr 29, 2021 · 0 comments · Fixed by #506
Closed

ILS storage clients could desync host #249

sp00ktober opened this issue Apr 29, 2021 · 0 comments · Fixed by #506
Assignees
@sp00ktober

Comments

@sp00ktober
Copy link
Collaborator

in the StationUIManager.cs where StationUI.UIsettings.addOrRemoveItemFromStorageReq is processed clients that have a desynced item state could update the hosts value to the desycned one.
We need to change it such that only the host can send the response.

This case should not occure in normal playthrough as values seem to be synced good, but #234 could maybe lead to this.
@sp00ktober sp00ktober self-assigned this May 3, 2021
@sp00ktober sp00ktober linked a pull request Feb 5, 2022 that will close this issue
[WIP] Fix compatibility with DSP 0.9 #506
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sp00ktober sp00ktober

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Fix compatibility with DSP 0.9 NebulaModTeam/nebula
1 participant
@sp00ktober