Bugfix and issue list for 0.8.0 pre-release #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Editor now close when there is no existing dyson spheres - Now only unload dyson spheres when arriaving a new star system
- Add backward compatibility in Savemanager - Add sprayer and moniter connection syncing
sp00ktober
reviewed
Feb 10, 2022
| } | ||
| } | ||
| if (starData != null && GameMain.data.dysonSpheres[starData.index] == null) | ||
| { | ||
| if (Multiplayer.Session.DysonSpheres.RequestingIndex != -1) | ||
| { | ||
| InGamePopup.ShowInfo("Loading", $"Loading Dyson sphere {starData.displayName}, please wait...", "OK"); |
There was a problem hiding this comment.
As you call fadeout later, why add the Ok button here? :)
There was a problem hiding this comment.
some users may be impatient about loading time, so I add a way to let them close the info window. (although Esc can do the same thing)
sp00ktober
reviewed
Feb 10, 2022
| __instance.ClearAllSelection(); | ||
| __instance.viewStar = starData; | ||
| __instance.viewDysonSphere = null; | ||
| InGamePopup.ShowInfo("Loading", $"Loading Dyson sphere {starData.displayName}, please wait...", "OK"); |
|
OK, this is the last commit in this PR. I don't think entityId will desync if the factory data is corrected transmitted in the first place, but just add in-case so we can rule out entityId desync in future debugging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A list of issues solved/unsolved in 0.8.0 pre-release version
Resolved, will be fixed in the next update:
On client, sprayer and monitor will build to the wrong place when there are multiple prebuilds.
Other players get items refunds too when a player changes the recipe of a lab with matrix in it.
Other clients will receive an undefined packet when a client leaves.
When a player disconnects during loading, the host will get NRE or the whole game pause.
If a loaded remote planet has ILS built by other players, the ILS will not sync on this player and may cause errors when they change its storage.
Player color can show differently on other players (fix in the main branch by sp00ktober)
Clients lose their inventory when loading an old .server file
=> Now support backward compatibility to revision 4 (current: 5)
When a client opens dyson editor without any dyson spheres loaded, it will get an error.
=> Now dyson spheres only unload when arriving a new system
When clients connect sorters output by placing belts under the sorters, the sorters will stop working after host reload the game.
Known issues:
Unknown cause, can't reproduce yet:
Sometimes when host deletes an ILS on a different planet in the same system, client will get an error.
Belts connect randomly on client, fix after reconnection.
Sometimes sorters will stop working. The animation is still running but no cargo is moved. Fix after replacement.
Sometimes the splitter filter is randomly set to the wrong item and can't be changed. Have to replace the splitter.
Sometimes clients can't see the profiler functioning in factories. They don't see the blue bonus bar.
Other changes:
Add a button to copy and close the error message. Special thanks to Therzok's WhatTheBreak and crecheng's CloseError