Refactor StationUIManager (0.9.24) #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make setting sliders only send packets when mouse button release - Make storage max sliders only apply when dragging stop
- Change to use original method, and on postfix update the changed itemCount. - Client will revert itemCount changes and wait for host approve. - Drone & Ship count update now try to set the total count of working + idle, if total count exceed limit or not enough idle ships, hot will correct the setting value. - AddOrRemoveItemFromStorage now include ``inc``
- Add plierCount, MaxMiningSpeed(Advance miner)
starfi5h
changed the title
|
Looks good, gonna give it a try later when im back at my pc. Thanks for your work! |
- Disable drone/ship/warper icon buttons when client sends out the request. - Let item count changes in storage reflect immediately because they don't need to be verified by host
- Let client request for remoteOrder update every 180 ticks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor StationUIManager
OnStationIdChange()to refresh UI.UIIsSyncedStage. DisableUpdateCooldownfor now.[Client]
UIStationWindow._OnOpen(): Hide control panel, sendStationUIInitialSyncRequestto Host[Host] Get requested
stationComponentdata, sendStationUIInitialSyncto Client[Client] Update
stationComponent, callOnStationIdChange()to refresh UI.Change sliders dragging behaviors
Now sliders should send packets less frequently,
Change itemIcon clicking behaviors
count.countchanges and wait for host approval.incif the total count exceeds the limit or not enough idle ships, host will correct the setting value.