[BUG-Fixed] #1466 - create observability dashboard after invalid name #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after creating with Invalid name ### Fix for [BUG] Cannot create observability dashboard after creating with invalid name opensearch-project#1466 - opensearch-project#1466 ### Description Cannot create Observability Dashboards after creating with an Invalid Name ### Issues Resolved Dialog asking user to input Dashboard Name even if invalid Dashboard name is entered ### Check List - [x] New functionality includes testing. - [x] All tests pass, including unit test, integration test and doctest - [ ] New functionality has been documented. - [ ] New functionality has javadoc added - [ ] New functionality has user manual doc added - [x] Commits are signed per the DCO using --signoff By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Mahima Arora <[email protected]>
Mahima081
changed the title
* fix app analytics to properly work Signed-off-by: Paul Sebastian <[email protected]> * enhance explorer to run describe queries Signed-off-by: Paul Sebastian <[email protected]> * use final query field for app analytics support Signed-off-by: Paul Sebastian <[email protected]> * pr requested change Signed-off-by: Paul Sebastian <[email protected]> * changed the wrong thign Signed-off-by: Paul Sebastian <[email protected]> * Update public/services/data_fetchers/ppl/ppl_data_fetcher.ts Co-authored-by: Eric Wei <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Eric Wei <[email protected]>
…options (opensearch-project#1738) * Refactor addIntegrationRequest params to object Signed-off-by: Simeon Widdis <[email protected]> * Move SetupIntegrationFormInputs to own file Signed-off-by: Simeon Widdis <[email protected]> * Split form inputs into more sections visually Signed-off-by: Simeon Widdis <[email protected]> * Split form inputs into more sections logically Signed-off-by: Simeon Widdis <[email protected]> * Minor copy update for checkpoint location Signed-off-by: Simeon Widdis <[email protected]> * Update toggleworkflow method per Ryan's feedback Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
* Refactor addIntegrationRequest params to object Signed-off-by: Simeon Widdis <[email protected]> * Move SetupIntegrationFormInputs to own file Signed-off-by: Simeon Widdis <[email protected]> * Split form inputs into more sections visually Signed-off-by: Simeon Widdis <[email protected]> * Split form inputs into more sections logically Signed-off-by: Simeon Widdis <[email protected]> * Minor copy update for checkpoint location Signed-off-by: Simeon Widdis <[email protected]> * Add UUID to created checkpoint location Signed-off-by: Simeon Widdis <[email protected]> * Use dashes instead of underscores for separating checkpoint parts Signed-off-by: Simeon Widdis <[email protected]> * Update toggleworkflow method per Ryan's feedback Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
* add saved queries to vpc flow Signed-off-by: YANGDB <[email protected]> * add skipping index creation Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]>
…pensearch-project#1747) * Update avg threshold for cloudfront query Signed-off-by: Simeon Widdis <[email protected]> * Add first draft skipping index for cloudfront integration Signed-off-by: Simeon Widdis <[email protected]> * Add skipping index for nginx Signed-off-by: Simeon Widdis <[email protected]> * Add skipping index for s3 Signed-off-by: Simeon Widdis <[email protected]> * Add skipping index for elb Signed-off-by: Simeon Widdis <[email protected]> * Update skipping indices to use bloom filters for client IDs Signed-off-by: Simeon Widdis <[email protected]> * Add skipping index for apache Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
* add cloud trails saved queries asset Signed-off-by: YANGDB <[email protected]> * add cloud trails saved queries asset Signed-off-by: YANGDB <[email protected]> * add skipping index creation Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]>
…on (opensearch-project#1750) * Add skipping index and saved queries for WAF integration Signed-off-by: Ryan Liang <[email protected]> * fixes Signed-off-by: Ryan Liang <[email protected]> * change the timestamp to min_max Signed-off-by: Ryan Liang <[email protected]> * add http source id with bloom filter Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
…pensearch-project#1667) * Add conditional rendering for data connection page for tabs Signed-off-by: Ryan Liang <[email protected]> * Add tests for conditional rendering of data connection tabs Signed-off-by: Ryan Liang <[email protected]> * Reverse the if check for datasource for s3glue Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: YANGDB <[email protected]>
* observability services dashboard integration Signed-off-by: YANGDB <[email protected]> * update integration name in metadata file Signed-off-by: YANGDB <[email protected]> * update names schema folder Signed-off-by: YANGDB <[email protected]> * update names schema folder Signed-off-by: YANGDB <[email protected]> * update dashboard's IDs & map component Signed-off-by: YANGDB <[email protected]> * update dashboard's IDs & map component Signed-off-by: YANGDB <[email protected]> * fix mapping mistype error Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]>
* Improve error message for invalid integration in unit tests Signed-off-by: Simeon Widdis <[email protected]> * Fix otel integration to pass validation tests Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
…earch-project#1759) * support new changes in data selector Signed-off-by: Eric <[email protected]> * add a missing dependency Signed-off-by: Eric <[email protected]> * changes addressing reviews Signed-off-by: Eric <[email protected]> * fix delete s3 data source issue Signed-off-by: Eric <[email protected]> * error handling Signed-off-by: Eric <[email protected]> * code clean up Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]>
(cherry picked from commit bbd1016) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* remove update button Signed-off-by: Paul Sebastian <[email protected]> * update snapshot Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]>
* added changes for datasourcemds- ids Signed-off-by: sumukhswamy <[email protected]> * added trace analytics support for MDS Signed-off-by: sumukhswamy <[email protected]> * added trace analytics support for MDS Signed-off-by: sumukhswamy <[email protected]> * added changes Signed-off-by: sumukhswamy <[email protected]> * addressed PR comments Signed-off-by: sumukhswamy <[email protected]> * addressed linter issues Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Sumukh Swamy <[email protected]>
…nsearch-project#1739) * cacahe updated to support MDS-client and added MDS support Signed-off-by: sumukhswamy <[email protected]> * addressed PR comments, added fix for jobs and cache Signed-off-by: sumukhswamy <[email protected]> * updated the tests, PR comments Signed-off-by: sumukhswamy <[email protected]> * addressed comments, fixed loading of flint datasources Signed-off-by: sumukhswamy <[email protected]> * added fix for cache and cahnged router Signed-off-by: sumukhswamy <[email protected]> * fixed linter Signed-off-by: sumukhswamy <[email protected]> --------- Signed-off-by: sumukhswamy <[email protected]> Signed-off-by: Sumukh Swamy <[email protected]>
…ensearch-project#1774) Signed-off-by: Ryan Liang <[email protected]>
* fix single data-point not showing in metrics analytics Signed-off-by: YANGDB <[email protected]> * fix single data-point not showing in metrics analytics Signed-off-by: YANGDB <[email protected]> --------- Signed-off-by: YANGDB <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
* adding test for clear cache on logout Signed-off-by: Shenoy Pratik <[email protected]> * update name to logout Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]>
…1799) Signed-off-by: Ryan Liang <[email protected]>
opensearch-project#1807) (cherry picked from commit 8d13272) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…oject#1732) * update live mv table name (opensearch-project#1725) Signed-off-by: YANGDB <[email protected]> Signed-off-by: [email protected] <[email protected]> * Integrated JSON5 Signed-off-by: [email protected] <[email protected]> * json_data_adaptor Signed-off-by: [email protected] <[email protected]> * Added tests for JSON5 Signed-off-by: [email protected] <[email protected]> * Updated integration configs to json5 Signed-off-by: [email protected] <[email protected]> * Revert "update live mv table name (opensearch-project#1725)" This reverts commit 71597f5. Signed-off-by: [email protected] <[email protected]> * Updated filename Signed-off-by: [email protected] <[email protected]> * Delete t --count 5c93001..fe64d02 Signed-off-by: Devesh Rahatekar <[email protected]> * Updated some integrations Signed-off-by: [email protected] <[email protected]> --------- Signed-off-by: YANGDB <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: Devesh Rahatekar <[email protected]> Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: YANGDB <[email protected]> Co-authored-by: Simeon Widdis <[email protected]>
(cherry picked from commit 441168e) Signed-off-by: Eric <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit c7ee338cd882f0787e1537bc3924901682df085f)
* Refactor away integrations adaptor class Signed-off-by: Simeon Widdis <[email protected]> * Remove adaptor use in tests Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for [BUG] Cannot create observability dashboard after creating with invalid name opensearch-project#1466 - opensearch-project#1466
Description
Cannot create Observability Dashboards after creating with an Invalid Name
Issues Resolved
Dialog asking user to input Dashboard Name even if invalid Dashboard name is entered
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.