Fix window start backtick during MV creation #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit c7ee338cd882f0787e1537bc3924901682df085f)
ps48
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
paulstn
approved these changes
May 6, 2024
mengweieric
approved these changes
May 6, 2024
joshuali925
approved these changes
May 6, 2024
| /> | ||
| </EuiFormRow> | ||
| </EuiFlexItem> | ||
| {currentColumnExpressionValue.functionName !== 'window.start' && ( |
There was a problem hiding this comment.
would there be other similar functions like window.start?
There was a problem hiding this comment.
no, this is the only unique aggregation with this special char on UI
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 6, 2024
Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit c7ee338cd882f0787e1537bc3924901682df085f) (cherry picked from commit 0632d4a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
May 6, 2024
(cherry picked from commit c7ee338cd882f0787e1537bc3924901682df085f) (cherry picked from commit 0632d4a) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit c7ee338cd882f0787e1537bc3924901682df085f) (cherry picked from commit 0632d4a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shenoy Pratik [email protected]
(cherry picked from commit c7ee338cd882f0787e1537bc3924901682df085f)
Description
Fix window start backtick during MV creation
Issues Resolved
#1819
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.