Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Cannot create observability dashboard after creating with invalid name #1466

Closed
joshuali925 opened this issue Feb 22, 2024 · 4 comments
Closed

[BUG] Cannot create observability dashboard after creating with invalid name #1466

joshuali925 opened this issue Feb 22, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@joshuali925
Copy link
Member

What is the bug?
Cannot create observability dashboard after creating with invalid name

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to https://playground.opensearch.org/app/observability-dashboards#/
  2. Click on create dashboard
  3. Click on create
  4. See error Invalid Dashboard name
  5. Click on create again, nothing happens

What is the expected behavior?
dialog asking user to input name

What is your host/environment?

  • OS: [e.g. iOS] linux
  • Version [e.g. 22] 2.12
  • Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.
@joshuali925 joshuali925 added bug Something isn't working untriaged labels Feb 22, 2024
@Mahima081
Copy link
Contributor

Mahima081 commented Mar 7, 2024 •
edited
Loading

Hi team,
Please assign this bug to me. I've identified the issue and working on it. Will be raising a PR shortly.
Thanks!

@anirudha
Copy link
Collaborator

All set! Send in PRs we can chat if you need help or be on a pairing session

@Swiddis Swiddis removed the untriaged label Mar 25, 2024
Mahima081 added a commit to Mahima081/dashboards-observability that referenced this issue Apr 19, 2024
@Mahima081
[BUG-Fixed] opensearch-project#1466 - create observability dashboard …
616b2e3 
…after creating with Invalid name

### Fix for [BUG] Cannot create observability dashboard after creating with invalid name opensearch-project#1466 - opensearch-project#1466

### Description
Cannot create Observability Dashboards after creating with an Invalid Name

### Issues Resolved
Dialog asking user to input Dashboard Name even if invalid Dashboard name is entered

### Check List
- [x] New functionality includes testing.
  - [x] All tests pass, including unit test, integration test and doctest
- [ ] New functionality has been documented.
  - [ ] New functionality has javadoc added
  - [ ] New functionality has user manual doc added
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Mahima Arora <[email protected]>
This was referenced Apr 19, 2024
Open
Merged
@Mahima081
Copy link
Contributor

@anirudha @joshuali925 I've raised a PR to fix this bug. Please review and let me know in case of any changes.

YANG-DB pushed a commit that referenced this issue Jun 28, 2024
@Mahima081
[BUG-Fixed] #1466 - create observability dashboard after creating wit…
b328720 
…h Invalid name (#1730)

### Fix for [BUG] Cannot create observability dashboard after creating with invalid name #1466 - #1466

### Description
Cannot create Observability Dashboards after creating with an Invalid Name

### Issues Resolved
Dialog asking user to input Dashboard Name even if invalid Dashboard name is entered

### Check List
- [x] New functionality includes testing.
  - [x] All tests pass, including unit test, integration test and doctest
- [ ] New functionality has been documented.
  - [ ] New functionality has javadoc added
  - [ ] New functionality has user manual doc added
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Mahima Arora <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 28, 2024
@github-actions
[BUG-Fixed] #1466 - create observability dashboard after creating wit…
5a8682c 
…h Invalid name (#1730)

### Fix for [BUG] Cannot create observability dashboard after creating with invalid name #1466 - #1466

### Description
Cannot create Observability Dashboards after creating with an Invalid Name

### Issues Resolved
Dialog asking user to input Dashboard Name even if invalid Dashboard name is entered

### Check List
- [x] New functionality includes testing.
  - [x] All tests pass, including unit test, integration test and doctest
- [ ] New functionality has been documented.
  - [ ] New functionality has javadoc added
  - [ ] New functionality has user manual doc added
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Mahima Arora <[email protected]>
(cherry picked from commit b328720)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Swiddis pushed a commit that referenced this issue Nov 6, 2024
@opensearch-trigger-bot @github-actions
@ps48 @RyanL1997
[Backport 2.x] [BUG-Fixed] #1466 - create observability dashboard aft…
c610b81 
…er invalid name (#1928)

### Fix for [BUG] Cannot create observability dashboard after creating with invalid name #1466 - #1466

### Description
Cannot create Observability Dashboards after creating with an Invalid Name

### Issues Resolved
Dialog asking user to input Dashboard Name even if invalid Dashboard name is entered

### Check List
- [x] New functionality includes testing.
  - [x] All tests pass, including unit test, integration test and doctest
- [ ] New functionality has been documented.
  - [ ] New functionality has javadoc added
  - [ ] New functionality has user manual doc added
- [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).


(cherry picked from commit b328720)

Signed-off-by: Mahima Arora <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shenoy Pratik <[email protected]>
Co-authored-by: Jialiang Liang <[email protected]>
@joshuali925
Copy link
Member Author

closing since #1730 is merged. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anirudha @joshuali925 @Swiddis @Mahima081