Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix S3_DATASOURCE_TYPE naming typo in plugin.tsx #1799

Merged
merged 1 commit into from
May 1, 2024
Merged

[BugFix] Fix S3_DATASOURCE_TYPE naming typo in plugin.tsx #1799

merged 1 commit into from
May 1, 2024

Conversation

RyanL1997
Copy link
Collaborator

Description

Fix S3_DATASOURCE_TYPE naming typo in plugin.tsx

Error Msg

Version: 2.13.0
Build: 9007199254740991
ReferenceError: S3_DATA_SOURCE_TYPE is not defined
    at ObservabilityPlugin.start (http://0.0.0.0:5601/9007199254740991/bundles/plugin/observabilityDashboards/observabilityDashboards.plugin.js:370683:46)
    at PluginWrapper.start (http://0.0.0.0:5601/9007199254740991/bundles/core/core.entry.js:28328:47)
    at PluginsService.start (http://0.0.0.0:5601/9007199254740991/bundles/core/core.entry.js:28704:25)
    at async CoreSystem.start (http://0.0.0.0:5601/9007199254740991/bundles/core/core.entry.js:22094:7)
    at async Module.__osdBootstrap__ (http://0.0.0.0:5601/9007199254740991/bundles/core/core.entry.js:27045:17)

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@RyanL1997 RyanL1997 force-pushed the s3-datasource-type-fix branch from ff64f9f to bd714c3 Compare May 1, 2024 20:58
@mengweieric mengweieric merged commit 6368b63 into opensearch-project:main May 1, 2024
12 of 19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2024
@github-actions
Fix S3_DATASOURCE_TYPE naming typo in plugin.tsx (#1799)
beb0050 
Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 6368b63)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 1, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2024
@github-actions
Fix S3_DATASOURCE_TYPE naming typo in plugin.tsx (#1799)
48aab9a 
Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 6368b63)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request May 1, 2024
Merged
joshuali925 pushed a commit that referenced this pull request May 1, 2024
@opensearch-trigger-bot @github-actions
Fix S3_DATASOURCE_TYPE naming typo in plugin.tsx (#1799) (#1803)
f67d4cc 
(cherry picked from commit 6368b63)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit that referenced this pull request May 1, 2024
@opensearch-trigger-bot @github-actions
Fix S3_DATASOURCE_TYPE naming typo in plugin.tsx (#1799) (#1804)
4b5477f 
(cherry picked from commit 6368b63)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengweieric mengweieric mengweieric approved these changes

@Swiddis Swiddis Swiddis approved these changes

@ps48 ps48 Awaiting requested review from ps48

@kavithacm kavithacm Awaiting requested review from kavithacm

@derek-ho derek-ho Awaiting requested review from derek-ho

@joshuali925 joshuali925 Awaiting requested review from joshuali925

@dai-chen dai-chen Awaiting requested review from dai-chen

@YANG-DB YANG-DB Awaiting requested review from YANG-DB

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@penghuo penghuo Awaiting requested review from penghuo

@seankao-az seankao-az Awaiting requested review from seankao-az

@anirudha anirudha Awaiting requested review from anirudha

@paulstn paulstn Awaiting requested review from paulstn

@sumukhswamy sumukhswamy Awaiting requested review from sumukhswamy

Assignees
No one assigned
Labels
backport 2.x backport 2.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanL1997 @Swiddis @mengweieric