[Bug fix] Add conditional rendering for data connection page's tabs #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1667 +/- ##
==========================================
- Coverage 57.61% 57.56% -0.05%
==========================================
Files 368 367 -1
Lines 13915 13925 +10
Branches 3650 3654 +4
==========================================
- Hits 8017 8016 -1
- Misses 5835 5845 +10
- Partials 63 64 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RyanL1997
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
RyanL1997
commented
Apr 2, 2024
public/components/datasources/components/manage/data_connection.tsx
Outdated
Show resolved
Hide resolved
Swiddis
approved these changes
Apr 25, 2024
mengweieric
approved these changes
Apr 29, 2024
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
RyanL1997
force-pushed
the
prometheus-data-connection-fix
branch
from
d52ab51 to
6ef7372
Compare
Signed-off-by: Ryan Liang <[email protected]>
YANG-DB
approved these changes
Apr 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
…1667) * Add conditional rendering for data connection page for tabs Signed-off-by: Ryan Liang <[email protected]> * Add tests for conditional rendering of data connection tabs Signed-off-by: Ryan Liang <[email protected]> * Reverse the if check for datasource for s3glue Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 914d6f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
…1667) * Add conditional rendering for data connection page for tabs Signed-off-by: Ryan Liang <[email protected]> * Add tests for conditional rendering of data connection tabs Signed-off-by: Ryan Liang <[email protected]> * Reverse the if check for datasource for s3glue Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]> (cherry picked from commit 914d6f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…pensearch-project#1667) * Add conditional rendering for data connection page for tabs Signed-off-by: Ryan Liang <[email protected]> * Add tests for conditional rendering of data connection tabs Signed-off-by: Ryan Liang <[email protected]> * Reverse the if check for datasource for s3glue Signed-off-by: Ryan Liang <[email protected]> --------- Signed-off-by: Ryan Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add conditional rendering for data connection page's tabs
Issues Resolved
Screenshot after fix
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.