Switching to Qt5 #2611

tresf · 2016-02-25T22:09:08Z

Many of our users are already compiling against Qt5, but most of them tend to be on Linux. This topic is related to switching all builds to Qt5 permanently and what's needed prior to that switch.

For starters, we need more testing.
- Our first Win64 build which utilizes Qt5 is located here:
  (removed, please download 1.2.0 from the downloads page)
- Our first Mac build which utilizes Qt5 is located here:
  (removed, please download 1.2.0 from the downloads page)
Bugs (please check these off as they're fixed)
- All: Frequent crashes related to QVector Random crashes while playing #2192 (comment).
- Mac: Spash window appears above SettingsDialog, MessageDialog (fixed via 1058ea4)
- All: Visual artifacts in MDI window decorations (preview) (superseded by Add a new window decoration to MDISubWindows #2516)
- All: Menu bar colors are hard to read (preview) (fixed via 5f48d1c)
- All: Inactive QMdiWindow titles are hard to read (preview) (superseded by Add a new window decoration to MDISubWindows #2516)
- All: Language dropdown is blank (fixed via 85011cd)
- All: White line on edge of all QWidgets (preview) (superseded by Add a new window decoration to MDISubWindows #2516)
- All: QMdiWindow windowing controls are incorrectly colored (preview) (wont-fix, see Switching to Qt5 #2611 (comment))
- All: Channel activity indicator on by default (fixed via 8768769)
- All: Drop-down menus are "crammed" (fixed via d098a39)
- All: Colors incorrect for about dialog (preview) (fixed via Fix style for Qt5 about dialog #2781)
- All: Crash when removing a channel that sends to another channel (Qt5: crash when removing a channel that sends to another channel #2667)
- Windows: Fix high-CPU usage for collapsed toolbars (CPU load on internal windows when buttons are hidden (Windows only) #2767)
- All: VSTs GUI does not load properly (VSTi plugins don't show in Subwindow on Qt5 build (probably only X11) #2855) - Still open but will not affect Windows, Mac (fixed via Add all the Qt5 Linux VST implementations #3786)
- Mac: ⌘ + drag shortcuts are broken (Command + Drag does not work (Apple) #2890) (old Xcode version only, not our bug, 1.2.0-RC5 seems to have fixed this for the 10.13+ builds)
- Remove Mac/Windows Qt4 builds from Travis-CI

Screenshot, because everyone loves screenshots...

The text was updated successfully, but these errors were encountered:

liushuyu · 2016-03-03T02:06:37Z

Windows: Language dropdown is blank (see #1498 (comment))

Not only on Windows, but also on the other platforms namely Linux and Mac can't select languages

tresf · 2016-03-03T03:35:02Z

In fact, I saw the binary translation files were generated, but not installed to the installation directory. But if you re-run make install, the files will appear in the correct directory. Strange.

@liushuyu thanks. While looking for the language block you commented on, I noticed it was moved in ee3a998. Tagging @lukas-w.

The language logic has moved quite a bit over the last year including moving from CMakeLists.txt to src/CMakeLists.txt although I feel this may have a better home in data/locale/CMakeList.txt.

It's pretty obvious that order of operations has changed after this move, breaking language generation on first run for all platforms.

lukas-w · 2016-03-03T04:38:44Z

I feel this may have a better home in data/locale/CMakeList.txt.

Absolutely. Moved in 85011cd. That should fix the generation.

tresf · 2016-03-03T05:43:25Z

Absolutely. Moved in 85011cd. That should fix the generation.

As it does. 👍 Checking it off here as I'll track the Windows/Travis stuff in #2577 since it's not Qt5 related.

tresf · 2016-03-03T06:40:00Z

Hmmm... I'm having no luck with the splash screen bug... Qt version is 5.5.1_2

[ ] Mac: Spash window appears above SettingsDialog, MessageDialog

This bug doest NOT seem to occur on Windows.

I tried the following to no avail (clicking it won't raise it).

Solution(s) I tried:

https://forum.qt.io/topic/31197/unset-qt-windowstaysontophint-flag-problem/5

Haven't tried... yuck:

http://stackoverflow.com/a/17575185/3196753

No mention of it in known issues:

http://doc.qt.io/qt-5/osx-issues.html

Test results:
⛔ didn't work... (GuiApplication.cpp)

    // Show splash screen
    QSplashScreen splashScreen( embed::getIconPixmap( "splash" ) );
+   // Prevent splash from covering settings dialog
+   splashScreen.setWindowFlags( splashScreen.windowFlags() | Qt::WindowStaysOnBottomHint );
    splashScreen.show();

⛔ didn't work... (GuiApplication.cpp)

    // Show splash screen
    QSplashScreen splashScreen( embed::getIconPixmap( "splash" ) );
    splashScreen.show();
+   splashScreen.lower();

⛔ didn't work... (SetupDialog.cpp)

    vlayout->addWidget( settings );
    vlayout->addSpacing( 10 );
    vlayout->addWidget( buttons );
    vlayout->addSpacing( 10 );
    vlayout->addStretch();

+   setWindowFlags(windowFlags() | Qt::WindowStaysOnTopHint);

    show();

+   raise();

softrabbit · 2016-03-03T17:50:25Z

Windows: Visual artifacts in MDI window decorations

I'm pretty sure I've seen those "ragged" MDI close buttons before, possibly in an LMMS/Qt5 build on Linux. Could they be a part of a style after all? And IMO they look too consistent for artifatcs.

tresf · 2016-03-03T18:07:52Z

Could ["ragged" MDI close buttons] be a part of a style after all?

Indeed they are -- tested by moving the themes directory. @Umcaruje any interest in tracking this one down?

Umcaruje · 2016-03-03T20:31:08Z

@Umcaruje any interest in tracking this one down?

My life is pretty crowded rn, I can take a look, but not sure when I'll have the time for it (I have some other issues I'm looking at).

Isn't #2516 going to fix this though? We are loading custom pixmaps for the buttons there.

tresf · 2016-03-03T20:38:07Z

Isn't #2516 going to fix this though? We are loading custom pixmaps for the buttons there.

Well, it would certainly be a moot point if #2516 were to be implemented, but I'm not placing any bets on a hypothetical, and this would give us a better understanding of things, anyhow.

Umcaruje · 2016-03-03T20:40:07Z

Well, it would certainly be a moot point if #2516 were to be implemented, but I'm not placing any bets on a hypothetical, and this would give us a better understanding of things, anyhow.

What if I started working on #2516 until its mergeable? ;) (though idk how that would be organised)

tresf · 2016-03-03T20:45:17Z

What if I started working on #2516 until its mergeable? ;) (though idk how that would be organised)

Well, actually, that may be our only option... Here's Windows with the theme disabled... (still happens)

I'll take a second look at the code, but this may be a not-our-bug-type scenario after-all...

tresf · 2016-03-03T20:57:13Z

Adding new item to list...

[ ] Windows: Channel activity indicator on by default

Per #2611

tresf · 2016-03-04T19:56:45Z

Update:

Closed:

Menu bar colors hard to read - fixed via 5f48d1c.
Mac splash screen hides SetupDialog - fixed via 1058ea4
Inactive QMdiWindow titles - superseded by Add a new window decoration to MDISubWindows #2516
Visual artifacts in MDI window decorations - superseded by Add a new window decoration to MDISubWindows #2516

Critical/Open:

Channel activity indicator on by default (screenshot in description above)

Cosmetic:

White line on edge of all QWidgets (screenshot in description above)
MDI window controls are incorrectly colored (screenshot in description above)
Drop-down menus are "crammed" (screenshots below)

@Umcaruje can you tell me if this is the intended look of the dropdowns? I ask because they seem a bit crammed -- specifically the lack of padding between the icon and the menu. I'm tagging you per #2567. If they look fine, we'll remove it from the checklist.

Mac	Windows

Umcaruje · 2016-03-04T20:32:07Z

Well, on linux, I actually have no icons in the dropdown menu, so I don't know how they looked.

I increased the padding accordingly in #2567, but I'm not sure how the icons behave. They should be moved 3 px to the left I guess, though Qt should render them centered, and not aligned to left.

If it can't be fixed in code, we can revert the margins back.

Umcaruje · 2016-03-04T21:15:35Z

Fixed it via d098a39

mikobuntu · 2016-03-04T21:17:02Z

@Umcaruje Refering to your comment about no drop-down icons, this is a known issue... iirc I was talking to tobydox several years ago about this and if my memory server me right it was an issue with the actual DR.
I wonder if there is a method to override this behaviour? Thanks

Umcaruje · 2016-03-04T21:18:50Z

@mikobuntu well, the problem is gone for me when I compiled using qt5, so I guess when we switch to it, it won't matter.

But no, I couldn't fix the issue, it seems to be a qt4 bug.

Umcaruje · 2016-03-04T22:25:46Z

@tresf I rebased #2516 and the White line on edge of all QWidgets is also gonna be superseded by it:

tresf · 2016-03-04T23:22:35Z

Fixed [menu icons] it via d098a39

👍

White line on edge of all QWidgets [...] superseded by #2516

👍 👍

Do you guys get the LED indicator bug too on Linux? I don't have a ready Qt5 Linux environment to test on.

softrabbit · 2016-03-06T18:59:27Z

Do you guys get the LED indicator bug too on Linux? I don't have a ready Qt5 Linux environment to test on.

Yes, it's present.
LMMS 1.1.90-g2e2abdf
(Linux x86_64, Qt 5.4.2, GCC 5.2.1 20151010)

tresf · 2016-03-06T19:14:07Z

@softrabbit thanks for confirming.

Is there a chance this is just a bad initiation? Don't know the CSS side of things that well, but seems like this may be intended to be Inactive rather than Active. Pinging @Umcaruje https://github.com/LMMS/lmms/blob/master/src/tracks/InstrumentTrack.cpp#L916:L920

tresf · 2016-03-06T19:16:21Z

Meh... nevermind that statement... that's more in regards to the QWidget being active or inactive from a user-interaction perspective. I'm pretty sure Active is what we want, so this must be something else.

tresf · 2016-03-06T19:23:06Z

Ok, on second look, this is most likely due to the way Qt5 is handling the timer...

https://github.com/LMMS/lmms/blob/master/src/gui/widgets/FadeButton.cpp#L86:L100

When the FadeButton is initially created, this statement is most likely coming back as true. m_stateTimer is QTime. According to the Qt5 docs, we should be using m_stateTimer.isNull() as a check before doing a time comparison. Qt4.8 states this function exists there as well, so this shouldn't break backwards compat. 👍

lukas-w · 2016-03-06T20:58:47Z

we should be using m_stateTimer.isNull() as a check before doing a time comparison

Indeed, that fixes it. Fixed via 8768769.

liushuyu · 2016-05-15T09:58:29Z

👍

tresf · 2016-05-15T14:28:03Z

Although the checklist would suggest that, I feel we should make our build environment do this by default to consider this task closed.

Umcaruje · 2016-05-15T14:52:53Z

I feel we should make our build environment do this by default to consider this task closed.

Hmm, you're right. Forgot about that one.

tresf · 2016-05-16T01:20:33Z

Added new item to the checklist:

Windows: Fix high-CPU usage for collapsed toolbars (CPU load on internal windows when buttons are hidden (Windows only) #2767)

Goes without saying but this bug is a deal breaker on Windows if not resolved. It will spike a 100% usage on a CPU core if running Qt5. Discussion specific to the bug should remain in #2767.

Per LMMS#2611

tresf · 2016-07-06T20:23:52Z

Added new items to the checklist:

All: VSTs GUI does not load properly (VSTi plugins don't show in Subwindow on Qt5 build (probably only X11) #2855)

Yet another deal breaker for Qt5. Help/workarounds, etc are appreciated. 👍

tresf · 2016-08-31T14:35:35Z

Since Windows VSTs seem to be in usable shape and Mac does not yet support VSTs, I feel we are ready to switch to Qt5 for Mac and Windows for our next release.

I'm marking off the VST bug and adding a new task, "Remove Mac/Windows Qt4 builds from Travis-CI".

simonvanderveldt · 2016-09-20T20:29:41Z

Will building with Qt4 as an option be removed?
(I'm on Linux in case it's relevant)

tresf · 2016-09-20T21:13:57Z

Will building with Qt4 as an option be removed?

No, not right away as VST GUIs are still horribly broken with Qt5 on Linux. #2855.

We do have plans to shift Windows and Mac builds to Qt5 since they have Qt5 bundled --there is no downside. Note, we may eventually offer Qt5 bundles for Linux as well per #2932, assuming VSTs are sorted.

simonvanderveldt · 2016-09-20T22:00:34Z

👍

tresf · 2016-10-08T15:42:21Z

New issue... #2890 Qt5 prevents Mac ⌘+Drag copy as well as Mac ⌘+Drag to Automation editor.

Although Copy/Paste has a right-click alternative, no such shortcut exists for linking to an automation pattern.

This may be unrelated to Qt5 (could be a code change) but my instinct is that it's directly Qt5 related.

Edit: It seems to be related to the XCode SDK used for building. For now, ALT + Option works just fine.

musikBear · 2017-12-04T18:29:50Z

That "Drive not ready" thing?

-that appears when lmms is loaded. I suspect that it is an error caused by the absence of a disk in Drive-B, or iow. This popup will occur, if the user do not have a SSD in drive-B, and the compiling is made on a system with a drive-B.
Could that be correct?

tresf · 2017-12-04T18:31:01Z

Could that be correct?

Nope.

tresf · 2017-12-23T07:24:06Z

Closed via #4041. The last remaining item was switching Travis to Qt5 and that is completed.

Per LMMS#2611

tresf added the enhancement label Feb 25, 2016

tresf mentioned this issue Mar 3, 2016

Generate translation files automatically #1498

Merged

tresf mentioned this issue Mar 3, 2016

Language dropdown is blank #2577

Closed

tresf added a commit that referenced this issue Mar 4, 2016

Fix menu bar colors for Qt5

5f48d1c

Per #2611

tresf added a commit that referenced this issue Mar 4, 2016

Hide splash screen before showing settings screen

1058ea4

Per #2611

Umcaruje added the meta label Mar 4, 2016

Umcaruje reopened this May 15, 2016

Teuthis pushed a commit to Teuthis/lmms that referenced this issue May 18, 2016

Fix style for Qt5 about dialog

4683c27

Per LMMS#2611

tresf mentioned this issue Jun 22, 2016

LMMS won't launch on OS X #2862

Closed

tresf mentioned this issue Sep 15, 2016

Command + Drag does not work (Apple) #2890

Open

zonkmachine mentioned this issue Nov 9, 2016

Changed the arpeggio functions: InstrumentFunction.h and ccp #3110

Closed

tresf mentioned this issue Jan 2, 2017

Travis Qt5 + Mac Failing #3200

Closed

tresf mentioned this issue Jan 16, 2017

Window Fullscreen and Close "X" Icons Have Issues When Fullscreen Is Activated #3263

Closed

tresf mentioned this issue Jan 24, 2017

MIDI Import feature ported to drumstick and new MIDI Export feature #3224

Closed

tresf mentioned this issue Feb 3, 2017

Missing icons for full/ windowed mode #3318

Closed

lukas-w mentioned this issue May 5, 2017

Feature: Detach window #3532

Open

tresf mentioned this issue Jul 25, 2017

Better support for visually impaired #1935

Open

tresf mentioned this issue Dec 23, 2017

Add support for PR uploads #4041

Merged

tresf closed this as completed Dec 23, 2017

tresf mentioned this issue Mar 5, 2018

When a daughter window (e.g. Piano Roll, Pitch-bend window) is maximized, it cannot be normalized #4215

Closed

tresf mentioned this issue Aug 24, 2018

Next LMMS Release and Roadmap #4197

Closed

tresf mentioned this issue Mar 5, 2019

Change stability concept. #4876

Closed

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022

Fix style for Qt5 about dialog

9f0227c

Per LMMS#2611

Switching to Qt5 #2611

Switching to Qt5 #2611

Comments

tresf commented Feb 25, 2016 • edited Loading

liushuyu commented Mar 3, 2016

tresf commented Mar 3, 2016

lukas-w commented Mar 3, 2016

tresf commented Mar 3, 2016

tresf commented Mar 3, 2016

softrabbit commented Mar 3, 2016

tresf commented Mar 3, 2016

Umcaruje commented Mar 3, 2016

tresf commented Mar 3, 2016

Umcaruje commented Mar 3, 2016

tresf commented Mar 3, 2016

tresf commented Mar 3, 2016

tresf commented Mar 4, 2016

Umcaruje commented Mar 4, 2016

Umcaruje commented Mar 4, 2016

mikobuntu commented Mar 4, 2016

Umcaruje commented Mar 4, 2016

Umcaruje commented Mar 4, 2016

tresf commented Mar 4, 2016

softrabbit commented Mar 6, 2016

tresf commented Mar 6, 2016

tresf commented Mar 6, 2016

tresf commented Mar 6, 2016

lukas-w commented Mar 6, 2016

liushuyu commented May 15, 2016 via email

tresf commented May 15, 2016

Umcaruje commented May 15, 2016

tresf commented May 16, 2016 • edited by lukas-w Loading

tresf commented Jul 6, 2016 • edited Loading

tresf commented Aug 31, 2016 • edited Loading

simonvanderveldt commented Sep 20, 2016 • edited Loading

tresf commented Sep 20, 2016

simonvanderveldt commented Sep 20, 2016

tresf commented Oct 8, 2016 • edited Loading

musikBear commented Dec 4, 2017

tresf commented Dec 4, 2017

tresf commented Dec 23, 2017

tresf commented Feb 25, 2016 •

edited

Loading

tresf commented May 16, 2016 •

edited by lukas-w

Loading

tresf commented Jul 6, 2016 •

edited

Loading

tresf commented Aug 31, 2016 •

edited

Loading

simonvanderveldt commented Sep 20, 2016 •

edited

Loading

tresf commented Oct 8, 2016 •

edited

Loading