Changed the arpeggio functions: InstrumentFunction.h and ccp #3110
Conversation
| @@ -67,7 +67,7 @@ OPTION(WANT_TAP "Include Tom's Audio Processing LADSPA plugins" ON) | |||
| OPTION(WANT_VST "Include VST support" ON) | |||
| OPTION(WANT_VST_NOWINE "Include partial VST support (without wine)" OFF) | |||
| OPTION(WANT_WINMM "Include WinMM MIDI support" OFF) | |||
| OPTION(WANT_QT5 "Build with Qt5" OFF) | |||
| OPTION(WANT_QT5 "Build with Qt5" ON) | |||
|
|
|||
There was a problem hiding this comment.
If you want Qt5 you add -DWANT_QT5=ON to your cmakestatement. Switching to Qt5 as default is a separate issue, #2611 .
https://github.com/LMMS/lmms/wiki/Compiling-lmms
|
Thanx! I really need as much input as possible!!! 2016-11-09 20:34 GMT+01:00 Oskar Wallgren [email protected]:
|
| SET(STATUS_SNDIO "<not found or not supported on this platform>") | ||
| SET(STATUS_SNDIO "OK") | ||
| ELSE() | ||
| SET(STATUS_SNDIO "<not found or not supported on this platform>") |
There was a problem hiding this comment.
Too many tabs here (line 404-406). If you press view in the top of this file you can see how it looks with the GitHub formatting. I think you might have the tabs in your editor set to a low value.
| ENDIF() | ||
|
|
||
| # Due to a regression in gcc-4.8.X, we need to disable array-bounds check | ||
| IF (CMAKE_COMPILER_IS_GNUCXX AND ((CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL "4.8.0") OR (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "4.8.0") OR LMMS_BUILD_WIN32)) | ||
| SET(WERROR_FLAGS "${WERROR_FLAGS} -Wno-array-bounds") | ||
| SET(WERROR_FLAGS "${WERROR_FLAGS} -Wno-array-bounds") |
There was a problem hiding this comment.
Line 436 and 441 has a space left after the tabs.
|
Thanks for the input, I am fixing things and formatting the code according to standard (was using a beautifier). My pull request was probably premature, it compiled on my linux machine but I didn't check it deep (I see now I still have a long way to go...). I think the idea is good tough, and when the things get right I'll try to pull another request! |
As I am an enthusiast user of the arpeggio function wanted to add some functionality, like single note volume and pan.
Changed the ChordTable structure into a QVector, the int8 key to a new structure etc.
The chords are still hardcoded but the final objective is to build up a dedicated sequence editor and put data into a file