MIDI Import feature ported to drumstick and new MIDI Export feature #3224

senseab · 2017-01-09T09:51:17Z

Now I have changed origin portsmf of MIDI Import to drumstick
And with some new features.

Fix issue MIDI import: Pitch bend range CCs ignored and wrong default #1967
Adding Overture (.ove) and Cakewalk (.wrk) project file support. with drumstick
New MidiExport plugin

Origin MidiImport plugin changed to SmfImport

softrabbit · 2017-01-09T10:33:11Z

plugins/SmfImport/CMakeLists.txt

+# check for drumstick-file
+PKG_CHECK_MODULES(DRUMSTICK_FILE REQUIRED drumstick-file>=1.1.0)
+IF(NOT DRUMSTICK_FILE_FOUND)
+        MESSAGE(FATAL_ERROR "LMMS requires libdrumstick-file and drumstick-dev >= 1.0.11 - please install, remove CMakeCache.txt and try again!")


Looks like the as of now unreleased Ubuntu 17.04 will have libdrumstick 1.0.2. Is there something in 1.0.11 that is absolutely required? (https://launchpad.net/ubuntu/+source/libdrumstick)

well，i was using Archlinux，drumstick may newer. i will fix it later

Okay, it's typo

Umcaruje · 2017-01-09T13:40:02Z

@tonychee7000 locale updates are done over transifex now, this should not be in the commit for other languages, just English. CC @liushuyu

senseab · 2017-01-09T15:10:13Z

Sorry, i would fix it

Umcaruje · 2017-01-09T15:12:43Z

Also you'll need to add drumstick to packages needed for travis, and mingw packages will need to be made. What are the advantages of drumstick over our current implementation?

senseab · 2017-01-09T15:38:54Z

Reply @Umcaruje

I have not understood travis yet, and I don't know how to make mingw packages. So it will be better if there were someone help.
As you see, drumstick can read Overture and Cakewalk project. Then we can support more file types.
Drumstick is Qt-based library for MIDI, using Signal/Slot mechanism.
It would be easy to procceed with RPN Event like pitch bend range was changed. See MIDI import: Pitch bend range CCs ignored and wrong default #1967 and Add pitch range CC handling #3206

If any doubts, ask @liushuyu

zonkmachine · 2017-01-09T18:10:22Z

MMS requires libdrumstick-file and drumstick-dev >= 1.0.2

Debian Jessie use drumstick 0.5.0

Changes for v1.0.2
...
Compilation minimum requirements for all platforms: CMake 3.0 and Qt 5.1

We still use Qt 4 on Linux

senseab · 2017-01-09T22:31:11Z

is there any libdrumstick newer version at Debian ？if not, i will test it

zonkmachine · 2017-01-09T23:08:29Z

is there any libdrumstick newer version at Debian ？

In experimental only. 1.0.2 https://packages.debian.org/search?suite=experimental&arch=any&searchon=names&keywords=drumstick
I don't know if Debian folks have a problem using packages from experimental.

QT 4 is about to get dropped anyway so that is probably not a big thing. Also I don't know if the libstick version in Debian is a problem. I only use Ubuntu based systems so I'm used to using ppa's. It's a thing with Debian to not update their stable releases so I guess they are cool with running an older lmms too.

senseab · 2017-01-09T23:19:05Z

Got that, I would say that Qt 5 might be more effective.
But I still wonder the lowest version for my codes, to get the most widely compatibility

zonkmachine · 2017-01-09T23:33:07Z

But I still wonder the lowest version for my codes, to get the most widely compatibility

Then it looks like maybe 0.5.0 is the best candidate.

senseab · 2017-01-10T00:15:21Z

i will test it

liushuyu · 2017-01-10T04:17:30Z

I would like to say:

This PR should be squashed into one commit, for the early commit messages were non-sense.
Need more testing, for the changes affected many aspects
Test drumstick package under Windows. Seems like drumstick is intended for Linux only, so we may need some workarounds to port or compile it for Windows (via MSYS or Cygwin, or just dig out drumstick-file components), Darwin, BSDs, Haiku, etc.
For the sake of new comers, @tonychee7000 had expressed the hardness of finding "clues" of each and every APIs in LMMS, let's just try to leave more comments in our code. Not only for developers. A bunch of translators asked me about the context of messages in LMMS, I feel like we need to do something about this.

senseab · 2017-01-10T07:22:46Z

Tested on Debian with drumstick 0.5.0, works well.

senseab · 2017-01-10T07:44:36Z

@liushuyu It seems that I overwrite your commit for mistake. so could you repair it again?

* Added Cakewalk file format import support * Added Overture file format import support * Enhanced MIDI CC Message handling * Merge liushuyu's commit.

make the volume louder

senseab · 2017-01-26T07:46:23Z

Just a suggestion, you can create a new branch if necessary.

ghost · 2017-04-09T14:46:21Z

Object::connect: No such signal ����::signalSMFTimeSig( int, int, int, int )
Object::connect: No such signal ����::signalSMFTempo( int )
Object::connect: No such signal ����::signalSMFText( int, QString )
Object::connect: No such signal ����::signalSMFError( QString )
Object::connect: No such signal ����::signalSMFCtlChange( int, int, int )
Object::connect: No such signal ����::signalSMFPitchBend( int, int )
Object::connect: No such signal ����::signalSMFNoteOn( int, int, int )
Object::connect: No such signal ����::signalSMFNoteOff( int, int, int )
Object::connect: No such signal ����::signalSMFProgram( int, int )
Object::connect: No such signal ����::signalSMFHeader( int, int, int )
Object::connect: No such signal ����::signalSMFTrackStart()

Just tried building the PR, and it looks like it segfaults when trying to import any MIDI file.

tresf · 2017-04-10T16:54:50Z

cmake/apple/build_osx_drumstick.sh

+fi
+
+cmake ../ -DUSE_WERROR=OFF -DLIB_SUFFIX='' -DSTATIC_DRUMSTICK=$STATIC_OPTS
+make && sudo make install


This file is near identical to Linux. They should be consolidated. It can live in linux until this library is ported to homebrew.

tresf · 2017-04-10T16:58:18Z

cmake/nsis/build_mingw_drumstick.sh

@@ -0,0 +1,54 @@
+drumstick_ver=$1


This can stay as-is, but this should probably be ported to https://github.com/LMMS/lmms/blob/master/cmake/msys/msys_helper.sh like @dragoneagle did in #3369 or alternately added directly to the mingw mirros that Toby maintains for us. Toby generally does this on-request.

I think first though we can pull Qt4 support, which is an open task, so we wouldn't hold up the merge for this script alone.

tresf · 2017-04-10T17:09:33Z

it segfaults when trying to import any MIDI file.

Seems to be similar to this issue... http://stackoverflow.com/a/14774274/3196753

@tonychee7000 may need to add the class name in front of the slots ::signalSMFTimeSig, etc.

I assume you're on the right build of drumstick? Qt5 builds against drumstick 1.1.x. Qt4 builds against drumstick 0.5.x.

senseab · 2017-04-11T05:21:32Z

@tonychee7000 may need to add the class name in front of the slots ::signalSMFTimeSig, etc.

I have added that class name above ::signal***, but it won't work with output

QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFTimeSig( int, int, int, int ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:49
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFTempo( int ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:52
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFText( int, QString ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:55
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFError( QString ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:58
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFCtlChange( int, int, int ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:61
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFPitchBend( int, int ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:64
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFNoteOn( int, int, int ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:67
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFNoteOff( int, int, int ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:70
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFProgram( int, int ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:73
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFHeader( int, int, int ) in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:76
QObject::connect: No such signal drumstick::QSmf::drumstick::QSmf::signalSMFTrackStart() in /home/tonychyi/工程/lmms/plugins/SmfImport/midiReader.cpp:79

Here are duplicate drumstick::QSmf

Here is Archlinux

ghost · 2017-04-11T09:28:41Z

I assume you're on the right build of drumstick? Qt5 builds against drumstick 1.1.x. Qt4 builds against drumstick 0.5.x.

Yep, building with Qt5 seems to have solved the issue.

On another note, perhaps the instrument used when exporting a MIDI could be determined with a dropdown on the instrument window, instead of forcing all instruments to be a sf2 player.

PhysSong · 2019-04-24T04:38:02Z

Now there are a bunch of merge conflicts. If this work still has some values, someone may redo this work.
@tonychee7000 Do you have any ideas/opinions what should we do?

senseab · 2019-05-07T08:41:10Z

Reply @PhysSong

Oops, several years.

Well, someone can redo this feature referring to my code or just check where conflict is and merge them by manual. Might a lot work to do.

In my code, MidiImport was replaced by SmfImport for drumstick supports Overture(.ove) and old Cakewalk(.wrk) project file. I just want a accurate name.

MidiExport was totally ported to drumstick. Abandon the current code might do.

A new branch might needed?

PhysSong · 2019-05-07T09:02:15Z

Well, there have been several changes:

MidiExport changed a lot in Fix MIDI export #3733, mainly due to MIDI export doesn't handle B&B tracks correctly #2384
master now requires Qt5, not Qt4
We have experimental MSVC support

There are some more changes. Anyway, it may be very difficult to resolve merge conflicts...

senseab · 2019-05-08T08:23:41Z

@PhysSong

MidiExport I haven't considered about B&B tracks or more, just export tracks which use sf2player. It might be redo.
I tested Qt5 and all codes was based by Qt5, just forget Qt4.
I have no idea about MSVC, even it worked on Travis at that time.

I will show what I have done on MidiExport, all based on drumstick.

Call setFileFormat() and set MIDI file version to 1
Call setDivision(960)
Scan all tracks which use sf2player and call setTracks() + 1 on drumstick
AutomationTrack was bonded to MIDI channel.
Write drum track with MIDI channel 10.
Write global event which had track 0
List all notes and automations by order
Calculate the time difference between 2 events.
Write to some channel
Write EndOfTrack event finally

Considering MidiExport on master has changed a lot, Redo might be an option.

PhysSong · 2020-11-29T06:20:23Z

Considering MidiExport on master has changed a lot, Redo might be an option.

Some remarks in case someone wants to redo works in this PR:

The license of drumstick has been changed to GPL3+ in r464.
Overture support is removed in r437.

Note that those changes are in their trunk, but not in their latest release(r391).

PhysSong · 2022-11-12T11:43:56Z

Updates:

The latest Drumstick release is 2.7.2(as of 2022.11.12), which defaults to Qt 6(Qt 5 option is also available, but some distributions build it with Qt 6)
As of Drumstick 2.0, it's licensed under GPL3+ while LMMS is still under GPL2+

zonkmachine · 2024-05-07T16:54:09Z

As of Drumstick 2.0, it's licensed under GPL3+ while LMMS is still under GPL2+

What does this mean practically?

tresf · 2024-05-07T17:17:41Z

What does this mean practically?

It just means we need to bump LMMS to GPL3+ in order to bundle it. Any dependencies that don't have the "+" in "GPL2+" would no longer be able to be bundled. I think we went over this very specifically in another thread, but my seaching was not fruitful. https://github.com/LMMS/lmms/issues?q=is%3Aissue+gpl3

zonkmachine · 2024-05-07T17:29:30Z

It just means we need to bump LMMS to GPL3+ in order to bundle it. Any dependencies that don't have the "+" in "GPL2+" would no longer be able to be bundled. I think we went over this very specifically in another thread, but my seaching was not fruitful. https://github.com/LMMS/lmms/issues?q=is%3Aissue+gpl3

OK. So, if I understand this correctly, big if..., we wouldn't be able to ship it with the AppImage but for the rest we could link it to a package.

tresf · 2024-05-07T18:18:15Z

It just means we need to bump LMMS to GPL3+ in order to bundle it. Any dependencies that don't have the "+" in "GPL2+" would no longer be able to be bundled. I think we went over this very specifically in another thread, but my seaching was not fruitful. https://github.com/LMMS/lmms/issues?q=is%3Aissue+gpl3

OK. So, if I understand this correctly, big if..., we wouldn't be able to ship it with the AppImage but for the rest we could link it to a package.

When you say "wouldn't be able to ship", I'm not sure if you mean the GPL2 (without +) or GPL3 (before we upgrade), but I'll try to make it as simple as possible, based on my understanding of the license.

GPL2+ can upgrade to GPL3+ at any time. without a license change. You can just call the completed work GPL3+, however many will consider this misleading.
GPL3+ cannot downgrade to GPL2+.
GPL2 (without the +) cannot upgrade to GPL3+.
Regardless of this, our plugin system can fall into the "Standard Interface" clause of either GPL license.
- This means that technically, as long as our plugin-specific code is compatible, we're OK.
- This may cause confusion or be considered misleading if certain directories of the project were a different license, but this is technically allowed using an interface or plugin system.
- At time of writing this, I do not believe we use a standard interface for the MIDI import, so this library specifically would require either a refactor to leverage the "Standard Interface" clause, or an upgrade to the project as a whole to comply with GPL3+.
Switching the project to GPL3+ is already actively being discussed for VST3 support, so this is probably the simplest and least confusing path. We just need to make sure we check each plugin and dependency for compatibility, and if exceptions exist, try to leverage the "Standard Interface" clause, or ask the author to relicense. Anything not using a plugin system (e.g. uses headers and linking and would crash LMMS if missing) is a hard-requirement to be GPL3/GPL3+ compatible or needs a significant refactor to be used as a standardized plugin.

With regards to the word "shipping"... the bundle of GPL3+ and non-GPL3+ components is referred to as "aggregate" in the license and seems to be allowed, although I've seen projects such as FoxIt leverage install-time downloaders (e.g. GhostScript) to avoid any potential legal issues.

zonkmachine · 2024-05-09T09:53:14Z

With regards to the word "shipping".

I think I meant "bundle".

Thanks for the clarification. I'm removing this from the current milestone.

Rossmaxx · 2024-05-29T08:42:25Z

@Veratil didn't you rewrite midi import (and also plan to fix midi export) so is there anything you need here?

Rossmaxx · 2024-05-29T08:46:38Z

I see way too much for this PR to be fixed up. If @senseab wants to continue (I assume otherwise because they seem to have forgotten), better to start from scratch. Will close in 2 days if no one complains

Rossmaxx · 2024-05-29T08:47:19Z

Well, someone can redo this feature referring to my code or just check where conflict is and merge them by manual. Might a lot work to do.
In my code, MidiImport was replaced by SmfImport for drumstick supports Overture(.ove) and old Cakewalk(.wrk) project file. I just want a accurate name.
MidiExport was totally ported to drumstick. Abandon the current code might do.
A new branch might needed?

I see this as an indication for closing.

Veratil · 2024-05-29T14:39:53Z

@Veratil didn't you rewrite midi import (and also plan to fix midi export) so is there anything you need here?

Yes, MIDI import is pretty much done locally (but I don't like the code in the current state it is). Export is not done yet.

softrabbit reviewed Jan 9, 2017

View reviewed changes

senseab force-pushed the port_to_drumstick branch from 2bb116c to b162af0 Compare January 9, 2017 15:13

liushuyu force-pushed the port_to_drumstick branch 2 times, most recently from d67da79 to bfaaa46 Compare January 10, 2017 04:56

senseab force-pushed the port_to_drumstick branch from bfaaa46 to f9d4de9 Compare January 10, 2017 07:05

liushuyu force-pushed the port_to_drumstick branch from f9d4de9 to 1e39d12 Compare January 10, 2017 18:41

senseab added 2 commits January 11, 2017 07:53

Move onto drumstick and ditch portsmf

0a2541a

* Added Cakewalk file format import support * Added Overture file format import support * Enhanced MIDI CC Message handling * Merge liushuyu's commit.

Merge liushuyu's commit

19981ec

senseab force-pushed the port_to_drumstick branch from 5c88228 to 19981ec Compare January 11, 2017 00:11

liushuyu force-pushed the port_to_drumstick branch from 19981ec to a9d5653 Compare January 11, 2017 00:22

senseab force-pushed the port_to_drumstick branch from a9d5653 to 19981ec Compare January 11, 2017 00:53

liushuyu and others added 2 commits January 10, 2017 21:05

Merge more commits

4e93d88

Fix CMakeList.txt, for cannot find "DRUMSTICK_LIBRARIES"

61cec1f

senseab force-pushed the port_to_drumstick branch from 3fa2913 to 61cec1f Compare January 14, 2017 11:02

senseab added 3 commits January 17, 2017 19:32

Fix volume when import

1cd854d

make the volume louder

Fix a bug when only note_off events existed

8edb130

Fix import bugs.

ac49669

zonkmachine mentioned this pull request Jan 26, 2017

Import midi file from command line hangs #2562

Closed

tresf mentioned this pull request Jan 26, 2017

[suggestion / feature request] sf3 player #3286

Closed

tresf reviewed Apr 10, 2017

View reviewed changes

Umcaruje added this to the 1.3.0 milestone May 14, 2017

ryuukumar mentioned this pull request Jul 21, 2020

Reorganising LMMS, renaming editors and classes and everything in between (cont. #120) #5592

Closed

56 tasks

PhysSong added the rework required Pull requests which must be reworked to make it able to merge or review label Jan 4, 2021

zonkmachine modified the milestones: 1.3, 1.3+ May 9, 2024

Rossmaxx closed this May 29, 2024

MIDI Import feature ported to drumstick and new MIDI Export feature #3224

MIDI Import feature ported to drumstick and new MIDI Export feature #3224

Conversation

senseab commented Jan 9, 2017 • edited Loading

softrabbit Jan 9, 2017

Choose a reason for hiding this comment

senseab Jan 9, 2017

Choose a reason for hiding this comment

senseab Jan 9, 2017

Choose a reason for hiding this comment

Umcaruje commented Jan 9, 2017

senseab commented Jan 9, 2017

Umcaruje commented Jan 9, 2017

senseab commented Jan 9, 2017 • edited Loading

zonkmachine commented Jan 9, 2017

senseab commented Jan 9, 2017

zonkmachine commented Jan 9, 2017

senseab commented Jan 9, 2017

zonkmachine commented Jan 9, 2017

senseab commented Jan 10, 2017

liushuyu commented Jan 10, 2017 • edited Loading

senseab commented Jan 10, 2017

senseab commented Jan 10, 2017

senseab commented Jan 26, 2017

ghost commented Apr 9, 2017

tresf Apr 10, 2017

Choose a reason for hiding this comment

tresf Apr 10, 2017

Choose a reason for hiding this comment

tresf commented Apr 10, 2017 • edited Loading

senseab commented Apr 11, 2017 • edited Loading

ghost commented Apr 11, 2017

PhysSong commented Apr 24, 2019

senseab commented May 7, 2019

PhysSong commented May 7, 2019

senseab commented May 8, 2019

PhysSong commented Nov 29, 2020

PhysSong commented Nov 12, 2022

zonkmachine commented May 7, 2024

tresf commented May 7, 2024 • edited Loading

zonkmachine commented May 7, 2024

tresf commented May 7, 2024 • edited Loading

zonkmachine commented May 9, 2024

Rossmaxx commented May 29, 2024

Rossmaxx commented May 29, 2024

Rossmaxx commented May 29, 2024

Veratil commented May 29, 2024

senseab commented Jan 9, 2017 •

edited

Loading

senseab commented Jan 9, 2017 •

edited

Loading

liushuyu commented Jan 10, 2017 •

edited

Loading

tresf commented Apr 10, 2017 •

edited

Loading

senseab commented Apr 11, 2017 •

edited

Loading

tresf commented May 7, 2024 •

edited

Loading

tresf commented May 7, 2024 •

edited

Loading