-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PR uploads #4041
Conversation
8c3e216
to
06b2516
Compare
.travis/script.sh
Outdated
echo "Uploading $PACKAGE to file.io..." | ||
response=$(curl -F "file=@$PACKAGE" "https://file.io") | ||
# We need stdout, disable SC2181 | ||
# shellcheck disable=SC2181 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zapashcanon FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if there's another way to do it. Can't figure it out now, but will think about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking something like if [ foo=$(/usr/bin/true) ];
perhaps. Haven't tested it and it's a tad bit uglier.
i.e.
if [ response=$(curl -F "file=@$PACKAGE" "https://file.io") ]; then
# ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha, I tried it already, doesn't work. :p (Plus, there's some new warnings from SC because it thinks we want to compare response etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, actually, it seems to work, but, here's what I got from shellcheck:
β ~ cat tmp
#!/bin/bash
if [ response=$(curl -F "file=@$PACKAGE" "https://file.io") ]; then
echo cc
fi
λ ~ ./tmp
Warning: setting file failed!
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 145 0 0 0 145 0 145 --:--:-- --:--:-- --:--:-- 508
curl: (26) read function returned funny value
cc
λ ~ shellcheck tmp
In tmp line 3:
if [ response=$(curl -F "file=@$PACKAGE" "https://file.io") ]; then
^-- SC2077: You need spaces around the comparison operator.
^-- SC2046: Quote this to prevent word splitting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Yes, that's worse. We'll keep it as-is for now, I guess. https://stackoverflow.com/a/6934931/3196753
5330d99
to
030cbd6
Compare
In respond to failing LADSPA build... @lukas-w disabled C++11 for LADSPA in #4000 and it seems to cause build issues with clang. And |
Yes that change was unintentional. Doesn't make sense changing the behaviour in #4000 as it doesn't build with MSVC either way. Sorry about that. |
df8027e
to
6645e45
Compare
Commits squashed. Note, as part of the Qt5-by-default changes, I've added a new cmake module The build issues on Apple were due to a bug in |
89d2a45
to
a1d367d
Compare
a3d068d
to
4dcadee
Compare
054e202
to
379a1b7
Compare
|
Removes Qt4 from build system Uploads PRs to transfer.sh
Removes Qt4 from build system Uploads PRs to transfer.sh
Adds support for leveraging upload artifacts for PRs. Targeted at the
master
branch only.Justification and planning available in #4035; closes #4035.
Also removes Qt5 from the build system, closing #2611.