-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate translation files automatically #1498
Conversation
Instead of updating the binary translation files manually, update them automatically. Now we only need to sync the *.ts files.
Sounds like a reasonable thing to do. |
Generate translation files automatically
After some evaluation of our build logic, I believe this commit is causing a downstream effect on the Windows builds. @tobydox would occasionally sync these, and I have a feeling this is because Now I'm wondering if it's related to #2577 since my build machine may have had these laying around from a Linux build, whereas Travis certainly wouldn't have. The prob I've identified is here: This was exposed while I'm working on the Qt5 packaging (#2608) and I'm seeing the same problem. This is my proposed change for Qt5 #2608 (diff) but now I'm having second thoughts. So... do we ask @tobydox to package these language tools into Qt4/Qt5 mingw or do we go back to periodically uploading these |
Can't we just add |
Well, that's assuming Toby's build uses win binaries, but it actually uses ELF binaries.
Yes, so as long as we have a way to locate it (or tell PkgConfig to). The |
That's true. So we'll just have to change the CMake scripts to use the system's |
In fact, I saw the binary translation files were generated, but not installed to the installation directory. But if you re-run |
Instead of updating the binary translation files manually, update them automatically when building.
Now we only need to sync the *.ts files.
As a translator you can get confused with .qm and .ts files. #597
This removes the need of updating the .ts file together with the .qm file. It will also help keeping the repository smaller.