[Interactive Graph Editor] Add/Edit/Delete Locked Function #1493

mark-fitzgerald · 2024-08-06T21:57:44Z

Summary:

Content editors need a way to add and edit a locked function. This PR adds a settings section that is specific to functions.

Issue: LEMS-1947

Test plan:

Launch Storybook (yarn start)
Navigate to Perseus Editor => Widgets => Interactive Graph Editor => With Locked Lines
Click on the "Add locked figure" drop-down at the bottom of the editor and choose "Function"
- A function with default settings should be added to the example graph
- A settings section should be added to the bottom of the list of items on the graph
- The settings should be open, and should show the color, stroke, function equation, and domain settings
Changing any of the settings should immediately update the function in the example graph

Affected UI

New settings options

…r and line style options). Move common code for selecting line style to its own component (just like with the color selector).

… good way to load the parsed equation to save time, we still need to call 'parse()'. Adjust 'LockedFunction' jsx to only parse the equation when it is changed. Add equation field to graph settings.

… accordingly. Add directional axis and domain limits to settings panel.

…s a label for the equation. Update the logic that handles the entry of domain limits.

Update unit tests accordingly.

github-actions · 2024-08-06T22:00:32Z

Size Change: +1.52 kB (+0.18%)

Total Size: 855 kB

Filename	Size	Change
`packages/perseus-editor/dist/es/index.js`	275 kB	+1.4 kB (+0.51%)
`packages/perseus/dist/es/index.js`	413 kB	+115 B (+0.03%)

ℹ️ View Unchanged

Filename	Size
`packages/kas/dist/es/index.js`	38.3 kB
`packages/kmath/dist/es/index.js`	4.27 kB
`packages/math-input/dist/es/index.js`	80.3 kB
`packages/math-input/dist/es/strings.js`	1.73 kB
`packages/perseus-core/dist/es/index.js`	1.48 kB
`packages/perseus-linter/dist/es/index.js`	21.6 kB
`packages/perseus/dist/es/strings.js`	3.29 kB
`packages/pure-markdown/dist/es/index.js`	3.67 kB
`packages/simple-markdown/dist/es/index.js`	12.4 kB

_{compressed-size-action}

codecov · 2024-08-06T22:05:06Z

Codecov Report

Attention: Patch coverage is 99.71264% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.56%. Comparing base (de2883b) to head (9f98040).

Files	Patch %	Lines
...ts/graph-locked-figures/locked-figure-settings.tsx	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
+ Coverage   70.30%   70.56%   +0.25%     
==========================================
  Files         510      515       +5     
  Lines      105645   105967     +322     
  Branches     7690    11469    +3779     
==========================================
+ Hits        74274    74775     +501     
- Misses      31189    31192       +3     
+ Partials      182        0     -182

Files	Coverage Δ
...onents/graph-locked-figures/line-stroke-select.tsx	`100.00% <100.00%> (ø)`
...s/graph-locked-figures/locked-ellipse-settings.tsx	`100.00% <100.00%> (ø)`
...ts/graph-locked-figures/locked-figures-section.tsx	`100.00% <ø> (+2.24%)`	⬆️
.../graph-locked-figures/locked-function-settings.tsx	`100.00% <100.00%> (ø)`
...ents/graph-locked-figures/locked-line-settings.tsx	`98.45% <100.00%> (-0.15%)`	⬇️
...s/graph-locked-figures/locked-polygon-settings.tsx	`100.00% <100.00%> (ø)`
...eractive-graphs/locked-figures/locked-function.tsx	`100.00% <100.00%> (ø)`
...ts/graph-locked-figures/locked-figure-settings.tsx	`95.23% <87.50%> (-0.82%)`	⬇️

... and 153 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de2883b...9f98040. Read the comment docs.

khan-actions-bot · 2024-08-06T22:55:17Z

Gerald

Required Reviewers

@Khan/perseus for changes to .changeset/chilly-apples-accept.md, packages/perseus/src/perseus-types.ts, packages/perseus/src/widgets/__testdata__/interactive-graph.testdata.ts, packages/perseus/src/widgets/__tests__/interactive-graph.test.tsx, packages/perseus-editor/src/components/__stories__/locked-function-settings.stories.tsx, packages/perseus-editor/src/components/__tests__/locked-function-settings.test.tsx, packages/perseus-editor/src/components/graph-locked-figures/line-stroke-select.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-ellipse-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-figure-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-figures-section.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-function-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-line-settings.tsx, packages/perseus-editor/src/components/graph-locked-figures/locked-polygon-settings.tsx, packages/perseus-editor/src/widgets/__tests__/interactive-graph-editor-locked-figures.test.tsx, packages/perseus/src/widgets/interactive-graphs/locked-figures/locked-function.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

nishasy · 2024-08-06T23:03:58Z

packages/perseus-editor/src/components/__tests__/locked-function-settings.test.tsx

+            expect(onChangeProps).toHaveBeenCalledTimes(3);
+            expect(onChangeProps).toHaveBeenNthCalledWith(1, {equation: "z"});
+            expect(onChangeProps).toHaveBeenNthCalledWith(2, {equation: "o"});
+            expect(onChangeProps).toHaveBeenNthCalledWith(3, {equation: "t"});


I'm a little confused about this. How come it's not

expect(onChangeProps).toHaveBeenNthCalledWith(1, {equation: "z"}); expect(onChangeProps).toHaveBeenNthCalledWith(2, {equation: "zo"}); expect(onChangeProps).toHaveBeenNthCalledWith(3, {equation: "zot"});

?

I added a note in the test explaining this. The reason is due to onChangeProps being mocked, and not passing the typed letter to the equation field.

nishasy · 2024-08-06T23:05:11Z

packages/perseus-editor/src/components/__tests__/locked-function-settings.test.tsx

+            expect(onChangeProps).toHaveBeenCalledWith({directionalAxis: "y"});
+        });
+
+        describe("Domain restrictions", () => {


Is this describe block supposed to be nested within the "settings interactions" describe block?

Yes. Since domain restrictions have more tests, I wanted them grouped. Since these tests are still interaction tests, I kept them as a sub-block within "Settings interactions". Based upon your question, I've changed the title to be "Domain interactions" to be more consistent.

nishasy · 2024-08-06T23:09:43Z

packages/perseus-editor/src/components/__tests__/locked-function-settings.test.tsx

+                await userEvent.type(domainMaxField, "-2");
+
+                // Assert
+                // expect(onChangeProps).toHaveBeenCalledTimes(2);


I suspect you didn't mean to leave this comment here

Correct. Good catch. Thank you.

nishasy · 2024-08-06T23:14:00Z

packages/perseus-editor/src/components/__tests__/locked-function-settings.test.tsx

I really appreciate the comprehensive testing!

100% code coverage, or bust!

nishasy · 2024-08-06T23:19:53Z

packages/perseus-editor/src/components/graph-locked-figures/locked-function-settings.tsx

+        domain && domain[1] !== Infinity ? domain[1].toString() : "",
+    ]);
+
+    useEffect(() => {


It sounds like this useEffect is here to handle the domain changing to/from infinity? Is that right?

Could you add a commenting explaining why this useEffect is necessary?

Comment added.

nishasy · 2024-08-06T23:30:40Z

packages/perseus-editor/src/components/graph-locked-figures/locked-function-settings.tsx

+                            )}
+                        />
+                    </View>
+


Nit: Add a comment here to stay consistent with the other comments.

{/* Directional axis settings */}

nishasy · 2024-08-06T23:41:21Z

packages/perseus-editor/src/components/graph-locked-figures/locked-function-settings.tsx

+const styles = StyleSheet.create({
+    accordionHeader: {
+        textOverflow: "ellipsis",
+        maxWidth: "calc(100% - 64px)",


Why was it necessary to use calc here? I think padding should work too, right?

Explanation added.

Thank you for the comprehensive explanations!

nishasy · 2024-08-06T23:41:56Z

packages/perseus-editor/src/components/graph-locked-figures/locked-function-settings.tsx

+    domainMin: {
+        alignItems: "center",
+        display: "flex",
+        width: "calc(((100% - 141px) / 2) + 88.6px)",


Could you add a comment explaining this calculation here in domainMin and down below in domainMax?

nishasy · 2024-08-06T23:43:31Z

packages/perseus/src/widgets/interactive-graphs/locked-figures/locked-function.tsx

+
+    useEffect(() => {
+        // Parsing the equation in a "useEffect" hook saves about 2ms each frame
+        //    when the learner is interacting with the graph (i.e. moving points).


Thank you for this comment!

nishasy · 2024-08-06T23:43:46Z

packages/perseus-editor/src/components/graph-locked-figures/line-stroke-select.tsx

Thank you for this! 🎉 And for replacing all the instances of it in the other files.

nishasy

Left some small comments earlier. I trust you'll get to them, so I'll approve the PR now since I'll be OOO tomorrow.

Remove unused code in 'locked-function-settings.tsx'.

github-actions · 2024-08-07T21:16:19Z

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (ffeea6d) and published it to npm. You
can install it using the tag PR1493.

Example:

yarn add @khanacademy/perseus@PR1493

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1493

nishasy

Awesome!! Thank you so much for the updates. This looks sooooo gooooooood, I'm so excited 🎉

nishasy · 2024-08-08T17:25:58Z

packages/perseus-editor/src/components/__tests__/locked-function-settings.test.tsx

+            expect(onChangeProps).toHaveBeenCalledTimes(3);
+            expect(onChangeProps).toHaveBeenNthCalledWith(1, {equation: "z"});
+            expect(onChangeProps).toHaveBeenNthCalledWith(2, {equation: "o"});
+            expect(onChangeProps).toHaveBeenNthCalledWith(3, {equation: "t"});


nishasy · 2024-08-08T17:31:38Z

packages/perseus-editor/src/components/graph-locked-figures/locked-function-settings.tsx

+const styles = StyleSheet.create({
+    accordionHeader: {
+        textOverflow: "ellipsis",
+        maxWidth: "calc(100% - 64px)",


Thank you for the comprehensive explanations!

@handeyeco

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Major Changes - [#1479](#1479) [`ef96cdd54`](ef96cdd) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove PropCheckBox component from Perseus; use WB instead ### Minor Changes - [#1455](#1455) [`8b0268215`](8b02682) Thanks [@Myranae](https://github.com/Myranae)! - Update Polygon graphs to have weighted lines only on keyboard focus - [#1492](#1492) [`2ebbc1978`](2ebbc19) Thanks [@nishasy](https://github.com/nishasy)! - [Hint Mode: Start Coords] Build the foundation for adding start coords UI for angle graphs - [#1428](#1428) [`eb9f3f9c0`](eb9f3f9) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Drop katex dependency - no longer used - [#1472](#1472) [`4c2ace57a`](4c2ace5) Thanks [@benchristel](https://github.com/benchristel)! - Add keyboard controls to Mafs angle graphs - [#1487](#1487) [`53031f8df`](53031f8) Thanks [@Myranae](https://github.com/Myranae)! - Make graphs non-interactive via keyboard when their question has been answered correctly - [#1486](#1486) [`0b625f560`](0b625f5) Thanks [@nishasy](https://github.com/nishasy)! - [Hint Mode: Start Coords] Add start coords UI for point graphs - [#1488](#1488) [`0bec013e8`](0bec013) Thanks [@nishasy](https://github.com/nishasy)! - [Hint Mode: Start Coords] Add start coords UI for polygon graphs (snap to grid only) ### Patch Changes - [#1474](#1474) [`a8aaac339`](a8aaac3) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Minor type fixes in the `ImageLoader` and `SvgImage` components - [#1493](#1493) [`de13fd337`](de13fd3) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Add/Edit/Delete Locked Function in Interactive Graph Editor - [#1476](#1476) [`18f38fca4`](18f38fc) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Miscellaneous type improvements - [#1489](#1489) [`de2883b3f`](de2883b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Correct `hints` type on ItemRenderer - [#1478](#1478) [`7fd586ef4`](7fd586e) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add "white" as a fill option for locked ellipses and polygons - [#1482](#1482) [`f920a4cc7`](f920a4c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor: Storybook] Add a story for Point graph type start coords - [#1484](#1484) [`808956098`](8089560) Thanks [@handeyeco](https://github.com/handeyeco)! - Minor cleanup around InfoTip - [#1475](#1475) [`6a218bcc1`](6a218bc) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - add non-visual text as a description for expression widget - Updated dependencies \[[`6c6ff52f4`](6c6ff52), [`342a72211`](342a722), [`5e66539e6`](5e66539)]: - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Minor Changes - [#1493](#1493) [`de13fd337`](de13fd3) Thanks [@mark-fitzgerald](https://github.com/mark-fitzgerald)! - Add/Edit/Delete Locked Function in Interactive Graph Editor - [#1492](#1492) [`2ebbc1978`](2ebbc19) Thanks [@nishasy](https://github.com/nishasy)! - [Hint Mode: Start Coords] Build the foundation for adding start coords UI for angle graphs - [#1486](#1486) [`0b625f560`](0b625f5) Thanks [@nishasy](https://github.com/nishasy)! - [Hint Mode: Start Coords] Add start coords UI for point graphs - [#1488](#1488) [`0bec013e8`](0bec013) Thanks [@nishasy](https://github.com/nishasy)! - [Hint Mode: Start Coords] Add start coords UI for polygon graphs (snap to grid only) ### Patch Changes - [#1491](#1491) [`395b44f29`](395b44f) Thanks [@nishasy](https://github.com/nishasy)! - [Hint Mode: Start Coords] Correct flag logic for polygon graph start coords UI - [#1476](#1476) [`18f38fca4`](18f38fc) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Miscellaneous type improvements - [#1479](#1479) [`ef96cdd54`](ef96cdd) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove PropCheckBox component from Perseus; use WB instead - [#1489](#1489) [`de2883b3f`](de2883b) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Correct `hints` type on ItemRenderer - [#1478](#1478) [`7fd586ef4`](7fd586e) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Add "white" as a fill option for locked ellipses and polygons - [#1482](#1482) [`f920a4cc7`](f920a4c) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor: Storybook] Add a story for Point graph type start coords - [#1471](#1471) [`b4e0b60dc`](b4e0b60) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Fix the dropdowns overlapping labels in locked figures settings - [#1481](#1481) [`a35be719f`](a35be71) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Stop page scrolling on number text field focused scroll - [#1484](#1484) [`808956098`](8089560) Thanks [@handeyeco](https://github.com/handeyeco)! - Minor cleanup around InfoTip - [#1477](#1477) [`653b520c6`](653b520) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Migrate ItemExtrasEditor to WB checkboxes - Updated dependencies \[[`a8aaac339`](a8aaac3), [`de13fd337`](de13fd3), [`8b0268215`](8b02682), [`2ebbc1978`](2ebbc19), [`6c6ff52f4`](6c6ff52), [`18f38fca4`](18f38fc), [`ef96cdd54`](ef96cdd), [`342a72211`](342a722), [`de2883b3f`](de2883b), [`7fd586ef4`](7fd586e), [`f920a4cc7`](f920a4c), [`eb9f3f9c0`](eb9f3f9), [`4c2ace57a`](4c2ace5), [`53031f8df`](53031f8), [`808956098`](8089560), [`5e66539e6`](5e66539), [`0b625f560`](0b625f5), [`6a218bcc1`](6a218bc), [`0bec013e8`](0bec013)]: - @khanacademy/[email protected] - @khanacademy/[email protected] ## @khanacademy/[email protected] ### Patch Changes - [#1495](#1495) [`6c6ff52f4`](6c6ff52) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove old buttons that we weren't using anymore - [#1475](#1475) [`342a72211`](342a722) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - update wonder blocks popover versions - [#1496](#1496) [`5e66539e6`](5e66539) Thanks [@handeyeco](https://github.com/handeyeco)! - Remove unused buttons from MathInput; add Lato ## @khanacademy/[email protected] ### Patch Changes - Updated dependencies \[[`6c6ff52f4`](6c6ff52), [`342a72211`](342a722), [`5e66539e6`](5e66539)]: - @khanacademy/[email protected] Author: khan-actions-bot Reviewers: Myranae Required Reviewers: Approved By: Myranae Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ⏭️ Publish npm snapshot, ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1473

Mark Fitzgerald added 8 commits July 29, 2024 16:08

Add settings section for locked function (currently showing just colo…

be144ef

…r and line style options). Move common code for selecting line style to its own component (just like with the color selector).

Merge branch 'main' into LEMS-1947-add-edit-delete-locked-function

c81228a

Remove 'equationParsed' property from LockedFunctionType - there's no…

4df590f

… good way to load the parsed equation to save time, we still need to call 'parse()'. Adjust 'LockedFunction' jsx to only parse the equation when it is changed. Add equation field to graph settings.

Change "LineStyleSelect" to "LineStrokeSelect", and update unit tests…

2631506

… accordingly. Add directional axis and domain limits to settings panel.

Change directional axis designation to be a select option that acts a…

917ce64

…s a label for the equation. Update the logic that handles the entry of domain limits.

Merge latest from main.

4a3c93e

Adjust 'onChange' handling for domain limits.

8af5db2

Update unit tests accordingly.

Merge branch 'main' into LEMS-1947-add-edit-delete-locked-function

5f8a970

mark-fitzgerald self-assigned this Aug 6, 2024

mark-fitzgerald requested review from nishasy, nicolecomputer and benchristel August 6, 2024 22:14

Mark Fitzgerald added 3 commits August 6, 2024 15:16

Prettier.

b9c554c

Lint fixes.

c1fa1ac

Add locked function to test data.

a11a99f

mark-fitzgerald marked this pull request as ready for review August 6, 2024 22:55

khan-actions-bot requested a review from a team August 6, 2024 22:55

nishasy reviewed Aug 6, 2024

View reviewed changes

nishasy approved these changes Aug 7, 2024

View reviewed changes

Add comments and adjust code based upon PR feedback.

764de56

Remove unused code in 'locked-function-settings.tsx'.

Prettier.

9f98040

nishasy approved these changes Aug 8, 2024

View reviewed changes

Merge branch 'main' into LEMS-1947-add-edit-delete-locked-function

ffeea6d

mark-fitzgerald merged commit de13fd3 into main Aug 8, 2024
9 checks passed

mark-fitzgerald deleted the LEMS-1947-add-edit-delete-locked-function branch August 8, 2024 19:06

khan-actions-bot mentioned this pull request Aug 8, 2024

Version Packages #1473

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Interactive Graph Editor] Add/Edit/Delete Locked Function #1493

[Interactive Graph Editor] Add/Edit/Delete Locked Function #1493

mark-fitzgerald commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Aug 6, 2024 •

edited

Loading

codecov bot commented Aug 6, 2024 •

edited

Loading

khan-actions-bot commented Aug 6, 2024

nishasy Aug 6, 2024

mark-fitzgerald Aug 7, 2024

nishasy Aug 8, 2024

nishasy Aug 6, 2024

mark-fitzgerald Aug 7, 2024

nishasy Aug 6, 2024

mark-fitzgerald Aug 7, 2024

nishasy Aug 6, 2024

mark-fitzgerald Aug 7, 2024

nishasy Aug 6, 2024

mark-fitzgerald Aug 7, 2024

nishasy Aug 6, 2024

mark-fitzgerald Aug 7, 2024

nishasy Aug 6, 2024

mark-fitzgerald Aug 7, 2024

nishasy Aug 8, 2024

nishasy Aug 6, 2024

mark-fitzgerald Aug 7, 2024

nishasy Aug 6, 2024

nishasy Aug 6, 2024

nishasy left a comment

github-actions bot commented Aug 7, 2024 •

edited

Loading

nishasy left a comment

nishasy Aug 8, 2024

nishasy Aug 8, 2024

[Interactive Graph Editor] Add/Edit/Delete Locked Function #1493

[Interactive Graph Editor] Add/Edit/Delete Locked Function #1493

Conversation

mark-fitzgerald commented Aug 6, 2024 • edited Loading

Summary:

Test plan:

Affected UI

New settings options

github-actions bot commented Aug 6, 2024 • edited Loading

codecov bot commented Aug 6, 2024 • edited Loading

Codecov Report

khan-actions-bot commented Aug 6, 2024

Gerald

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nishasy left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 7, 2024 • edited Loading

npm Snapshot: Published

nishasy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mark-fitzgerald commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Aug 6, 2024 •

edited

Loading

codecov bot commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Aug 7, 2024 •

edited

Loading