clean up info-tip (#1484)

* clean up info-tip * changeset
Khan · Aug 5, 2024 · 8089560 · 8089560
1 parent 653b520
commit 8089560
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/.changeset/silly-ears-cheer.md b/.changeset/silly-ears-cheer.md
@@ -0,0 +1,6 @@
+---
+"@khanacademy/perseus": patch
+"@khanacademy/perseus-editor": patch
+---
+
+Minor cleanup around InfoTip
diff --git a/packages/perseus-editor/src/widgets/cs-program-editor.tsx b/packages/perseus-editor/src/widgets/cs-program-editor.tsx
@@ -243,9 +243,6 @@ class CSProgramEditor extends React.Component<any> {
                         pairs={this.props.settings}
                         onChange={this._handleSettingsChange}
                     />
-                    {/* InfoTip is complaining about <code> not being a string
-                        or React.ReactElement even though it should be valid.
-                    @ts-expect-error - TS2769 - No overload matches this call. */}
                     <InfoTip>
                         Settings that you add here are available to the program
                         as an object returned by <code>Program.settings()</code>

diff --git a/packages/perseus/src/components/__stories__/info-tip.stories.tsx b/packages/perseus/src/components/__stories__/info-tip.stories.tsx
@@ -18,9 +18,6 @@ export const TextOnMouseover = (args: StoryArgs): React.ReactElement => {
 
 export const CodeInText = (args: StoryArgs): React.ReactElement => {
     return (
-        // InfoTip is complaining about <code> not being a string
-        // or React.ReactElement even though it should be valid.
-        // @ts-expect-error - TS2769 - No overload matches this call.
         <InfoTip>
             Settings that you add here are available to the program as an object
             returned by <code>Program.settings()</code>

diff --git a/packages/perseus/src/components/info-tip.tsx → ...perseus/src/components/info-tip/index.tsx b/packages/perseus/src/components/info-tip.tsx → ...perseus/src/components/info-tip/index.tsx
@@ -7,11 +7,11 @@
 
 import * as React from "react";
 
-import ReactComponentsInfoTip from "./info-tip/info-tip";
+import InfoTipBase from "./info-tip-base";
 
 import type {PropsFor} from "@khanacademy/wonder-blocks-core";
 
-type Props = PropsFor<typeof ReactComponentsInfoTip>;
+type Props = PropsFor<typeof InfoTipBase>;
 
 type State = {
     didMount: boolean;
@@ -30,7 +30,7 @@ class InfoTip extends React.Component<Props, State> {
 
     render(): React.ReactNode {
         if (this.state.didMount) {
-            return <ReactComponentsInfoTip {...this.props} />;
+            return <InfoTipBase {...this.props} />;
         }
         return <div />;
     }

diff --git a/...seus/src/components/info-tip/info-tip.tsx → ...src/components/info-tip/info-tip-base.tsx b/...seus/src/components/info-tip/info-tip.tsx → ...src/components/info-tip/info-tip-base.tsx
@@ -7,10 +7,10 @@ import {StyleSheet} from "aphrodite";
 import * as React from "react";
 
 type Props = {
-    children: string | React.ReactElement | React.ReactElement[];
+    children: React.ReactNode;
 };
 
-export const InfoTip = (props: Props) => {
+const InfoTipBase = (props: Props) => {
     return (
         <Tooltip
             content={<Body style={styles.body}>{props.children}</Body>}
@@ -34,4 +34,4 @@ const styles = StyleSheet.create({
     },
 });
 
-export default InfoTip;
+export default InfoTipBase;