Hints: fix hints type on PerseusItem to be correct

[jeremywiebe]

Summary:

Our hints type on ItemRenderer used the PerseusRenderer type. That's mostly correct, except that a Hint can also have the replace key.

Issue: "none"

Test plan:

yarn typecheck ✅

[jeremywiebe]

Moving away from _ gives us better typing.

[github-actions]

Size Change: +102 B (+0.01%)

Total Size: 853 kB

Filename	Size	Change
packages/perseus-editor/dist/es/index.js	273 kB	-99 B (-0.04%)
packages/perseus/dist/es/index.js	413 kB	+201 B (+0.05%)

ℹ️ View Unchanged

Filename	Size
packages/kas/dist/es/index.js	38.3 kB
packages/kmath/dist/es/index.js	4.27 kB
packages/math-input/dist/es/index.js	80.8 kB
packages/math-input/dist/es/strings.js	1.73 kB
packages/perseus-core/dist/es/index.js	1.48 kB
packages/perseus-linter/dist/es/index.js	21.6 kB
packages/perseus/dist/es/strings.js	3.29 kB
packages/pure-markdown/dist/es/index.js	3.67 kB
packages/simple-markdown/dist/es/index.js	12.4 kB

_{compressed-size-action}

[khan-actions-bot]

Gerald

Required Reviewers

• @Khan/perseus for changes to .changeset/gentle-planes-rest.md, packages/perseus/src/hints-renderer.tsx, packages/perseus/src/index.ts, packages/perseus/src/perseus-types.ts, packages/perseus/src/types.ts, packages/perseus-editor/src/hint-editor.tsx, packages/perseus/src/multi-items/multi-renderer.tsx, packages/perseus/src/widgets/__testdata__/grapher.testdata.ts, packages/perseus/src/widgets/__testdata__/interaction.testdata.ts, packages/perseus/src/widgets/__testdata__/video.testdata.ts

---

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

[codecov]

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.47%. Comparing base (18f38fc) to head (0a0fa72).
Report is 1 commits behind head on main.

Files	Patch %	Lines
packages/perseus-editor/src/hint-editor.tsx	16.66%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1489      +/-   ##
==========================================
+ Coverage   70.21%   70.47%   +0.25%     
==========================================
  Files         510      513       +3     
  Lines      105645   105683      +38     
  Branches     7681    11441    +3760     
==========================================
+ Hits        74182    74478     +296     
+ Misses      31283    31205      -78     
+ Partials      180        0     -180     

Files	Coverage Δ
packages/perseus/src/hints-renderer.tsx	78.87% <100.00%> (+2.34%)	⬆️
packages/perseus/src/index.ts	100.00% <100.00%> (ø)
...ackages/perseus/src/multi-items/multi-renderer.tsx	77.22% <100.00%> (+0.31%)	⬆️
...rseus/src/widgets/__testdata__/grapher.testdata.ts	100.00% <ø> (ø)
packages/perseus-editor/src/hint-editor.tsx	86.02% <16.66%> (+0.86%)	⬆️

... and 147 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f38fc...0a0fa72. Read the comment docs.

[benchristel]

Looks good overall. I left a couple suggestions inline. Thanks for fixing this!

[benchristel]

The PerseusRenderer type already has a replace property — should that be removed now?

[jeremywiebe]

Good catch! Yes, we can remove it now!

[github-actions]

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (0a0fa72) and published it to npm. You
can install it using the tag PR1489.

Example:

yarn add @khanacademy/perseus@PR1489

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1489