Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Interactive Graph Editor] Fix the dropdowns overlapping labels in lo…
…cked figures settings (#1471) ## Summary: There was an issue where some of the dropdowns in the locked figures settings are expanding to fit their content, and thereby overlapping other labels. The intended behavior is for the dropdown label to truncate. Fixing that with CSS here. Issue: https://khanacademy.atlassian.net/browse/LEMS-2118 ## Test plan: Storybook - http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-figures-m-2-b-flag - Use the dev tools to make all the locked figure settings 306px to reflect how they are in webapp. - Set all the dropdowns to their longest options. - Confirm that they truncate, and that the horizontal space between the labels and dropdowns is there. ## Screenshots | Before | After | | --- | --- | | <img width="326" alt="Screenshot 2024-07-31 at 5 07 54 PM" src="https://github.com/user-attachments/assets/20549cc8-b8f6-4142-b742-14853296c2e2"> | <img width="340" alt="Screenshot 2024-07-31 at 5 05 56 PM" src="https://github.com/user-attachments/assets/c0e6b803-4546-4be7-a6ee-116c379c4f07"> | | <img width="326" alt="Screenshot 2024-07-31 at 5 08 51 PM" src="https://github.com/user-attachments/assets/471621a4-2a78-4960-b822-71e4a188eb97"> | <img width="333" alt="Screenshot 2024-07-31 at 5 06 07 PM" src="https://github.com/user-attachments/assets/328825a8-84bc-408b-9f6c-cb931faa3a82"> | | <img width="330" alt="Screenshot 2024-07-31 at 5 09 18 PM" src="https://github.com/user-attachments/assets/8b2e9128-9f92-43a4-a240-5ac52add9ed8"> | <img width="339" alt="Screenshot 2024-07-31 at 5 06 13 PM" src="https://github.com/user-attachments/assets/8ed5c89d-6af0-4bf0-8315-16b7cbec0493"> | Author: nishasy Reviewers: mark-fitzgerald Required Reviewers: Approved By: mark-fitzgerald Checks: ✅ codecov/project, ✅ codecov/patch, ✅ Upload Coverage (ubuntu-latest, 20.x), ✅ gerald, ⏭️ Publish npm snapshot, ✅ Cypress (ubuntu-latest, 20.x), ✅ Jest Coverage (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), 🚫 Upload Coverage, ✅ gerald, ⏭️ Publish npm snapshot, 🚫 Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), 🚫 Jest Coverage (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), 🚫 Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1471
- Loading branch information