Integration with JabRef online #7832

Siedlerchr · 2021-06-19T10:47:06Z

This PR keeps track of the whole process to integrate JabRef with JabRef online. New PRs should be targeted to this PR. After all PRs have gone into this one AND this one is ready, it will be merged.

Refs #7796 #7798 #7582

To run the new tests: gradle test --tests "*online*"

TODO:

Automatically download graphql schema during build
Remove test queries and their classes
Add authentication using a custom cookieJar that stores the cookie across sessions (might be helpful: https://github.com/franmontiel/PersistentCookieJar or https://www.programmersought.com/article/21021005004/ )
Pull changes
Push changes
Find solution for Provide module info origin-energy/java-snapshot-testing#108

[] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
[] Tests created for changes (if applicable)
[] Manually tested changed features in running JabRef (always required)
[] Screenshots added in PR description (for UI changes)
[] Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

* upstream/main: Refactoring existing unit tests into parametrized tests (#7700) Replace <p> in localization by \n (#7279) Bump byte-buddy-parent from 1.11.0 to 1.11.1 (#7800) Bump org.javamodularity.moduleplugin from 1.8.6 to 1.8.7 (#7799) Bump mockito-core from 3.10.0 to 3.11.0 (#7801) Bump classgraph from 4.8.106 to 4.8.108 (#7802) Update .markdownlint.yml Ignore slant.co links GitBook: [main] 3 pages and 17 assets modified GitBook: [main] one page modified GitBook: [main] one page modified GitBook: [main] 6 pages and 42 assets modified # Conflicts: # build.gradle

…line * 'jabrefonline' of github.com:JabRef/jabref: # Conflicts: # build.gradle

* upstream/main: Added auto-key-generation task to task-progress (#7797) cleanup temporary files, use prefix "jabref-" (#7811) Add easier how-to for checklist (#7813) Fix annotation + package of ACMPortalParserTest (#7812) Implemented a select all button for the library import function (issue #7786) (#7808) Fix for issue 4682 : Restructuring the side pane structure having additional functionality and merging the remove group menus (#7714)

not workin yet

* upstream/main: [Bot] Update CSL styles (#7824) Pin version of citeproc-java (#7827) JournalAbbreviation search feature (#7804) Bump fontbox from 2.0.23 to 2.0.24 (#7815) Revert "Bump org.eclipse.jgit (#7820)" (#7823) Bump bcprov-jdk15on from 1.68 to 1.69 (#7816) Bump postgresql from 42.2.20 to 42.2.21 (#7817) Bump org.eclipse.jgit (#7820) Bump mockito-core from 3.11.0 to 3.11.1 (#7819) Bump pdfbox from 2.0.23 to 2.0.24 (#7818) Bump byte-buddy-parent from 1.11.1 to 1.11.2 (#7821) Bump xmpbox from 2.0.23 to 2.0.24 (#7822)

* upstream/main: Update Gradle Wrapper from 7.0.2 to 7.1. (#7829) Oobranch b : add utilies (#7787)

prevent split packages

Siedlerchr · 2021-06-19T10:49:10Z

Probably needs to be included in the jlink as well

calixtus · 2021-06-20T07:36:35Z

Should we merge this PR or let some other PR pick up the branch?

Siedlerchr · 2021-06-20T10:49:30Z

I would vote to merge this PR, so we have a basis for further development and avoid any conflicts with the gradle stuff

github-actions · 2022-10-23T19:32:04Z

src/main/java/org/jabref/logic/jabrefonline/RemoteService.java

+import java.util.stream.Collectors;
+
+import org.jabref.jabrefonline.UserChangesQuery;
+import org.jabref.jabrefonline.UserChangesQuery.Node;


🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck> _{reported by reviewdog 🐶}
Unused import - org.jabref.jabrefonline.UserChangesQuery.Node.

github-actions · 2022-10-25T18:46:21Z

src/test/java/org/jabref/logic/jabrefonline/JabRefOnlineServiceTest.java

+    private Expect expect;
+
+    @Test
+    void testCreateEntries() {


🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpMultilineCheck> _{reported by reviewdog 🐶}
Blank line at end of block should be removed

github-actions · 2022-10-25T18:46:21Z

src/test/java/org/jabref/logic/jabrefonline/JabRefOnlineServiceTest.java

+    private Expect expect;
+
+    @Test
+    void testCreateEntries() {


🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpMultilineCheck> _{reported by reviewdog 🐶}
Blank line at start of block should be removed

github-actions · 2022-10-25T18:46:21Z

src/test/java/org/jabref/logic/jabrefonline/JabRefOnlineServiceTest.java

+    }
+
+    @Test
+    void testUpdateEntries() {


🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpMultilineCheck> _{reported by reviewdog 🐶}
Blank line at end of block should be removed

github-actions · 2022-10-25T18:46:21Z

src/test/java/org/jabref/logic/jabrefonline/JabRefOnlineServiceTest.java

+    }
+
+    @Test
+    void testUpdateEntries() {


🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpMultilineCheck> _{reported by reviewdog 🐶}
Blank line at start of block should be removed

github-actions · 2022-10-28T11:22:54Z

src/test/java/org/jabref/logic/jabrefonline/__snapshots__/JabRefOnlineServiceTest.snap

@@ -0,0 +1,16 @@
+org.jabref.logic.jabrefonline.JabRefOnlineServiceTest.getAllChanges=[


🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.NewlineAtEndOfFileCheck> _{reported by reviewdog 🐶}
File does not end with a newline.

github-actions · 2022-11-13T11:20:26Z

src/test/java/org/jabref/logic/online/JabRefOnlineTransformerTest.java

+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import java.time.ZoneId;


🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck> _{reported by reviewdog 🐶}
Wrong order for 'java.time.ZoneId' import.

src/test/java/org/jabref/logic/online/JabRefOnlineTransformerTest.java

src/test/java/org/jabref/logic/online/JabRefOnlineServiceTest.java

github-actions · 2022-11-13T11:20:26Z

src/test/java/org/jabref/logic/online/JabRefOnlineServiceTest.java

+    private Expect expect;
+
+    @Test
+    void testCreateEntries() {


🚫 [reviewdog] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpMultilineCheck> _{reported by reviewdog 🐶}
Blank line at start of block should be removed

src/test/java/org/jabref/logic/online/JabRefOnlineServiceTest.java

* upstream/main: (1565 commits) Enable journal information fetcher directly in popup (#10598) Make generate button wider (#10588) make openRewrite stable again Rename cleanup_pr.yml to cleanup-pr.yml Changelog Fix failing fetcher tests (#10613) ShortDoi Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (#10607) Fix issue #9306: Move "Open only one instance of JabRef" preference option to somewhere else (#10602) Update README.md (#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 Synchronize scrollbars in the change resolver dialog (#10587) Add button for a user to reset the cite command to the default value. (#10580) openrerwrite Update .github/PULL_REQUEST_TEMPLATE.md Update PULL_REQUEST_TEMPLATE.md ... # Conflicts: # .devcontainer/devcontainer.json # build.gradle # src/main/java/org/jabref/gui/DefaultInjector.java # src/main/java/org/jabref/gui/libraryproperties/general/GeneralProperties.fxml # src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java # src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesViewModel.java # src/main/java/org/jabref/logic/exporter/MetaDataSerializer.java # src/main/java/org/jabref/logic/importer/util/MetaDataParser.java # src/main/java/org/jabref/model/metadata/MetaData.java # src/main/java/org/jabref/preferences/JabRefPreferences.java

github-actions · 2023-11-04T16:22:59Z

Your code currently does not meet JabRef's code guidelines. We use OpenRewrite to ensure "modern" Java coding practices. The issues found can be automatically fixed. Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output at the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

github-actions · 2023-11-04T16:23:41Z

Your code currently does not meet JabRef's code guidelines. We use Gradle Modernizer Plugin to ensure "modern" Java coding practices. Please fix the detected errors, commit, and push.

You can check the detailed error output at the tab "Checks", section "Tests" (on the left), subsection "Modernizer".

github-actions · 2023-11-04T16:23:49Z

Your code currently does not meet JabRef's code guidelines. We use Checkstyle to identify issues. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

github-actions · 2024-01-07T13:50:20Z

The build of this PR is available at https://builds.jabref.org/pull/7832/merge.

Siedlerchr and others added 23 commits June 6, 2021 17:08

add apollo graphlql stuff

a90cd06

fix graphqlsource dir

953448c

add annotaitons and okio

af79b80

use apollo jvm

b9ca9cb

fix modulartiy issues

6287d64

Add kotlin library

51cbf59

Require kotlin standard lib

ca30630

Remove explicit kotlin dependency again

f29ddee

set rootpackage

5bcabab

try to set outputDir but does not work yet

9e0ab5b

Merge branch 'main' into jabrefonline

afc1f3d

Merge branch 'jabrefonline' of github.com:JabRef/jabref into jabrefon…

6388a41

…line * 'jabrefonline' of github.com:JabRef/jabref: # Conflicts: # build.gradle

try patching apollo for eclipse

0f02a6f

not workin yet

try with all unnamed

e7cda72

Merge remote-tracking branch 'upstream/main' into jabrefonline

b8c0e4d

* upstream/main: Update Gradle Wrapper from 7.0.2 to 7.1. (#7829) Oobranch b : add utilies (#7787)

compile custom apollo variant using shadow jar

e04c535

prevent split packages

add apollo jar building

7586334

Change jar name

866f2a3

chang eeclipse output

d9cbf2f

Add mutation, move java class

7edd6ab

Siedlerchr added 2 commits June 19, 2021 13:01

fix checkstyle

09779f5

align version

f7c490b

add info on modules

b79bf7e

Siedlerchr added the status: devcall label Jun 20, 2021

tobiasdiez added 3 commits October 21, 2022 22:22

Extend transformer

8435d96

fix login check

d8f7385

Add push method

8c2ed8f

github-actions bot reviewed Oct 23, 2022

View reviewed changes

tobiasdiez added 2 commits October 25, 2022 18:43

fix build

98eacae

add tests

8f7e0dd

github-actions bot reviewed Oct 25, 2022

View reviewed changes

tobiasdiez mentioned this pull request Oct 25, 2022

Provide module info origin-energy/java-snapshot-testing#108

Closed

fix tests

34c4cab

github-actions bot reviewed Oct 28, 2022

View reviewed changes

tobiasdiez added 5 commits November 3, 2022 16:49

Print snapshots as json

9fcbf4b

Rename package to "online"

3bf8381

Merge remote-tracking branch 'origin/main' into jabrefonline

2ac1fb0

improve transformer

d60436c

remove unnecessary tests

7081430

github-actions bot reviewed Nov 13, 2022

View reviewed changes

tobiasdiez mentioned this pull request Nov 13, 2022

WIP JabRef Online apollo integration koppor/jabref#505

Closed

Siedlerchr dismissed tobiasdiez’s stale review via 7081430 November 21, 2022 17:22

Merge branch 'main' into jabrefonline

e4b56e9

tobiasdiez mentioned this pull request Apr 25, 2023

Implement remote storage sync koppor/jabref#642

Draft

4 tasks

koppor force-pushed the main branch from 0594cb2 to c444c73 Compare October 10, 2023 21:26

Siedlerchr added 4 commits November 4, 2023 17:33

fix build

efb6af7

fix buid

3297b0d

checkstyle

0b07797

Merge branch 'main' into jabrefonline

b67afb8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integration with JabRef online #7832

Integration with JabRef online #7832

Siedlerchr commented Jun 19, 2021 •

edited by tobiasdiez

Loading

Siedlerchr commented Jun 19, 2021

calixtus commented Jun 20, 2021

Siedlerchr commented Jun 20, 2021

github-actions bot Oct 23, 2022

github-actions bot Oct 25, 2022

github-actions bot Oct 25, 2022

github-actions bot Oct 25, 2022

github-actions bot Oct 25, 2022

github-actions bot Oct 28, 2022

github-actions bot Nov 13, 2022

github-actions bot Nov 13, 2022

github-actions bot commented Nov 4, 2023

github-actions bot commented Nov 4, 2023

github-actions bot commented Nov 4, 2023

github-actions bot commented Jan 7, 2024

		@@ -0,0 +1,16 @@
		org.jabref.logic.jabrefonline.JabRefOnlineServiceTest.getAllChanges=[


		import static org.junit.jupiter.api.Assertions.assertEquals;

		import java.time.ZoneId;

Integration with JabRef online #7832

Are you sure you want to change the base?

Integration with JabRef online #7832

Conversation

Siedlerchr commented Jun 19, 2021 • edited by tobiasdiez Loading

Siedlerchr commented Jun 19, 2021

calixtus commented Jun 20, 2021

Siedlerchr commented Jun 20, 2021

github-actions bot Oct 23, 2022

Choose a reason for hiding this comment

github-actions bot Oct 25, 2022

Choose a reason for hiding this comment

github-actions bot Oct 25, 2022

Choose a reason for hiding this comment

github-actions bot Oct 25, 2022

Choose a reason for hiding this comment

github-actions bot Oct 25, 2022

Choose a reason for hiding this comment

github-actions bot Oct 28, 2022

Choose a reason for hiding this comment

github-actions bot Nov 13, 2022

Choose a reason for hiding this comment

github-actions bot Nov 13, 2022

Choose a reason for hiding this comment

github-actions bot commented Nov 4, 2023

github-actions bot commented Nov 4, 2023

github-actions bot commented Nov 4, 2023

github-actions bot commented Jan 7, 2024

Siedlerchr commented Jun 19, 2021 •

edited by tobiasdiez

Loading