Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotation + package of ACMPortalParserTest #7812

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix annotation + package of ACMPortalParserTest #7812

merged 1 commit into from
Jun 10, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Jun 10, 2021

ACMPortalParserTest was in the wrong package. Test connects to an external service, therefore annotated with FetcherTest

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor koppor requested a review from calixtus June 10, 2021 20:44
@calixtus calixtus merged commit 4827be0 into main Jun 10, 2021
@calixtus calixtus deleted the fix-acm-test-categorization branch June 10, 2021 21:03
Siedlerchr added a commit to koppor/jabref that referenced this pull request Jun 16, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jabrefonline
d5d4ed6 
* upstream/main:
  Added auto-key-generation task to task-progress (JabRef#7797)
  cleanup temporary files, use prefix "jabref-" (JabRef#7811)
  Add easier how-to for checklist (JabRef#7813)
  Fix annotation + package of ACMPortalParserTest (JabRef#7812)
  Implemented a select all button for the library import function (issue JabRef#7786) (JabRef#7808)
  Fix for issue 4682 : Restructuring the side pane structure having additional functionality and merging the remove group menus (JabRef#7714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus Awaiting requested review from calixtus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @calixtus