Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing fetcher tests #10613

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Fix failing fetcher tests #10613

merged 4 commits into from
Nov 1, 2023

Conversation

k3KAW8Pnf7mkmdSMPHz27
Copy link
Member

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Thanks!
I wonder why CollectionOfComputerScience Tests are not disabled, the website is offline since a while. So maybe we need to add a Disabled to the tests as well

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

Ah, I was wondering the same thing while going through the Git blame X)

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

@Siedlerchr imho deprecate/remove the class?

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

jabref/src/main/java/org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcher.java

Line 29 in dc2b649

private static final String BASIC_SEARCH_URL = "http://liinwww.ira.uka.de/bibliography/rss?";

@Siedlerchr
Copy link
Member

I would just add a @disabled annotation, For more information about CCSB see melting pot https://github.com/JabRef/jabref-issue-melting-pot/issues/259

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 marked this pull request as ready for review November 1, 2023 21:53
@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

Is there anything to do about the GROBID tests, or does the server need a kick?

@Siedlerchr
Copy link
Member

Grobid is running on Azure now, will auto-restart. I saw some things in the logs, but not sure. I restarted the container now.

@Siedlerchr
Copy link
Member

Can you check the UrlDownloadTest as well? seems like the is something wrong with the url

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

I'll be heading to sleep, but the 404 should be fixed, good catch!

When I am tired, I blame Grobid for everything 😳

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Member Author

GAH, too tired, sec.

@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 0a6f647 Nov 1, 2023
17 of 18 checks passed
@Siedlerchr Siedlerchr deleted the fix-failing-fetcher-tests branch November 1, 2023 22:59
Siedlerchr added a commit to guipmenezes/jabref that referenced this pull request Nov 4, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-10124
08211ef 
* upstream/main:
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  Rename cleanup_pr.yml to cleanup-pr.yml
  Changelog
  Fix failing fetcher tests (JabRef#10613)
  ShortDoi
Siedlerchr added a commit that referenced this pull request Nov 4, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into jabrefonline
7631a53 
* upstream/main: (1565 commits)
  Enable journal information fetcher directly in popup (#10598)
  Make generate button wider (#10588)
  make openRewrite stable again
  Rename cleanup_pr.yml to cleanup-pr.yml
  Changelog
  Fix failing fetcher tests (#10613)
  ShortDoi
  Fix CHANGELOG.md
  Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (#10607)
  Fix issue #9306: Move "Open only one instance of JabRef" preference option to somewhere else (#10602)
  Update README.md (#10604)
  Bump me.champeau.jmh from 0.7.1 to 0.7.2
  Bump org.beryx.jlink from 3.0.0 to 3.0.1
  Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1
  Synchronize scrollbars in the change resolver dialog (#10587)
  Add button for a user to reset the cite command to the default value. (#10580)
  openrerwrite
  Update .github/PULL_REQUEST_TEMPLATE.md
  Update PULL_REQUEST_TEMPLATE.md
  ...

# Conflicts:
#	.devcontainer/devcontainer.json
#	build.gradle
#	src/main/java/org/jabref/gui/DefaultInjector.java
#	src/main/java/org/jabref/gui/libraryproperties/general/GeneralProperties.fxml
#	src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java
#	src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesViewModel.java
#	src/main/java/org/jabref/logic/exporter/MetaDataSerializer.java
#	src/main/java/org/jabref/logic/importer/util/MetaDataParser.java
#	src/main/java/org/jabref/model/metadata/MetaData.java
#	src/main/java/org/jabref/preferences/JabRefPreferences.java
Siedlerchr added a commit to liyou969/jabref that referenced this pull request Nov 4, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into ScholarArchiveFetcher
c2467cd 
* upstream/main: (44 commits)
  change codecov (JabRef#10616)
  Add entry based on ISSN number JabRef#10124 (JabRef#10178)
  Enable journal information fetcher directly in popup (JabRef#10598)
  Make generate button wider (JabRef#10588)
  make openRewrite stable again
  Rename cleanup_pr.yml to cleanup-pr.yml
  Changelog
  Fix failing fetcher tests (JabRef#10613)
  ShortDoi
  Fix CHANGELOG.md
  Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607)
  Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602)
  Update README.md (JabRef#10604)
  Bump me.champeau.jmh from 0.7.1 to 0.7.2
  Bump org.beryx.jlink from 3.0.0 to 3.0.1
  Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0
  Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1
  Synchronize scrollbars in the change resolver dialog (JabRef#10587)
  Add button for a user to reset the cite command to the default value. (JabRef#10580)
  openrerwrite
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k3KAW8Pnf7mkmdSMPHz27 @Siedlerchr