-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace <p> in localization by \n #7279
Conversation
I think only in the search the formatting html tool tip are replaced with javafx formatting for bold etc |
But according to this thread https://stackoverflow.com/a/10285574/3450689 They should also work in the keys |
We should never split up lines of localizations into different keys. Thank you for the |
Intermediate report: We had
I am trying to dig deeper there. |
We should only keep the HTML tags for bold, italic and monospaced (See ToolTipTextUtil) because otherwise we can't indicate if the text is bold or not. As Javafx does not have HTML support, we must then use a TextFlow element with the CSS. |
- Remove obsolete translation keys - Make use of <tt> feature of ToolTipTextUtil
- Introduce special constructors for the .java and the .properties case - Fix escaping - Remove nested sub class
It may also worthwhile to explore if the language keys still need to be escaped at all. If I remember correctly, that's actually not the case any longer. |
- Change HashMap to more generic Map
…nches inside method)
…ure is a GUI feature now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions.
Everything else looks good enough to me. ;-)
Btw.: |
* upstream/main: Refactoring existing unit tests into parametrized tests (#7700) Replace <p> in localization by \n (#7279) Bump byte-buddy-parent from 1.11.0 to 1.11.1 (#7800) Bump org.javamodularity.moduleplugin from 1.8.6 to 1.8.7 (#7799) Bump mockito-core from 3.10.0 to 3.11.0 (#7801) Bump classgraph from 4.8.106 to 4.8.108 (#7802) Update .markdownlint.yml Ignore slant.co links GitBook: [main] 3 pages and 17 assets modified GitBook: [main] one page modified GitBook: [main] one page modified GitBook: [main] 6 pages and 42 assets modified # Conflicts: # build.gradle
Triggered by #7232 (comment), I saw that we did not cover the
RuntimeExceptions
by test cases. This PR adds them.This PR also adds a check for
\n
in Localization strings. I do not now anything about handling<br>
and\n
in JavaFX. It seems, that we cannot have line breaks in either way. Maybe, I should document that somewhere.