-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement copying cross-references #11228
base: main
Are you sure you want to change the base?
Conversation
getDialogPane().setMinHeight(170); | ||
setResizable(true); | ||
setContentText(""" | ||
The selected entry cross references 4 other entries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, Localization.lang does not work with textblocks yet.... You need to use \n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that I tried to switch to JavaParser or similar tooling for better localization handling. However, this did not work in all cases and lead to upstream issues.
I was thinking to use Kilt for JabRef. However, I did not see fast enough how to keep our localization checks. (Because I like that we have a check that the messages are verbatim included in the code). - And it seems, we would have to change all our parameterized strings (poiu-de/kilt#23). ( %0
to {0}
). And some layer on top of Kilt (which is not that harmful, but effort. And thus, the effort added too much for me).
Refs #7279
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the implementation: c6c7edd
(#8050)
@@ -11,6 +11,7 @@ | |||
public enum StandardActions implements Action { | |||
|
|||
COPY_MORE(Localization.lang("Copy") + "..."), | |||
COPY_TO(Localization.lang("Copy to") + "..."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this ... should be part of the localization string. I would change the above one as well
Closes #6404
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)