Change the default value of unique_writer_identity in resource logging_project_sink to true.

[pengq-google]

Change the default value of unique_writer_identity in resource logging_project_sink to true. unique_writer_identity = false is legacy behavior. New sinks should always set this field to be true.

Release Note Template for Downstream PRs (will be copied)

Change the default value of unique_writer_identity in resource logging_project_sink to true. unique_writer_identity = false is legacy behavior. New sinks should always set this field to be true.

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[pengq-google]

@shuyama1
I know this is a breaking change. however, if I keep [pengq-google](https://github.com/pengq-google) wants to merge 1 commit into [GoogleCloudPlatform:main](https://github.com/GoogleCloudPlatform/magic-modules/tree/main) from [pengq-google:b9](https://github.com/pengq-google/magic-modules/tree/b9), it will only show 2 files changed.

If I change it to the 5.0.0 branch, will be 129 files changes, but i didn't do anything...

[pengq-google]

even with newly create clean branch, if I made a pr to 5.0.0, it will have many changed files, seems the user experience changed today.
#8849

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field unique_writer_identity default value changed from false to true on google_logging_project_sink - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 21 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3008
Passed tests 2704
Skipped tests: 296
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareDatasetIamPolicy|TestAccLoggingProjectSink_described|TestAccLoggingProjectSink_disabled|TestAccLoggingProjectSink_updatePreservesUniqueWriter|TestAccLoggingProjectSink_described_update|TestAccLoggingProjectSink_heredoc|TestAccLoggingProjectSink_updateBigquerySink|TestAccLoggingProjectSink_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccLoggingProjectSink_described[Debug log]
TestAccLoggingProjectSink_disabled[Debug log]
TestAccLoggingProjectSink_updatePreservesUniqueWriter[Debug log]
TestAccLoggingProjectSink_described_update[Debug log]
TestAccLoggingProjectSink_heredoc[Debug log]
TestAccLoggingProjectSink_updateBigquerySink[Debug log]
TestAccLoggingProjectSink_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[trodge]

even with newly create clean branch, if I made a pr to 5.0.0, it will have many changed files, seems the user experience changed today. #8849

Can you try rebasing on the 5.0.0 branch?

[pengq-google]

I just made a new pr: #8875 and will close this one. Thanks!