Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Network Attachment resource #8688

Merged
merged 9 commits into from
Aug 28, 2023

Conversation

maxi-cit
Copy link
Contributor

@maxi-cit maxi-cit commented Aug 17, 2023

Addition of Network Attachment (new resource) to compute product

This PR solves: hashicorp/terraform-provider-google#15310

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_compute_network_attachment

API reference: https://cloud.google.com/compute/docs/reference/rest/v1/networkAttachments

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will require approval to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 17, 2023
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 21, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1113 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 1113 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 139 insertions(+))
TF OiCS: Diff ( 4 files changed, 122 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_network_attachment (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_network_attachment" "primary" {
  producer_accept_lists = # value needed
  producer_reject_lists = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2984
Passed tests 2685
Skipped tests: 295
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccComputeNetworkAttachment_networkAttachmentBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Error message] [Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Error message] [Debug log]
TestAccComputeNetworkAttachment_networkAttachmentBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 22, 2023
@maxi-cit maxi-cit marked this pull request as ready for review August 23, 2023 17:18
@maxi-cit maxi-cit changed the title first draft for new Network Attachment resource Add Network Attachment resource Aug 23, 2023
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 25, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 209 insertions(+))
Terraform Beta: Diff ( 5 files changed, 1114 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 156 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2989
Passed tests 2691
Skipped tests: 296
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeNetworkAttachment_networkAttachmentBasicExample|TestAccDataprocJobIamPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeNetworkAttachment_networkAttachmentBasicExample[Debug log]
TestAccDataprocJobIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@maxi-cit
Copy link
Contributor Author

Hello @trodge, could you give it a check, please?

nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023
* first draft for new Network Attachment resource

* updated NetworkAttachment specification file

* added usage example for Network Attachment with GCE Instance

* verified attributes and descriptions

* enhanced network attachment examples
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Aug 29, 2023
* first draft for new Network Attachment resource

* updated NetworkAttachment specification file

* added usage example for Network Attachment with GCE Instance

* verified attributes and descriptions

* enhanced network attachment examples
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
* first draft for new Network Attachment resource

* updated NetworkAttachment specification file

* added usage example for Network Attachment with GCE Instance

* verified attributes and descriptions

* enhanced network attachment examples
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
* first draft for new Network Attachment resource

* updated NetworkAttachment specification file

* added usage example for Network Attachment with GCE Instance

* verified attributes and descriptions

* enhanced network attachment examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants