-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default value for rule.rate_limit_options.encorce_on_key on re… #8804
Remove default value for rule.rate_limit_options.encorce_on_key on re… #8804
Conversation
…source google_compute_security_policy
Hi there, I'm the Modular magician. I've detected the following information about your changes: Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be sure to tag the issue this closes/is a part of
2afc9e6
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-5.0.0
…licy (hashicorp#8806) GoogleCloudPlatform/magic-modules#8804 Signed-off-by: Modular Magician <[email protected]>
…licy (hashicorp#8806) GoogleCloudPlatform/magic-modules#8804 Signed-off-by: Modular Magician <[email protected]>
…licy (#8806) (#6176) GoogleCloudPlatform/magic-modules#8804 Signed-off-by: Modular Magician <[email protected]>
…licy (#8806) (#15683) GoogleCloudPlatform/magic-modules#8804 Signed-off-by: Modular Magician <[email protected]>
…source google_compute_security_policy
Remove default value for rule.rate_limit_options.encorce_on_key
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)