Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default value for the field rule.rate_limit_options.enforce_on_key on resource google_compute_security_policy #13883

Closed
zli82016 opened this issue Mar 2, 2023 · 2 comments
Assignees
Labels
breaking-change persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work service/terraform size/s
Milestone

Comments

@zli82016
Copy link
Collaborator

zli82016 commented Mar 2, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Affected Resource(s)

  • google_compute_security_policy

Terraform Configuration Files

# Copy-paste your Terraform configurations here.
#
# For large Terraform configs, please use a service like Dropbox and share a link to the ZIP file.
# For security, you can also encrypt the files using our GPG public key:
#    https://www.hashicorp.com/security
#
# If reproducing the bug involves modifying the config file (e.g., apply a config,
# change a value, apply the config again, see the bug), then please include both:
# * the version of the config before the change, and
# * the version of the config after the change.

Debug Output

Panic Output

Expected Behavior

  1. The default value of the field rule.rate_limit_options.enforce_on_key should be removed, which is a breaking change. More context can be found in the PR
    https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/resources/resource_compute_security_policy.go.erb#L263

  2. Remove empty string from the allowed value of the field rule.rate_limit_options.enforce_on_key
    https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/resources/resource_compute_security_policy.go.erb#L265

  3. Remove enforce_on_key = "" from the tests
    https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/tests/resource_compute_security_policy_test.go.erb#L1204

    https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/tests/resource_compute_security_policy_test.go.erb#L1250

  4. Remove enforce_on_key = "" from the doc example
    https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/website/docs/r/compute_security_policy.html.markdown?plain=1#L142

Actual Behavior

Steps to Reproduce

  1. terraform apply

Important Factoids

References

  • #0000
@rileykarson rileykarson added persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work and removed bug labels Mar 6, 2023
@rileykarson rileykarson added this to the 5.0.0 Under Consideration milestone Mar 20, 2023
@hao-nan-li
Copy link
Collaborator

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change persistent-bug Hard to diagnose or long lived bugs for which resolutions are more like feature work than bug work service/terraform size/s
Projects
None yet
Development

No branches or pull requests

4 participants