Change the default value of unique_writer_identity in resource logging_project_sink to true.

[pengq-google]

Change the default value of unique_writer_identity in resource logging_project_sink to true. unique_writer_identity = false is legacy behavior. New sinks should always set this field to be true.

Release Note Template for Downstream PRs (will be copied)

logging: changed the default value of `unique_writer_identity` from `false` to `true` in `google_logging_project_sink`.

[pengq-google]

@shuyama1
Please take a look for this pr. Thank you for helping me along the way! :)

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field unique_writer_identity default value changed from false to true on google_logging_project_sink - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 23 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 2 files changed, 23 insertions(+), 32 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field unique_writer_identity default value changed from false to true on google_logging_project_sink - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 24 insertions(+), 32 deletions(-))
Terraform Beta: Diff ( 2 files changed, 24 insertions(+), 32 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3002
Passed tests 2697
Skipped tests: 301
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingProjectSink_described_update|TestAccLoggingProjectSink_described|TestAccLoggingProjectSink_updateBigquerySink|TestAccLoggingProjectSink_basic

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLoggingProjectSink_described_update[Debug log]
TestAccLoggingProjectSink_described[Debug log]
TestAccLoggingProjectSink_updateBigquerySink[Debug log]
TestAccLoggingProjectSink_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test