-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: BigLake API Database Resource #8753
Add: BigLake API Database Resource #8753
Conversation
Hello! I am a robot. It looks like you are a: @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
All PRs For BigLake APIs github.com//pull/8751 |
note Provider File is in Catalog PR: go/magic-modules/pull/8751 I learned you can't generate the documentation without this file. |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFolderIamPolicy_basic |
Rerun these tests in REPLAYING mode to catch issues
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 942 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBiglakeDatabase_bigqueryBiglakeDatabaseExample |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this looks pretty good! I just have a couple comments/questions on some fields where immutable/required can probably be added.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 940 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests:
|
* Add: BigLake api Database Resource * add: database example * add: database update test * update: test fields * update: mark `catalog_id` required + immutable * update: `type` field. use string, mark required * update: mark hiveoptions req
* Add: BigLake api Database Resource * add: database example * add: database update test * update: test fields * update: mark `catalog_id` required + immutable * update: `type` field. use string, mark required * update: mark hiveoptions req
* Add: BigLake api Database Resource * add: database example * add: database update test * update: test fields * update: mark `catalog_id` required + immutable * update: `type` field. use string, mark required * update: mark hiveoptions req
* Add: BigLake api Database Resource * add: database example * add: database update test * update: test fields * update: mark `catalog_id` required + immutable * update: `type` field. use string, mark required * update: mark hiveoptions req
Add: BigLake API Database Resource
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)