Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: BigLake API Database Resource #8753

Merged
merged 8 commits into from
Aug 28, 2023

Conversation

nevzheng
Copy link
Contributor

@nevzheng nevzheng commented Aug 23, 2023

Add: BigLake API Database Resource

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_biglake_database

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@nevzheng nevzheng changed the title Add: BigLake API Database resource Add: BigLake API Database Resource Aug 23, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@nevzheng
Copy link
Contributor Author

All PRs For BigLake APIs

github.com//pull/8751
github.com//pull/8753
github.com//pull/8754

@nevzheng
Copy link
Contributor Author

note Provider File is in Catalog PR: go/magic-modules/pull/8751

I learned you can't generate the documentation without this file.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2987
Passed tests 2690
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFolderIamPolicy_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFolderIamPolicy_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 942 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 942 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 116 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2995
Passed tests 2698
Skipped tests: 296
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccBiglakeDatabase_bigqueryBiglakeDatabaseExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccBiglakeDatabase_bigqueryBiglakeDatabaseExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this looks pretty good! I just have a couple comments/questions on some fields where immutable/required can probably be added.

mmv1/products/bigquerybiglake/Database.yaml Show resolved Hide resolved
mmv1/products/bigquerybiglake/Database.yaml Show resolved Hide resolved
mmv1/products/bigquerybiglake/Database.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 940 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 940 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 116 insertions(+))
TF OiCS: Diff ( 4 files changed, 131 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2996
Passed tests 2700
Skipped tests: 296
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@slevenick slevenick merged commit 29b47d9 into GoogleCloudPlatform:main Aug 28, 2023
@nevzheng nevzheng deleted the add-biglake-database branch August 28, 2023 22:57
nevzheng added a commit to nevzheng/magic-modules that referenced this pull request Aug 28, 2023
* Add: BigLake api Database Resource

* add: database example

* add: database update test

* update: test fields

* update: mark `catalog_id` required + immutable

* update: `type` field. use string, mark required

* update: mark hiveoptions req
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Aug 29, 2023
* Add: BigLake api Database Resource

* add: database example

* add: database update test

* update: test fields

* update: mark `catalog_id` required + immutable

* update: `type` field. use string, mark required

* update: mark hiveoptions req
RileyHYZ pushed a commit to RileyHYZ/magic-modules that referenced this pull request Sep 15, 2023
* Add: BigLake api Database Resource

* add: database example

* add: database update test

* update: test fields

* update: mark `catalog_id` required + immutable

* update: `type` field. use string, mark required

* update: mark hiveoptions req
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
* Add: BigLake api Database Resource

* add: database example

* add: database update test

* update: test fields

* update: mark `catalog_id` required + immutable

* update: `type` field. use string, mark required

* update: mark hiveoptions req
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants