-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.42.0 #3291
Merged
Merged
Release 1.42.0 #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding warning for pre-existing vpc subnets with private google acces…
The use of source = "../.." notation within the Toolkit modules makes the Toolkit a complete "package" of Terraform modules. This means the whole set of Toolkit modules must be copied starting at the root directory. However, any use of a leading ".." or "./" in the source line in our YAML blueprint, will only stage the final directory into the deployment folder. This changes causes failure whenever a locally staged copy of a module known to be embedded in the Toolkit is referenced. We anticipate retiring embedding modules in favor of fully remote modules.
Use local paths to embedded modules throughout Toolkit
Co-authored-by: Tom Downes <[email protected]>
Fix a bug where try was hiding extraction of gpu driver version
SlurmGCP. Don't use remote module to create controller instance
Fix the gpu_installation_config default for case where no customer input
Comment out pluging of `gpu-test`
SlurmGCP. Fix bug that prevents resourcePolicies clean up.
Update Toolkit release to v1.42.0
tpdownes
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending final review of release notes by team. Update the description once that is complete.
cdunbar13
approved these changes
Nov 20, 2024
Adding do-not-merge label until we approve release notes. Otherwise, good-to-go. |
I've updated the description with the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Key New Features 🎉
Module Improvements 🔨
use_job_duration
option by @abbas1902 in Adduse_job_duration
option #3142Improvements 🛠
set -e
to prolog mux by @mr0re1 in SlurmGCP. Addset -e
to prolog mux #3215Deprecations 💤
Version Updates ⏫
Bug fixes 🐞
New Contributors
Full Changelog: v1.41.0...v1.42.0