Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt google Terraform plugin v6.10.0 and drop support for 5.x #3189

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Adopt google Terraform plugin v6.10.0 and drop support for 5.x #3189

merged 1 commit into from
Nov 11, 2024

Conversation

tpdownes
Copy link
Member

  • TPG 5.x is no longer supported or maintained for anything except critical backports
  • The filestore module will soon support only TPG 6.4 and above, effectively making most of our blueprints require TPG 6.4+

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@tpdownes tpdownes self-assigned this Oct 30, 2024
@tpdownes tpdownes force-pushed the drop_tpg_5 branch 6 times, most recently from 7ab31d1 to 53d6c32 Compare November 5, 2024 16:22
@tpdownes tpdownes closed this Nov 5, 2024
@tpdownes tpdownes deleted the drop_tpg_5 branch November 5, 2024 16:23
@tpdownes tpdownes restored the drop_tpg_5 branch November 5, 2024 16:23
@tpdownes tpdownes reopened this Nov 5, 2024
@tpdownes tpdownes force-pushed the drop_tpg_5 branch 3 times, most recently from 8d93cec to 65377dc Compare November 8, 2024 14:03
@tpdownes tpdownes mentioned this pull request Nov 8, 2024
Merged
@tpdownes tpdownes force-pushed the drop_tpg_5 branch 3 times, most recently from 2e12020 to 186f2e2 Compare November 8, 2024 16:11
@tpdownes
Drop support for TPG v5
bfe2d47 
- TPG 5.x is no longer supported or maintained for anything except
  critical backports
- The filestore module will soon support only TPG 6.4 and above,
  effectively making most of our blueprints require TPG 6.4+
@tpdownes tpdownes assigned RachaelSTamakloe and unassigned tpdownes Nov 8, 2024
@tpdownes tpdownes marked this pull request as ready for review November 8, 2024 22:07
@tpdownes tpdownes added the release-key-new-features Added to release notes under the "Key New Features" heading. label Nov 8, 2024
@tpdownes tpdownes changed the title Drop support for TPG v5 Adopt google Terraform plugin v6.10.0 and drop support for 5.x Nov 8, 2024
@tpdownes tpdownes merged commit fa86e8a into GoogleCloudPlatform:develop Nov 11, 2024
10 of 59 checks passed
@tpdownes tpdownes deleted the drop_tpg_5 branch November 11, 2024 17:04
@rohitramu rohitramu mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RachaelSTamakloe RachaelSTamakloe RachaelSTamakloe approved these changes

Assignees

@RachaelSTamakloe RachaelSTamakloe

Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @RachaelSTamakloe