Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert use of toolkit_modules_url in examples #3239

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Nov 8, 2024

Versioned blueprints is a feature in development and should not yet be the default in our public examples. In particular, the use of an older Toolkit release blocks migration to TPG 6.x as our default (#3189)

This reverts commit 5cb64ac.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

…oolkit"

This reverts commit 5cb64ac.
@tpdownes tpdownes added the release-chore To not include into release notes label Nov 8, 2024
@tpdownes tpdownes merged commit 2939787 into GoogleCloudPlatform:develop Nov 8, 2024
9 of 57 checks passed
@tpdownes tpdownes deleted the do_not_use_toolkit_modules_yet branch November 8, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants