Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bucket module within Slurm controller module #3161

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

tpdownes
Copy link
Member

  • Support terraform-provider-google v6

Without this update, any blueprint that uses the Slurm v6 controller module will default to TPG 5.44.2 instead of 6.8.0.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

- Support terraform-provider-google v6
@tpdownes tpdownes added the release-version-updates Added to release notes under the "Version Updates" heading. label Oct 23, 2024
@tpdownes tpdownes merged commit cb5e659 into GoogleCloudPlatform:develop Oct 24, 2024
10 of 57 checks passed
@tpdownes tpdownes deleted the update_bucket branch October 24, 2024 17:30
@rohitramu rohitramu mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version-updates Added to release notes under the "Version Updates" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants