-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fetching and caching job details #3194
Merged
harshthakkar01
merged 1 commit into
GoogleCloudPlatform:develop
from
harshthakkar01:cache-jobs
Nov 7, 2024
Merged
Improve fetching and caching job details #3194
harshthakkar01
merged 1 commit into
GoogleCloudPlatform:develop
from
harshthakkar01:cache-jobs
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshthakkar01
force-pushed
the
cache-jobs
branch
from
October 30, 2024 21:25
e7b679e
to
d337a2e
Compare
mr0re1
reviewed
Oct 30, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Oct 30, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Oct 30, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Oct 30, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Oct 30, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
harshthakkar01
force-pushed
the
cache-jobs
branch
2 times, most recently
from
November 3, 2024 00:03
4ece865
to
c55ef89
Compare
harshthakkar01
added
the
release-improvements
Added to release notes under the "Improvements" heading.
label
Nov 3, 2024
mr0re1
reviewed
Nov 4, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 4, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 4, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 4, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
harshthakkar01
force-pushed
the
cache-jobs
branch
2 times, most recently
from
November 6, 2024 19:19
4aff1c4
to
b59abc6
Compare
harshthakkar01
changed the title
Improve caching job details and fetch more job details
Improve fetching and caching job details
Nov 6, 2024
mr0re1
reviewed
Nov 6, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 6, 2024
...y/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/slurmsync.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 6, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 6, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 6, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 6, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 6, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 6, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
harshthakkar01
force-pushed
the
cache-jobs
branch
3 times, most recently
from
November 7, 2024 17:53
1fceb56
to
7879efc
Compare
mr0re1
reviewed
Nov 7, 2024
community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/util.py
Outdated
Show resolved
Hide resolved
mr0re1
reviewed
Nov 7, 2024
...les/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/tests/test_util.py
Show resolved
Hide resolved
mr0re1
approved these changes
Nov 7, 2024
mr0re1
reviewed
Nov 7, 2024
...les/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/tests/test_util.py
Show resolved
Hide resolved
harshthakkar01
force-pushed
the
cache-jobs
branch
from
November 7, 2024 19:11
7879efc
to
d88cd50
Compare
harshthakkar01
merged commit Nov 7, 2024
ba8b179
into
GoogleCloudPlatform:develop
8 of 56 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual testing
Unit test
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.