Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fetching and caching job details #3194

Merged

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented Oct 30, 2024

Manual testing

2024-11-06 19:18:10,905 INFO: Printing job details --> [Job(id='5', name='test', required_nodes=None, job_state='RUNNING', duration=datetime.timedelta(days=365)), Job(id='6', name='test', required_nodes=None, job_state='PENDING', duration=None), Job(id='7', name='test', required_nodes=None, job_state='PENDING', duration=None), Job(id='8', name='test', required_nodes=None, job_state='PENDING', duration=None)]
2024-11-06 19:18:10,906 INFO: keep jobs --> {'7', '0', '8', '6', '5'}

Unit test

(virtualenv) harshthakkar@harshthakkar:~/github/workspace/hpc-toolkit$ pytest community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/tests/test_util.py
============================================================================================================================= test session starts ==============================================================================================================================
platform linux -- Python 3.11.9, pytest-8.3.3, pluggy-1.5.0
rootdir: /usr/local/google/home/harshthakkar/github/workspace/hpc-toolkit
configfile: .pytest.ini
plugins: mock-3.14.0
collected 32 items

community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/tests/test_util.py ................................                                                                                                                              [100%]

============================================================================================================================== 32 passed in 0.49s ==============================================================================================================================

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 self-assigned this Oct 31, 2024
@harshthakkar01 harshthakkar01 force-pushed the cache-jobs branch 2 times, most recently from 4ece865 to c55ef89 Compare November 3, 2024 00:03
@harshthakkar01 harshthakkar01 added the release-improvements Added to release notes under the "Improvements" heading. label Nov 3, 2024
@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 Nov 4, 2024
@harshthakkar01 harshthakkar01 force-pushed the cache-jobs branch 2 times, most recently from 4aff1c4 to b59abc6 Compare November 6, 2024 19:19
@harshthakkar01 harshthakkar01 changed the title Improve caching job details and fetch more job details Improve fetching and caching job details Nov 6, 2024
@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 Nov 6, 2024
@harshthakkar01 harshthakkar01 force-pushed the cache-jobs branch 3 times, most recently from 1fceb56 to 7879efc Compare November 7, 2024 17:53
@harshthakkar01 harshthakkar01 requested a review from mr0re1 November 7, 2024 17:57
@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 Nov 7, 2024
@harshthakkar01 harshthakkar01 merged commit ba8b179 into GoogleCloudPlatform:develop Nov 7, 2024
8 of 56 checks passed
@rohitramu rohitramu mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants