Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the new-project module to support adoption of TPG v6 #3171

Merged

Conversation

RachaelSTamakloe
Copy link
Collaborator

@RachaelSTamakloe RachaelSTamakloe commented Oct 25, 2024

This pr does the following:

  • It removes the new-project module from the Cluster Toolkit and leaves behind a directory that contains only a community/modules/project/new-project/README.md file that recommends the use of the upstream module (terraform-google-project-factory) to create and manage GCP projects.

The new-project module has been marked experimental since its introduction in November 2021 and it is not present in any customer-facing examples. The module, as written(using version 11.3), blocks adopting TPG 6.x support.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe added the release-version-updates Added to release notes under the "Version Updates" heading. label Oct 25, 2024
@tpdownes tpdownes added release-deprecations Added to release notes under the "Deprecations" heading. and removed release-version-updates Added to release notes under the "Version Updates" heading. labels Oct 28, 2024
@RachaelSTamakloe RachaelSTamakloe merged commit c7f9795 into GoogleCloudPlatform:develop Oct 28, 2024
12 of 61 checks passed
@rohitramu rohitramu mentioned this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-deprecations Added to release notes under the "Deprecations" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants