NEP29: Set minimum required versions to NumPy 1.17+ and Python 3.7+ #1074

weiji14 · 2021-03-18T00:49:37Z

Description of proposed changes

Start adopting NEP29 - Recommend Python and NumPy version support as a community policy standard, see https://numpy.org/neps/nep-0029-deprecation_policy.html. Also modifies the Github Actions CI test matrix to test only minimum (NumPy1.17/Python3.7) and maximum (NumPy1.20/Python3.9) versions only.

Bumps minimum supported NumPy version to 1.17 in the setup.py, requirements.txt and environment.yml files. Also set minimum required Python version to be 3.7+.

Note: Will also need to modify the conda-forge pygmt-feedstock recipe to set these minimum required versions, specifically at https://github.com/conda-forge/pygmt-feedstock/blob/823be1f1bf96e6a33725ef7d9c016a0da645b1a9/recipe/meta.yaml#L27-L30

TODO also:

Change branch protection rules to use the NumPy version specifc tests (e.g. 'ubuntu-latest - Python 3.7 / NumPy 1.17 ')
Document the NEP29 policy somewhere as per https://numpy.org/neps/nep-0029-deprecation_policy.html#implementation

Fixes #690

Reminders

Run make format and make check to make sure the code follows the style guide.
Add tests for new features or tests that would have caught the bug that you're fixing.
Add new public functions/methods/classes to doc/api/index.rst.
Write detailed docstrings for all functions/methods.
If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

/format: automatically format and lint the code
/test-gmt-dev: run full tests on the latest GMT development version

Start adopting NEP29 - Recommend Python and NumPy version support as a community policy standard, see https://numpy.org/neps/nep-0029-deprecation_policy.html. Bumps minimum supported NumPy version to 1.17 in the setup.py, requirements.txt and environment.yml files. Also set minimum required Python version to be 3.7+.

Test only on minimum and maximum supported versions according to NEP. I.e. minimum of NumPy 1.17 and Py3.7, maximum of NumPy 1.20 and Py3.9. This drops testing on the middle Python 3.8 version to conserve CI resources.

…y1.20

weiji14 · 2021-03-23T04:03:51Z

MAINTENANCE.md

+In `setup.py`, the `python_requires` variable should be set to the minimum
+supported version of Python. Minimum Python and NumPy version support should be
+adjusted upward on every major and minor release, but never on a patch release.


I didn't add the line "All supported minor versions of Python should be in the test matrix and have binary artifacts built for the release." as in https://numpy.org/neps/nep-0029-deprecation_policy#implementation because:

We're not testing the middle Python version (Python 3.8)

We're using no-arch builds on conda-forge and a single PyGMT Python 3 wheel on PyPI, instead of having specific binary artifacts for each Python version.

Sounds good to me.

weiji14 · 2021-03-23T04:05:40Z

README.rst

+Compatibility with GMT and Python/NumPy versions
+------------------------------------------------

-======= ========== =========
-PyGMT   GMT        Python
-======= ========== =========
+======= ========== ========= =========
+PyGMT   GMT        Python    NumPy
+======= ========== ========= =========
+0.4.x   >=6.2.0    >=3.7     >=1.17.0


Is it a good idea to add this here now, or should we do it during the v0.4.0 release process instead?

We should add it when we release v0.4.0, but I'm afraid we may forget it during the release process. I think it's fine to add this here.

seisman · 2021-03-23T05:27:51Z

README.rst

+Compatibility with GMT and Python/NumPy versions
+------------------------------------------------

-======= ========== =========
-PyGMT   GMT        Python
-======= ========== =========
+======= ========== ========= =========
+PyGMT   GMT        Python    NumPy
+======= ========== ========= =========
+0.4.x   >=6.2.0    >=3.7     >=1.17.0


We should add it when we release v0.4.0, but I'm afraid we may forget it during the release process. I think it's fine to add this here.

MAINTENANCE.md

seisman

Looks good!

weiji14 · 2021-03-24T21:18:12Z

Change branch protection rules to use the NumPy version specifc tests (e.g. 'ubuntu-latest - Python 3.7 / NumPy 1.17 ')

Ok, I've updated the branch protection rules so our test matrix now has 6 instead of 9 tests. Hopefully this decreases the chances of those random Windows failures!

Follow NEP29 (xref GenericMappingTools/pygmt#1074), setting minimum required versions to NumPy 1.17+ and Python 3.7+. Also set minimum of GMT 6.2.0 as per GenericMappingTools/pygmt#1321.

* updated v0.4.0 * MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.10.3, and conda-forge-pinning 2021.06.21.02.43.59 * Pin minimum required dependency versions Follow NEP29 (xref GenericMappingTools/pygmt#1074), setting minimum required versions to NumPy 1.17+ and Python 3.7+. Also set minimum of GMT 6.2.0 as per GenericMappingTools/pygmt#1321. Co-authored-by: Wei Ji <[email protected]>

Bumps [numpy](https://github.com/numpy/numpy) from 1.20.3 to 1.21.0 released on 23 June 2021. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/v1.21.0/doc/changelog/1.21.0-changelog.rst) - [Commits](https://github.com/GenericMappingTools/pygmt/pull/numpy/[email protected]) This is in line with PyGMT's policy on NEP29 at https://www.pygmt.org/v0.4.0/maintenance.html#dependencies-policy, xref #1074.

…enericMappingTools#1074) Start adopting NEP29 - Recommend Python and NumPy version support as a community policy standard, see https://numpy.org/neps/nep-0029-deprecation_policy.html. Bumps minimum supported NumPy version to 1.17 in the setup.py, requirements.txt and environment.yml files. Also set minimum required Python version to be 3.7+. * Modify CI test matrix to test on Numpy 1.17 and 1.20, Python 3.7 and 3.9 Test only on minimum and maximum supported versions according to NEP. I.e. minimum of NumPy 1.17 and Py3.7, maximum of NumPy 1.20 and Py3.9. This drops testing on the middle Python 3.8 version to conserve CI resources. * Add NumPy version to codecov reporting * Update website links of PyGMT deps to use https and official sources * Update MAINTENANCE.md to mention two Linux CI jobs are run in draft PRs * Place NEP29 dependencies policy in MAINTENANCE.md * List NumPy in compatibility version list on main README.rst page

Bumps [numpy](https://github.com/numpy/numpy) from 1.20.3 to 1.21.0 released on 23 June 2021. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/v1.21.0/doc/changelog/1.21.0-changelog.rst) - [Commits](https://github.com/GenericMappingTools/pygmt/pull/numpy/[email protected]) This is in line with PyGMT's policy on NEP29 at https://www.pygmt.org/v0.4.0/maintenance.html#dependencies-policy, xref GenericMappingTools#1074.

weiji14 added the deprecation Deprecating a feature label Mar 18, 2021

weiji14 added this to the 0.4.0 milestone Mar 18, 2021

vercel bot temporarily deployed to Preview March 18, 2021 00:58 Inactive

weiji14 force-pushed the adopt_nep29 branch from d189a45 to 9e641c2 Compare March 18, 2021 01:03

vercel bot temporarily deployed to Preview March 18, 2021 01:05 Inactive

Setup test matrix combinations (OS/Python/NumPy) explicitly

fcb6bad

vercel bot temporarily deployed to Preview March 18, 2021 01:25 Inactive

Try alternative way of excluding certain matrix builds during draft PR

5919ef8

vercel bot temporarily deployed to Preview March 18, 2021 01:48 Inactive

Include NumPy version in matrix build name

06b0022

vercel bot temporarily deployed to Preview March 18, 2021 01:55 Inactive

Try add isDraft variable to ubuntu-latest matrix builds too

1205006

vercel bot temporarily deployed to Preview March 18, 2021 02:03 Inactive

vercel bot temporarily deployed to Preview March 18, 2021 02:23 Inactive

Fancy ternary operator to pair Py3.7 with NumPy1.17 & Py3.9 with NumP…

2d293bb

…y1.20

weiji14 force-pushed the adopt_nep29 branch from 0453aa8 to 2d293bb Compare March 18, 2021 02:25

vercel bot temporarily deployed to Preview March 18, 2021 02:31 Inactive

vercel bot temporarily deployed to Preview March 18, 2021 02:47 Inactive

Use a less fancy way of setting min/max NEP29 versions for Python/NumPy

dd8863d

weiji14 force-pushed the adopt_nep29 branch from ba09c7e to dd8863d Compare March 18, 2021 02:49

vercel bot temporarily deployed to Preview March 18, 2021 03:01 Inactive

vercel bot temporarily deployed to Preview March 18, 2021 03:28 Inactive

Add NumPy version to codecov reporting and disable Linux py3.7 on draft

a8355b5

weiji14 force-pushed the adopt_nep29 branch from 43b8ec4 to a8355b5 Compare March 18, 2021 03:50

vercel bot temporarily deployed to Preview March 18, 2021 03:50 Inactive

Merge branch 'master' into adopt_nep29

69823ba

vercel bot temporarily deployed to Preview March 18, 2021 04:20 Inactive

vercel bot temporarily deployed to Preview March 23, 2021 04:00 Inactive

weiji14 commented Mar 23, 2021

View reviewed changes

seisman reviewed Mar 23, 2021

View reviewed changes

weiji14 added 2 commits March 23, 2021 19:46

Merge branch 'master' into adopt_nep29

52fdcb7

Remove hardcoded Python/NumPy versions in MAINTENANCE.md docs

1016331

vercel bot temporarily deployed to Preview March 23, 2021 06:47 Inactive

seisman approved these changes Mar 23, 2021

View reviewed changes

seisman added the final review call This PR requires final review and approval from a second reviewer label Mar 23, 2021

weiji14 self-assigned this Mar 24, 2021

weiji14 merged commit 955a55e into master Mar 24, 2021

weiji14 deleted the adopt_nep29 branch March 24, 2021 21:14

weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Mar 24, 2021

weiji14 mentioned this pull request Apr 6, 2021

What's the most Pythonic way for long GMT arguments? #1082

Open

weiji14 mentioned this pull request Jun 23, 2021

NEP29: Test PyGMT on NumPy 1.21 #1355

Merged

5 tasks

weiji14 mentioned this pull request Aug 10, 2021

NEP29: Set minimum required version to NumPy 1.18+ #1430

Merged

5 tasks

michaelgrund mentioned this pull request Dec 20, 2021

NEP29: Set minimum required version to NumPy 1.19+ #1675

Merged

6 tasks

weiji14 mentioned this pull request Jan 13, 2022

NEP29: Test PyGMT on NumPy 1.22 #1701

Merged

6 tasks

weiji14 mentioned this pull request Aug 17, 2022

NEP29: Test PyGMT on NumPy 1.23 and 1.21 #2057

Merged

6 tasks

seisman mentioned this pull request Dec 20, 2022

NEP29: Test PyGMT on NumPy 1.24 #2256

Merged

7 tasks

weiji14 mentioned this pull request Mar 3, 2023

NEP29: Set minimum required version to NumPy 1.21+ #2389

Merged

7 tasks

This was referenced Jun 20, 2023

NEP29: Test PyGMT on NumPy 1.25 #2581

Merged

NEP29: Set minimum required version to NumPy 1.22+ #2586

Merged

seisman mentioned this pull request Sep 17, 2023

NEP29: Test PyGMT on NumPy 1.26 #2692

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NEP29: Set minimum required versions to NumPy 1.17+ and Python 3.7+ #1074

NEP29: Set minimum required versions to NumPy 1.17+ and Python 3.7+ #1074

weiji14 commented Mar 18, 2021 •

edited

Loading

weiji14 Mar 23, 2021

seisman Mar 23, 2021

weiji14 Mar 23, 2021

seisman Mar 23, 2021

seisman Mar 23, 2021

seisman left a comment

weiji14 commented Mar 24, 2021 •

edited

Loading

NEP29: Set minimum required versions to NumPy 1.17+ and Python 3.7+ #1074

NEP29: Set minimum required versions to NumPy 1.17+ and Python 3.7+ #1074

Conversation

weiji14 commented Mar 18, 2021 • edited Loading

weiji14 Mar 23, 2021

Choose a reason for hiding this comment

seisman Mar 23, 2021

Choose a reason for hiding this comment

weiji14 Mar 23, 2021

Choose a reason for hiding this comment

seisman Mar 23, 2021

Choose a reason for hiding this comment

seisman Mar 23, 2021

Choose a reason for hiding this comment

seisman left a comment

Choose a reason for hiding this comment

weiji14 commented Mar 24, 2021 • edited Loading

weiji14 commented Mar 18, 2021 •

edited

Loading

weiji14 commented Mar 24, 2021 •

edited

Loading