Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP29: Set minimum required version to NumPy 1.21+ #2389

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 3, 2023

Description of proposed changes

Following NEP29 policy where NumPy 1.20 is to be dropped on or after 31 January 2023 (in a minor version increment, i.e. for PyGMT v0.9.0). Bumps minimum supported NumPy version to 1.21 in the pyproject.toml, requirements.txt and environment.yml files. Also update installation documentation to mention NumPy 1.21+ requirement.

This is in line with PyGMT's policy on NEP29 at https://www.pygmt.org/v0.8.0/maintenance.html#dependencies-policy, xref #1074.

Note that CI tests already run on NumPy 1.21 since #2057.

Supersedes #1985.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Following NEP29 policy. Bumps minimum supported
NumPy version to 1.21 in the pyproject.toml, requirements.txt and environment.yml files. Also update installation documentation to mention NumPy 1.21+ requirement.
@weiji14 weiji14 added the deprecation Deprecating a feature label Mar 3, 2023
@weiji14 weiji14 added this to the 0.9.0 milestone Mar 3, 2023
@weiji14 weiji14 self-assigned this Mar 3, 2023
@weiji14 weiji14 marked this pull request as ready for review March 3, 2023 04:30
@weiji14 weiji14 merged commit 8f31706 into main Mar 3, 2023
@weiji14 weiji14 deleted the nep29/python-3.8-numpy-1.21 branch March 3, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants