-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP29: Set minimum required version to NumPy 1.19+ #1675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@michaelgrund Better to change the title to "NEP29: Set minimum required version to NumPy 1.19+" following previous PRs #1430, #1074
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, agree with @seisman's statement to change the title above. Also, we'll need to update the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches to require Python 3.7 / NumPy 1.19
before merging.
Thanks 😉 |
Good to know, that needs to be done by an owner, correct @weiji14 ? |
Yep, just someone with admin privileges. I've done it already. Should be good to merge once status checks all pass. |
Great, thanks 😉 |
Description of proposed changes
Following NEP29 policy where NumPy 1.18 is to be dropped on or after Dec. 22, 2021 (in a minor version increment, i.e. for PyGMT v0.6.0). Bumps minimum supported NumPy version to 1.19 in the setup.py, requirements.txt and environment.yml files. Also update installation documentation and set CI tests to run on NumPy 1.19.
xref: #1430
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version