Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP29: Test PyGMT on NumPy 1.24 #2256

Merged
merged 1 commit into from
Dec 20, 2022
Merged

NEP29: Test PyGMT on NumPy 1.24 #2256

merged 1 commit into from
Dec 20, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 20, 2022

Description of proposed changes

Bumps NumPy to 1.24.0 released on 19 December 2022.

This is in line with PyGMT's policy on NEP29 at pygmt.org/v0.7.0/maintenance.html#dependencies-policy, xref #1074.

Note that the branch protection rules at GenericMappingTools/pygmt/settings/branches will need to be changed to use Python 3.10/Numpy 1.24 instead of Python 3.10/Numpy 1.23 before this Pull Request is merged.

Supersedes #1701, #2057

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Dec 20, 2022
@seisman seisman added this to the 0.8.0 milestone Dec 20, 2022
@seisman seisman requested a review from weiji14 December 20, 2022 09:06
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 20, 2022
65 tasks
@weiji14 weiji14 merged commit cdca634 into main Dec 20, 2022
@weiji14 weiji14 deleted the nep29/numpy-1.24 branch December 20, 2022 18:53
@weiji14 weiji14 mentioned this pull request Jun 20, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants