Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP29: Test PyGMT on NumPy 1.21 #1355

Merged
merged 1 commit into from
Jun 24, 2021
Merged

NEP29: Test PyGMT on NumPy 1.21 #1355

merged 1 commit into from
Jun 24, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jun 23, 2021

Description of proposed changes

Bumps numpy from 1.20.3 to 1.21.0 released on 23 June 2021.

This is in line with PyGMT's policy on NEP29 at https://www.pygmt.org/v0.4.0/maintenance.html#dependencies-policy, xref #1074.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Jun 23, 2021
@weiji14 weiji14 self-assigned this Jun 23, 2021
@weiji14 weiji14 marked this pull request as ready for review June 23, 2021 23:42
@weiji14
Copy link
Member Author

weiji14 commented Jun 23, 2021

Note that the branch protection rules at https://github.com/GenericMappingTools/pygmt/settings/branches will need to be changed to use Python 3.9/Numpy 1.21 instead of Python 3.9/Numpy 1.20 before this Pull Request is merged.

@seisman seisman added this to the 0.5.0 milestone Jun 24, 2021
@weiji14 weiji14 merged commit ba5af79 into master Jun 24, 2021
@weiji14 weiji14 deleted the nep29/numpy-1.21 branch June 24, 2021 02:08
@seisman seisman modified the milestones: 0.5.0, 0.4.1 Jul 25, 2021
@weiji14 weiji14 mentioned this pull request Jan 13, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants