Deploy Checklist: New Expensify 2024-08-28

[github-actions]

Release Version: 9.0.26-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Fix room chat avatar is different for user who creates room & who has been invited to room #37003
• fix: update logic to render thread divider in money report view #46866
• fix: button doesn’t work after using 3DS flow to add GBP payment card #46936
• Remove the emoji reaction when pressing on the added reaction #47038
• Fix: Navigated back to the home screen after granting for Camera permission #47222
• [NoQA] Feat/44313 edit settlement settings be integration #47309
• Delegate access: Add account switcher #47338
• [OldDot Rules Migration] Individual expense rules #47409
• Make onboarding continue from last visited onboarding page #47472
• Add disableAction to the rest of item in MoreFeaturePage #47533
• fix: [P2P Distance] - Distance unit in the system message changes from miles to mi after changing rate. #47605
• fix: only dismiss the report attachment modal once #47622
• fix: prevent creating workspace twice #47624
• re-create: Submit expense option is not disabled for users who are invited to expense report #47682
• fix: separate address line 1 and address line 2 #47709
• [CP Staging] Revert "Fix message highlight stuck when open the 2nd context menu" #47718
• [Perf] Improve open report action via search panel performance #47726
• Create status bar v2 #47753
• fix: clicking enter on emoji selector for status results in leaving status pane. #47761
• Fix bold tag isn't rendered as markdown when it has a style #47764
• Fix esc doesn't close modal if sidebar LHN isn't mounted #47768
• Default transactionThreadReportID to -1 in ReportActionsView #47781
• [Search] Move policyID into Search query syntax and remove policyIDs param #47787
• Fix chat get marked as read when opened from a notification #47801
• Add loading state to travel #47809
• Adding mass redirects to helpsite repo #47825
• Fix user is navigated to previous deeplink when re-login #47829
• fix: Self DM header shows skeleton loading #47831
• Show attachment error modal when trying to send corrupted file #47832
• fix enter key for got it button #47833
• [No QA] [3rd Party Feeds] Feeds Selector page #47851
• fix: improve performance in open chat finder page #47891
• fix: Unable to click Mark as cash button #47902
• fix: Search - Raw markdown symbols visible in search expense list. #47920
• Remove the dependency on the parent report when deciding if report can be approved #47926
• fix: Taxes - Name field is no longer grayed out after editing tax code offline. #47947
• Fix missing composer bottom margin in report RHP when going offline #47954
• Fix approver field disappears after deselecting the user #47955
• Prevent Lottie from running in the background after navigating to other pages #47960
• Remove onboarding video #47961
• Fix missing route and infinite route loading when categorizing track distance expense #47977
• fix styles #47978
• [No QA] [Workspace Feeds] Integrate Deactivate_Card API #47986
• Fix message highlight stuck when open the 2nd context menu #47993
• Fix screen behind RHP overlay changes when open contact method from teachers page #47999
• fix: open bank account step directly in bottom down flow #48006
• Fix able to scroll attachment while zoomed #48010
• [NO QA] Update Join-your-company's-workspace.md #48015
• fix: Remove tax features optimistically from distance features #48017
• Fixing help articles: Pay invoice, Send invoice, Approve and Pay #48022
• Remove dead code #48037
• fix tag filter duplicates #48074
• [NO QA] Improve react-compiler developer experience and docs #48078
• Revert "Make onboarding continue from last visited onboarding page" #48135
• bump react-native-collapsible version #48145
• [CP staging][FIX] iOS - Scan - After taking picture, image is not displayed on confirmation screen  #48194
• Fix "Worker was terminated" console error when closing a PDF before it finishes loading #48196
• Fix missed moved translation #48213
• [CP Staging] Use optional chaining fo backTo on NewContactMethodPage #48216
• [CP Staging] Revert "Prevent Lottie from running in the background after navigating to other pages" #48283
• Profile image upload option doesn't show #48286
• Revert "fix: remove Expensify employee from list participants" #48307
• [CP Staging] fix app freeze #48332

Deploy Blockers:

• [HOLD for Payment 2024-09-6][$250] iOS - Scan - After taking picture, image is not displayed on confirmation screen #48118
• [$250] Expense - App crashes after disabling billable option when expense is flagged as duplicate #48159
• [HOLD for payment 2024-10-01] [$250] [Android] When App is opened from notification the top safe area is missing #48190
• iOS Expense - App crashes when unselecting category after disabling all categories #48195
• [$250] iOS - Track expense - App crashes after deleting expense offline #48197
• [Workspace Feeds] [$250] Expensify card - Unable to issue new cards to members #48199
• [HOLD for payment 2024-09-12][Search v2.1] Workspace selected in workspace switcher resets to Expensify after switching status/tab #48240
• [payment due 9/6][$250] Avatar - Unable to choose profile avatar from library #48242
• [$250] Avatar - Avatar position moves after error appears (web), incorrect error position (native) #48244
• Account switcher - Unable to select account via keyboard #48245
• Copilot - Not here page opens on central pane when switching account on Subscription tab #48246
• Account switcher - App crashes when tapping on the currently active account #48247
• Web - App crashes when selecting add new contact method #48248
• Search - Header Pills are touching each other when highlighted, no spacing #48249
• Settings > Profile > Contact Methods > App crashes after tap on "New Contact Method" #48250
• Avatar - Invalid avatar format error does not disappear after switching account #48252
• Profile - Tapping on "Account name", shows interaction, but no redirection #48253
• Android - login -Tapping on magic link user cannot login #48254
• Profile - Avatar edit modal can be opened while app is loading #48259
• [Ready for payment] Account switcher - No spacing between account switcher icon and the status icon #48261
• Xero - App crashes when xero connected account disable 2FA and relog #48262
• [HOLD for payment Oct 4][$250] Attachment - Error not displayed when trying to upload corrupted pdf file to chat #48263
• Rules - Rules in left hand navigation does not follow the order in More features list #48266
• [$250] WS - "Rule" tab has unnecessarly long input field for "Days" section #48284
• [$250] iOS- Public room - App crashes when scrolling through #new-expensify-feedback & #exfy-roadmap #48296
• [HOLD for payment 2024-09-06] [$250] iOS - Wallet - Wallet page freezes after deleting bank account #48298
• Disrupted Tab Dragging Behavior #48356

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[neil-marcellini]

Checking off #48118

[puneetlath]

From the previous checklist:

#45150 - Pending validation on Desktop
#47123 - Pending validation on Native aps. Can you help validate internally?
#47607 - is failing on Desktop with #48147. Repro in PROD, checking off
#47678 - Failing on Android with original KI #47567 ok to check off?
#47816 - Failing with original KI #47240 (offline test). ok to check off?
#47821 - Pending validation on all platforms. Can you help validate internally?
#47844 - Pending validation on Desktop & failing with multiple issues
#47871 - Failing with #44148. repro in prod checking off
#48109 - it says it has not been deployed. Should we validate it?

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.26-0 🚀

[Julesssss]

Checked off #48244

[cristipaval]

Checked off #48246

[kavimuru]

Regression is 75% of progress
unchecked PRs:
#37003 Failing on mWeb with original KI #33470 Pending validation on iOS
#46936 Pending validation on all platforms
#47038 Pending validation on iOS app
#47222 Pending validation on iOS app
#47338 Failing on iOS and Android apps with #48242
#47624 iOS validation pending
#47682 Desktop and iOS pending
#47709 Failing on Android only with #45765
#47726 mweb validation pending
#47753 iOS validation pending
#47761 iOS validation pending
#47764 mweb validation pending
#47781 validation pending
#47801 Pending validation on Web, mWeb.
#47809 Pending validation on iOS
#47829 Pending validation on iOS
#47832 - Pending validation on iOS
#47902 #47902 (comment)
#47920 - Pending validation on Desktop, Android and iOS
#47926 - Pending validation on all platforms
#47960 - Pending validation on Native apps
#47961 - Pending validation on Web, Desktop, Android and iOS
#47977 - Pending validation on Desktop and Android
#47978 - Pending validation on mWeb, Desktop, Android, iOS
#47993 - Pending validation on Native apps
#47999 - Pending validation on mWeb, Desktop, Android, iOS
#48006 - Pending validation on all platforms
#48010 - Pending validation on Native apps
#48145 - Failing on Android with #43397 Pending validation iOS
#48196 - Pending validation on iOS

[Julesssss]

Checked off #48254 as i cannot reproduce. Magic code sign-in worked for me on both staging and prod Android apps.

[youssef-lr]

Checking off #48245, new feature and low priority issue

[kavimuru]

Regression is 9% left

unchecked PRs:
#37003 #37003 - Failing on mWeb with original KI #33470
#47038 #47038 - Pending validation on iOS app
#47338 #47338 - Failing on iOS and Android apps with #48242
#47472 Failing with #46104 in web mbwe desktop and andriod (ios pending)
#47624 iOS validation pending
#47682 Desktop and iOS pending
#47709 #47709 - Failing on Android only with #45765
#47764 Failing with the original KI in mweb #46891
#47781 validation pending
#47787 Failing with #48240
#47801 Pending validation on Web, mWeb.
#47809 #47809 - Pending validation on iOS
#47829 #47829 - Pending validation on iOS
#47832 Failing in iOS with #48263
#47902 #47902 (comment)
#47920 #47920 - Pending validation on iOS
#47926 #47926 - Pending validation on all platforms
#47960 #47960 - Pending validation on iOS
#47961 #47961 - Pending validation on iOS
#47977 #47977 - Pending validation on mweb
#47978 #47978 - Pending validation on mWeb, Android, iOS
#47993 #47993 - Pending validation on iOS
#47999 #47999 - Pending validation on iOS
#48006 #48006 - Pending validation on all platforms
#48010 #48010 - Pending validation on iOS
#48145 #48145 - Failing on Android with #43397 Pending validation iOS
#48196 #48196 - Pending validation on iOS
#48074 Pending validation in iOS

[kavimuru]

Regression is still 2% left.

Unchecked PRs:
#37003 #37003 - Failing on mWeb with original KI #33470
#47338 #47338 - Failing on iOS and Android apps with #48242
#47472 Failing with #46104
#47682 Desktop and iOS pending
#47709 #47709 - Failing on Android only with #45765
#47764 Failing with the original KI in mweb #46891
#47787 Failing with #48240
#47801 Pending validation on Web, mWeb.
#47809 Failing in iOS with #48305, repro in production checking it off
#47832 Failing in iOS with #48263
#47902 #47902 (comment)
#47926 #47926 - Pending validation on all platforms
#48145 #48145 - Failing on Android with #43397 Pending validation iOS
#48074 Pending validation in iOS
#48196 failing with #47810 in web

[kavimuru]

Regression is 2% left

Unchecked PRs:
#37003 - Failing in mWeb with original KI #33470, checking it off
#47338 - Failing on iOS and Android apps with #48242
#47472 Failing with original KI #46104, checking it off
#47682 Desktop and iOS pending validation
#47709 - Failing on Android only with #45765
#47764 Failing with the original KI in mweb #46891
#47787 Failing with #48240
#47801 Pending validation on Web, mWeb.
#47809 Failing in iOS with #48305, repro in production checking it off
#47832 Failing in iOS with #48263
#47902 (comment)
#47926 - Pending validation on all platforms
#48145 - Failing on Android with #43397 Pending validation iOS
#48196 failing in web and waiting for the tester to log bug
#46936 checked off as per #46936 (comment)
Deploy blockers:
#48197
#48242
#48296
#48298

[tsa321]

For #47472 , the PR was reverted by #48135 due to lint and typecheck errors during merging.

[mvtglobally]

Regression is Completed

Unchecked PRs:
#47338 - Failing on iOS and Android apps with #48242
#47787 Failing with #48240. pls double check as it was re-opened
#47902 (comment) - Can you QA internally ?

Checking off PRs
#48145 - Failing on Android with https://github.com/Expensify/App/issues/43397.repro in PROD checking off
#47682 - issue repro #34757, checking off
#47709 - Failing on Android only with #45765. repro in PROD Checking off

Deploy blockers:
#48197
#48298

[puneetlath]